From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B2632A0553 for ; Mon, 17 Feb 2020 18:45:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A61941DAA0; Mon, 17 Feb 2020 18:45:54 +0100 (CET) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 702121DAA0 for ; Mon, 17 Feb 2020 18:45:53 +0100 (CET) Received: by mail-wm1-f67.google.com with SMTP id c84so176549wme.4 for ; Mon, 17 Feb 2020 09:45:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=DVcIEDo7c9iQvHAtDC6fGXJ84DaaTBEJNGR4noG6zQI=; b=Cy+gofLVYagjctsthbFN46idnPz2XEM2Zwx6vGpeNtMpNZ/VPvxVa8Bsf4IkRa3mAw CKyLjM7v6nZ5DNxZGTE2P0m5IZJAEDi9PvfdlQaBQWEqb0b9uAo+ssWdvUPVEsRBLnfn 3N6gWEFhcZD+Z6mTIZXJy3KwyPSPYSsVyrC8CEWwGsvnmGImFDIbgRfvNpkZ9JNGsFhL lFSQRmZ/7TwyXFqvTpm1zV2le0K3r3Xj1kdahVdZoTGpM4G/Y9Am0yYFVd2nEAz7UY74 XjkQg5KpbcS7bUOj5zwoaXJkA+Jzs7X5syHVVymVJNVvp3/XWV7VIul6rg50n/abth5r mYXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DVcIEDo7c9iQvHAtDC6fGXJ84DaaTBEJNGR4noG6zQI=; b=VViSBHwicdpu61dIEabu2YSWn/ZUoKWLPBxbPJic+cIGXO2zi8EGKW6J9S7o982czO 8EfRXVCzfX7BYvsffoYTECa6TxDiLK6gMQ0BlTSWEQj13yb9KepRwMrU+AOjEXPuGwHp 2ULinqFyHTjjo7X+nqkVIuv9BW9XZYwKtHNwtgnhB+vyzeirPM/8vfq9WV2A+3U35rii ssklxOsua2BJBidh30i+y/J9LOTlf7a4RE23FReRTAqZUkNU8x/9Nx6cPSMWGJDdL8XJ OwrgyO/tL8/SSzpeIFHuhQc4gyM7/ptRc/Wl92hk+GSHBHL5CBKHt6iAc3Ubiq277NWP odqg== X-Gm-Message-State: APjAAAWX6EV75pQS/6Lzn7RmFaRv8/OsWdejsrmoGZct9SF8akAfD6dR f/Uj9qBIz7/bNMxF15l0ArEfIahCaZE= X-Google-Smtp-Source: APXvYqyjk/cCiTewh8S5z4fMetRDLWqZseeKkdvT2K8ktF1KHxFw2E6ySpe/M4bNct7SadHU2f0g3w== X-Received: by 2002:a1c:740a:: with SMTP id p10mr142215wmc.65.1581961553198; Mon, 17 Feb 2020 09:45:53 -0800 (PST) Received: from localhost (userh634.uk.uudial.com. [194.69.103.7]) by smtp.gmail.com with ESMTPSA id t10sm175604wmi.40.2020.02.17.09.45.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 09:45:52 -0800 (PST) From: luca.boccassi@gmail.com To: Gargi Sau Cc: Bruce Richardson , dpdk stable Date: Mon, 17 Feb 2020 17:44:54 +0000 Message-Id: <20200217174546.25334-2-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200217174546.25334-1-luca.boccassi@gmail.com> References: <20200211112216.3929-190-luca.boccassi@gmail.com> <20200217174546.25334-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'examples/ethtool: fix unchecked return value' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From ae4b345b73efc36b7f587104a7b5c09bbe395cc4 Mon Sep 17 00:00:00 2001 From: Gargi Sau Date: Mon, 9 Dec 2019 06:37:56 +0000 Subject: [PATCH] examples/ethtool: fix unchecked return value [ upstream commit 899f6de24bb6504d56369aef5f55bb370d58784d ] This checks the return value from the function rte_eth_dev_set_vlan_offload. Coverity issue: 350358 Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application") Signed-off-by: Gargi Sau Acked-by: Bruce Richardson --- examples/ethtool/lib/rte_ethtool.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c index 667d7eaf27..db8150efd5 100644 --- a/examples/ethtool/lib/rte_ethtool.c +++ b/examples/ethtool/lib/rte_ethtool.c @@ -402,7 +402,9 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id) } /* Enable Rx vlan filter, VF unspport status is discard */ - rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK); + ret = rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK); + if (ret != 0) + return ret; return 0; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-17 17:00:15.430059538 +0000 +++ 0002-examples-ethtool-fix-unchecked-return-value.patch 2020-02-17 17:00:15.263949832 +0000 @@ -1,14 +1,15 @@ -From 899f6de24bb6504d56369aef5f55bb370d58784d Mon Sep 17 00:00:00 2001 +From ae4b345b73efc36b7f587104a7b5c09bbe395cc4 Mon Sep 17 00:00:00 2001 From: Gargi Sau Date: Mon, 9 Dec 2019 06:37:56 +0000 Subject: [PATCH] examples/ethtool: fix unchecked return value +[ upstream commit 899f6de24bb6504d56369aef5f55bb370d58784d ] + This checks the return value from the function rte_eth_dev_set_vlan_offload. Coverity issue: 350358 Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application") -Cc: stable@dpdk.org Signed-off-by: Gargi Sau Acked-by: Bruce Richardson