From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C68FEA0553 for ; Mon, 17 Feb 2020 18:45:56 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B4DB11DAA0; Mon, 17 Feb 2020 18:45:56 +0100 (CET) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by dpdk.org (Postfix) with ESMTP id 0FE171DAA7 for ; Mon, 17 Feb 2020 18:45:55 +0100 (CET) Received: by mail-wm1-f65.google.com with SMTP id s144so406126wme.1 for ; Mon, 17 Feb 2020 09:45:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FV8BVa4zD5fAQNHfDEQPK84JpfRxqn7Jzqbz5cjAtg4=; b=gMEU9+kLMDvzhzT3OeCc/TPtqPk7r4xZEHm7XZ1IxNd15gjmPaBdCehaNErlYRrIIL udJVDnW8LuQdp0hFdTHY+RnhfZ4sqBOkjyH5cCNCGSvujxMc/JQwwt4zwaN1wI8lnLmN MHgh5tXKs243sEu1AYW177YDcEm5Ww0IJuOVsFE5G7yZIN91Z1pPBsGGcSdXJJAtmk4C LhU4khHftOg/YPuxQoVKN8GdtSxTsCJEBfRyfR6L/gNxDa7I5nmT9V5Xt7q5ucR3DCju UKSesBEYzmpfGHRK8BW8N62mQLq3DIXEaluXQiNRjtBCw5Kl39w3NHzVFb28zf5rnr9d 8zbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FV8BVa4zD5fAQNHfDEQPK84JpfRxqn7Jzqbz5cjAtg4=; b=j6zpM2P3Zf9V2SZoGR6JgwISyOA0ihGL5eoOut1sBqRdG8Q+piTo7aooNijTqMtBzV bg7uEEXUGhP2uP4QMvFS37Jb/nUk46apHSccKiQBA7MmPAZ0CCx86YCAs5ZEL2/ryw0Y I05UYcysGGnQgLBkkZ8xVX/p7k6zYp+3/rHTbMKmq/2SE3ZIo8xEKEkKmoq4elRQlHFa LdnJjhVxghgneKM5HWJF15JqfD44+tExlSZou55vGH9onkDt3qUEd73nkwp6qbdr6ha+ atY9Z92CzNCBYeAG78u3r8GyJflyKWH4GPSVx6dUUvo6aM4tfZAhg9QQIjtvm1zyRlIA tZ/A== X-Gm-Message-State: APjAAAXyil0cd6wUHPSrZ7NHVtu/UpEaLw97Fvz0FMaq7KM6FhmuaJJi okHJv/h4A3Ya9pHElrVqfvlKRUvMGco= X-Google-Smtp-Source: APXvYqzJI2SJbZgnARMtcsk/t/l2CCUyG8NQd2kX4n5/mFwsjR2kyFYeur2Jr5V/nXKy3yJQfXiavw== X-Received: by 2002:a1c:9ad6:: with SMTP id c205mr170998wme.78.1581961554762; Mon, 17 Feb 2020 09:45:54 -0800 (PST) Received: from localhost (userh634.uk.uudial.com. [194.69.103.7]) by smtp.gmail.com with ESMTPSA id j14sm1964211wrn.32.2020.02.17.09.45.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 09:45:54 -0800 (PST) From: luca.boccassi@gmail.com To: Praveen Shetty Cc: Bruce Richardson , dpdk stable Date: Mon, 17 Feb 2020 17:44:55 +0000 Message-Id: <20200217174546.25334-3-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200217174546.25334-1-luca.boccassi@gmail.com> References: <20200211112216.3929-190-luca.boccassi@gmail.com> <20200217174546.25334-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'examples/ioat: fix unchecked return value' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 727dfdf6df993015225cce1be5e66019ee8db288 Mon Sep 17 00:00:00 2001 From: Praveen Shetty Date: Thu, 28 Nov 2019 11:27:14 +0000 Subject: [PATCH] examples/ioat: fix unchecked return value [ upstream commit 4c2af82e542c51175781aebf8f1a9ccfef823a11 ] patch checks the return value of function rte_eth_dev_info_get, if return value is negative error message printed on the console. Coverity issue: 350361 Fixes: c8e6ceecebc1 ("examples/ioat: add new sample app for ioat driver") Signed-off-by: Praveen Shetty Acked-by: Bruce Richardson --- examples/ioat/ioatfwd.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index e9117718fe..b39a098ec0 100644 --- a/examples/ioat/ioatfwd.c +++ b/examples/ioat/ioatfwd.c @@ -824,7 +824,11 @@ port_init(uint16_t portid, struct rte_mempool *mbuf_pool, uint16_t nb_queues) /* Init port */ printf("Initializing port %u... ", portid); fflush(stdout); - rte_eth_dev_info_get(portid, &dev_info); + ret = rte_eth_dev_info_get(portid, &dev_info); + if (ret < 0) + rte_exit(EXIT_FAILURE, "Cannot get device info: %s, port=%u\n", + rte_strerror(-ret), portid); + local_port_conf.rx_adv_conf.rss_conf.rss_hf &= dev_info.flow_type_rss_offloads; if (dev_info.tx_offload_capa & DEV_TX_OFFLOAD_MBUF_FAST_FREE) -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-17 17:00:15.454061289 +0000 +++ 0003-examples-ioat-fix-unchecked-return-value.patch 2020-02-17 17:00:15.263949832 +0000 @@ -1,14 +1,15 @@ -From 4c2af82e542c51175781aebf8f1a9ccfef823a11 Mon Sep 17 00:00:00 2001 +From 727dfdf6df993015225cce1be5e66019ee8db288 Mon Sep 17 00:00:00 2001 From: Praveen Shetty Date: Thu, 28 Nov 2019 11:27:14 +0000 Subject: [PATCH] examples/ioat: fix unchecked return value +[ upstream commit 4c2af82e542c51175781aebf8f1a9ccfef823a11 ] + patch checks the return value of function rte_eth_dev_info_get, if return value is negative error message printed on the console. Coverity issue: 350361 Fixes: c8e6ceecebc1 ("examples/ioat: add new sample app for ioat driver") -Cc: stable@dpdk.org Signed-off-by: Praveen Shetty Acked-by: Bruce Richardson