From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDF72A0553 for ; Mon, 17 Feb 2020 18:45:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D4ECC1DAA8; Mon, 17 Feb 2020 18:45:58 +0100 (CET) Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) by dpdk.org (Postfix) with ESMTP id 973251DA12 for ; Mon, 17 Feb 2020 18:45:56 +0100 (CET) Received: by mail-wr1-f46.google.com with SMTP id w12so20789489wrt.2 for ; Mon, 17 Feb 2020 09:45:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Efo4zO2mwtbDAEczsYWRikbAP3o6kcXopP5RV6bqL6U=; b=uzyYCsRXJJJkhWbpcuKSRrrjvwwoUM5c/NDDUj82+G0/TuRDU623dwrbF9fYPQGyxc anLeW6WWyRuiIbG++JYbuza7uglKd3PdaicVxWB37hGwrr47lStHhCuKoM90HzNIxKKL j6rHU0Ez2XuUHeM5cZjqaJmit2ixTpZLKr0ZdZI5bv6Z/gQoHlNavG90mkP7qYuwtcXu Mwzo3A2pO1pN3/6LtgyNYTA/Mv+4SlAq7+XotPnEVjRvdOvGDpolYD2NjyDZ5TD1SWEk KcNa/02AUjwKFaE/wnNcJsFNCw/bgl8zTtHtumh8khjdyVYZ5yPSlN7Z3gTF6Yp37uXA mNRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Efo4zO2mwtbDAEczsYWRikbAP3o6kcXopP5RV6bqL6U=; b=PI3KPiiIXVQh4od/0mdZSpBhw4+9do4DWPnO82c3LjznBCoy22crYoglFG0gqnb84d Qcpq4t4BOWOh80jVa6bbSQRLa7UL/FMXtxhscWvnwMeyQWOjcejN0chbNF1O+/SBhCVg C05jWoSbptGFsOrb+Rg9arcXDhoNSTKp2ifUj8UI4fBj5ELippSwTh6QR2eH7/0IdA7I 1CMmXOeeLJjjyYoojOQ8/9C9ReHmUHEuDveueNO6yxon6kbVM5O7MlBIwv3GV2guRiG5 hdh+3QnYNQbNyaLwSDcJD/kLatxFgngB7ly80BuR4vpbePr6MbJhzhH6UfqmgRTfFQch SR6w== X-Gm-Message-State: APjAAAVtBRGQZ/g4ET2uWcYdUQrnRgzCTQ8TYM6kurR3USFn4eeF7dip EfsvJRzKkJ4S39OOlDHzW6JoBnUErKk= X-Google-Smtp-Source: APXvYqzdi0NDSszkH5toXCIoqamSsj836xeSPGJuigf2C+5guk93xpw2aLbh7QjcvPmZeljzMczwbg== X-Received: by 2002:a5d:6445:: with SMTP id d5mr23006058wrw.244.1581961556354; Mon, 17 Feb 2020 09:45:56 -0800 (PST) Received: from localhost (userh634.uk.uudial.com. [194.69.103.7]) by smtp.gmail.com with ESMTPSA id o4sm2047115wrx.25.2020.02.17.09.45.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 09:45:55 -0800 (PST) From: luca.boccassi@gmail.com To: Ciara Power Cc: Bruce Richardson , dpdk stable Date: Mon, 17 Feb 2020 17:44:56 +0000 Message-Id: <20200217174546.25334-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200217174546.25334-1-luca.boccassi@gmail.com> References: <20200211112216.3929-190-luca.boccassi@gmail.com> <20200217174546.25334-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'examples/ioat: fix failure check for ioat dequeue' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From b406a83fb4fa4e8223530226e39365094f515508 Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Tue, 4 Feb 2020 16:00:06 +0000 Subject: [PATCH] examples/ioat: fix failure check for ioat dequeue [ upstream commit 579fb0b2c33a0946f37d120c4e3837a0a3817a7d ] The nb_dq return value from the ioat dequeue is negative in failure cases, however the variable was an unsigned int, causing the condition where nb_dq <= 0 to never be true. This is now cast to a signed int, which will successfully reflect the -1 value to be used in this conditional check. Coverity issue: 350342 Coverity issue: 350349 Fixes: 92c981637ffc ("examples/ioat: handle failure case for ioat dequeue") Signed-off-by: Ciara Power Acked-by: Bruce Richardson --- examples/ioat/ioatfwd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ioat/ioatfwd.c b/examples/ioat/ioatfwd.c index b39a098ec0..8a6076828d 100644 --- a/examples/ioat/ioatfwd.c +++ b/examples/ioat/ioatfwd.c @@ -460,7 +460,7 @@ ioat_tx_port(struct rxtx_port_config *tx_config) MAX_PKT_BURST, NULL); } - if (nb_dq <= 0) + if ((int32_t) nb_dq <= 0) return; if (copy_mode == COPY_MODE_IOAT_NUM) -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-17 17:00:15.478858510 +0000 +++ 0004-examples-ioat-fix-failure-check-for-ioat-dequeue.patch 2020-02-17 17:00:15.267949888 +0000 @@ -1,8 +1,10 @@ -From 579fb0b2c33a0946f37d120c4e3837a0a3817a7d Mon Sep 17 00:00:00 2001 +From b406a83fb4fa4e8223530226e39365094f515508 Mon Sep 17 00:00:00 2001 From: Ciara Power Date: Tue, 4 Feb 2020 16:00:06 +0000 Subject: [PATCH] examples/ioat: fix failure check for ioat dequeue +[ upstream commit 579fb0b2c33a0946f37d120c4e3837a0a3817a7d ] + The nb_dq return value from the ioat dequeue is negative in failure cases, however the variable was an unsigned int, causing the condition where nb_dq <= 0 to never be true. This is now cast to a signed int, @@ -12,7 +14,6 @@ Coverity issue: 350342 Coverity issue: 350349 Fixes: 92c981637ffc ("examples/ioat: handle failure case for ioat dequeue") -Cc: stable@dpdk.org Signed-off-by: Ciara Power Acked-by: Bruce Richardson