From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 595D9A0553 for ; Mon, 17 Feb 2020 18:47:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 431801DA12; Mon, 17 Feb 2020 18:47:10 +0100 (CET) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 80E001DAAE for ; Mon, 17 Feb 2020 18:47:08 +0100 (CET) Received: by mail-wm1-f68.google.com with SMTP id b17so206043wmb.0 for ; Mon, 17 Feb 2020 09:47:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=bNBMBLMcMNzY37GlTy2yDPyTaiFB0gykWbS877Z7h/A=; b=oe2g5ZNTjnynVaeTw47RYV8zpbnxHjc9btU2okRM7SdY+Fo361tB363Jb3SsXQKkjt 74IOoJzMAi40WpHGCzp3noFgK1TBmnt9q7slan/Cu5XoX+x5O84Onl2PeiIDFR13KR0Z XzasmMGPxl+TPvgtJi2RyILhmheBsxdyHsa+wZ4GDBUkRfgQrmuDUAM0T/odzTkMdUmS BKJUwftwATYebVgP/Abzl+rS4rbd0MzXcv/WKjUS+m/DKbfB3OCbVHyr8qZdJ/gEI06K mSE1s03bsoUWCbfIEax40NgEVPyb7ozAjXwQchvlnP2kJkmPBLZnpZ1zK9u0XXRA7tr2 3fZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=bNBMBLMcMNzY37GlTy2yDPyTaiFB0gykWbS877Z7h/A=; b=VWKyqEhrNUxkiP7rfJ/ycJ+8xXHIGZci3XsKuzuE3WbK05DnSxiwEgCheYMTtj+iyg t975ZcYnauvx52oRV8RwxnxudSa7PyaTuUTNxsrAMMKvFfzo2vXVNF3iugRdD3WCS0Av IUyrxjE6hqWmhtXw7U0hU9rcbfjyp72u+ZePTFXo8bO8WqZ68iOnLm7uQmWEKSR47rcd 7iK1YewBqlWaIaEWKEK+KtrbJjcEeFrXZPcYFmxHErLDPZURtKI83JNPwR8UgH5pCfcC Pj3VVQfZwG8IfLWXIiQuOwuuBgCOHYyvcT3y2qP1ULOXbLxgbMyOXKFVgbWVjXwQ8ki5 pQlg== X-Gm-Message-State: APjAAAX0jB4tkGJyz+6GkrlIlfcnYJJd2y5kprGOCNjWunxse9KUV9mN zBCH4bJ8Js+9EigRdnWJ9sQ= X-Google-Smtp-Source: APXvYqxKdH78uHYID/CRH/IDiAvVHCQ9nuWeofw4Zl+VK6p4ii6uk6BZO+Mh0KjkBiYLL1KMOie1KA== X-Received: by 2002:a1c:7215:: with SMTP id n21mr177971wmc.154.1581961628247; Mon, 17 Feb 2020 09:47:08 -0800 (PST) Received: from localhost (userh634.uk.uudial.com. [194.69.103.7]) by smtp.gmail.com with ESMTPSA id g17sm2039706wru.13.2020.02.17.09.47.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 09:47:07 -0800 (PST) From: luca.boccassi@gmail.com To: Beilei Xing Cc: Xiaolong Ye , dpdk stable Date: Mon, 17 Feb 2020 17:45:38 +0000 Message-Id: <20200217174546.25334-46-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200217174546.25334-1-luca.boccassi@gmail.com> References: <20200211112216.3929-190-luca.boccassi@gmail.com> <20200217174546.25334-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/i40e: fix unchecked Tx cleanup error' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 85ceba97e41210ba113c414936ced115c8201555 Mon Sep 17 00:00:00 2001 From: Beilei Xing Date: Wed, 12 Feb 2020 20:36:01 +0800 Subject: [PATCH] net/i40e: fix unchecked Tx cleanup error [ upstream commit ba950e62762bd0198e53666ecc2a791767adc137 ] Coverity complains of unchecked return value warning of i40e_xmit_cleanup, while this cleanup is opportunistic and will not cause problems if it fails. So instead of checking the return value of i40e_xmit_cleanup and return in case of cleanup failure, we directly cast it to void function to make the Coverity happy. Coverity issue: 353617 Fixes: 4861cde46116 ("i40e: new poll mode driver") Signed-off-by: Beilei Xing Acked-by: Xiaolong Ye --- drivers/net/i40e/i40e_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index bbdba39b3c..0ae47b807b 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -1039,7 +1039,7 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) /* Check if the descriptor ring needs to be cleaned. */ if (txq->nb_tx_free < txq->tx_free_thresh) - i40e_xmit_cleanup(txq); + (void)i40e_xmit_cleanup(txq); for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) { td_cmd = 0; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-17 17:00:16.594459517 +0000 +++ 0046-net-i40e-fix-unchecked-Tx-cleanup-error.patch 2020-02-17 17:00:15.375951419 +0000 @@ -1,8 +1,10 @@ -From ba950e62762bd0198e53666ecc2a791767adc137 Mon Sep 17 00:00:00 2001 +From 85ceba97e41210ba113c414936ced115c8201555 Mon Sep 17 00:00:00 2001 From: Beilei Xing Date: Wed, 12 Feb 2020 20:36:01 +0800 Subject: [PATCH] net/i40e: fix unchecked Tx cleanup error +[ upstream commit ba950e62762bd0198e53666ecc2a791767adc137 ] + Coverity complains of unchecked return value warning of i40e_xmit_cleanup, while this cleanup is opportunistic and will not cause problems if it fails. So instead of checking the return value of @@ -11,7 +13,6 @@ Coverity issue: 353617 Fixes: 4861cde46116 ("i40e: new poll mode driver") -Cc: stable@dpdk.org Signed-off-by: Beilei Xing Acked-by: Xiaolong Ye @@ -20,7 +21,7 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c -index fd1ae80da8..f6d23c9fb6 100644 +index bbdba39b3c..0ae47b807b 100644 --- a/drivers/net/i40e/i40e_rxtx.c +++ b/drivers/net/i40e/i40e_rxtx.c @@ -1039,7 +1039,7 @@ i40e_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)