From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A253A0553 for ; Mon, 17 Feb 2020 18:46:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0192F1DAB4; Mon, 17 Feb 2020 18:46:01 +0100 (CET) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 666A11DAAE for ; Mon, 17 Feb 2020 18:46:00 +0100 (CET) Received: by mail-wr1-f65.google.com with SMTP id m16so20754522wrx.11 for ; Mon, 17 Feb 2020 09:46:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=kIOTTS+GPY+D/LbKDRF6gdpCf6M01HzY3+hd8z5wP6w=; b=Mv413Ly4sdE4g2xHM4zZnKnneqKJRScU9KvEtuZn9WHl6tIa7B9niKw47icTUmcQap JWfdg3wE61t+A71YFcFgPvdFwYz9Cqz7EpAEqg0/aF5QllyCm33BJTsMUaVAuD0j2fVJ 0Vp/5EV78FrxUsBL4oa3Qm9VG/CjhkKOlCOBLdnwMQ3H96hVRBxNrdLZZhps2wtLanO6 ncrINCqEa+i5V8PRMMpqEcDU92zcfSHxf6krSISirSnDL8wTbPIPuv97JCnwhk6mcE30 p/9j7WHCJp8vKjIYdzcZ1ls4iioHbmGprPg8gnEHqlrUvQw8rZVDohjV3fJdTZRQ2Hhb IrVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=kIOTTS+GPY+D/LbKDRF6gdpCf6M01HzY3+hd8z5wP6w=; b=Hinb8ulOd3BKKr0ruiM0CEeZzNLVBT6KoXYHJps7IWKBCRLPK7d3FdS4rOzfwXuxXD wlDTX3LYoRFf9dfDcObESXP5+c2iwRvss9CSznp+M0w7AceD/8MnsOHi7IYHUV9W4tw1 7K5L9MPTEVDQ+EkaNMoetXcMkwW6ZecoOe/iYDzPqG/fLM9e8RwQRQtryir5bt3yzGlE ge6Q9OInNQa0Ty5E2SqeWZyn5Hs+GxZqIkSGyeS4ZsAmDYaiM2Fb983m+BWaoT1P63Sx 7RPyG4HhnGPTBc0B0aJ4UUEuI3xcJr0Udlww49pYip+6hnT7cOkTJHM6OkNPrefunSPO 5gpw== X-Gm-Message-State: APjAAAVQbxovW4hriigE92ywqLNH5uGYmOWzGmfbfK0kmNoNBVU6tP4i 3aGxeEWakXVWgrfCwju9lUuL+QEgzv0= X-Google-Smtp-Source: APXvYqxBlT2WbVf9DebpaEbGWM4mvsqlDOqkEVWhTTZu+TD9980jHsOFDtAyKrAqrLaU5nGQXKOozQ== X-Received: by 2002:a5d:5752:: with SMTP id q18mr24347110wrw.277.1581961560172; Mon, 17 Feb 2020 09:46:00 -0800 (PST) Received: from localhost (userh634.uk.uudial.com. [194.69.103.7]) by smtp.gmail.com with ESMTPSA id z19sm168502wmi.35.2020.02.17.09.45.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 17 Feb 2020 09:45:59 -0800 (PST) From: luca.boccassi@gmail.com To: David Hunt Cc: Lei Yao , dpdk stable Date: Mon, 17 Feb 2020 17:44:58 +0000 Message-Id: <20200217174546.25334-6-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200217174546.25334-1-luca.boccassi@gmail.com> References: <20200211112216.3929-190-luca.boccassi@gmail.com> <20200217174546.25334-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'examples/power: fix ack for enable/disable turbo' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/19/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 40aaf22e968754c863e9a129fa77578364b16906 Mon Sep 17 00:00:00 2001 From: David Hunt Date: Tue, 11 Feb 2020 10:50:08 +0000 Subject: [PATCH] examples/power: fix ack for enable/disable turbo [ upstream commit 1e3ec03d8ac118eaf5ef76036c0a24c598589add ] When a VM sends a command through virtio-serial to enable/disable turbo, it is successfully enabled or disabled, yet the response to the VM is NACK. This is because all the library frequency change APIs return 1 for success (change in frequency), 0 for success (no change in frequency) and -1 for failure. However the turbo enable/disable APIs just return 0 for success and -1 for failure. Fix the handling of the return code to treat ">= 0" as success, and send an ACK. Only send NACK when < 0 (failure). Fixes: 0de94bcac7fc ("examples/vm_power: send confirmation cmd to guest") Signed-off-by: David Hunt Acked-by: Lei Yao --- examples/vm_power_manager/channel_monitor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/vm_power_manager/channel_monitor.c b/examples/vm_power_manager/channel_monitor.c index 090c2a98b0..1d00a6cf6c 100644 --- a/examples/vm_power_manager/channel_monitor.c +++ b/examples/vm_power_manager/channel_monitor.c @@ -868,7 +868,7 @@ process_request(struct channel_packet *pkt, struct channel_info *chan_info) if (valid_unit) { ret = send_ack_for_received_cmd(pkt, chan_info, - scale_res > 0 ? + scale_res >= 0 ? CPU_POWER_CMD_ACK : CPU_POWER_CMD_NACK); if (ret < 0) -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-17 17:00:15.527336179 +0000 +++ 0006-examples-power-fix-ack-for-enable-disable-turbo.patch 2020-02-17 17:00:15.271949945 +0000 @@ -1,8 +1,10 @@ -From 1e3ec03d8ac118eaf5ef76036c0a24c598589add Mon Sep 17 00:00:00 2001 +From 40aaf22e968754c863e9a129fa77578364b16906 Mon Sep 17 00:00:00 2001 From: David Hunt Date: Tue, 11 Feb 2020 10:50:08 +0000 Subject: [PATCH] examples/power: fix ack for enable/disable turbo +[ upstream commit 1e3ec03d8ac118eaf5ef76036c0a24c598589add ] + When a VM sends a command through virtio-serial to enable/disable turbo, it is successfully enabled or disabled, yet the response to the VM is NACK. This is because all the library frequency change APIs return @@ -14,7 +16,6 @@ send an ACK. Only send NACK when < 0 (failure). Fixes: 0de94bcac7fc ("examples/vm_power: send confirmation cmd to guest") -Cc: stable@dpdk.org Signed-off-by: David Hunt Acked-by: Lei Yao