From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Marvin Liu <yong.liu@intel.com>
Cc: maxime.coquelin@redhat.com, dev@dpdk.org, tiwei.bie@intel.com,
zhihong.wang@intel.com, stable@dpdk.org
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] vhost: fix zmbuf buffer id invalid
Date: Mon, 24 Feb 2020 15:25:31 +0800 [thread overview]
Message-ID: <20200224072531.GA87591@intel.com> (raw)
In-Reply-To: <20200224145025.84899-1-yong.liu@intel.com>
For the subject, what about:
vhost: fix invalid zmbuf buffer id
On 02/24, Marvin Liu wrote:
>zc mbufs should record available buffer id when doing dequeue zcopy.
>There's no guarantee that local queue avail index equal to buffer index.
s/equal to/is equal to
>
>Fixes: d1eafb532268 ("vhost: add packed ring zcopy batch and single dequeue")
>Cc: stable@dpdk.org
>
>Signed-off-by: Marvin Liu <yong.liu@intel.com>
>Reported-by: Yinan Wang <yinan.wang@intel.com>
>
>diff --git a/lib/librte_vhost/virtio_net.c b/lib/librte_vhost/virtio_net.c
>index 37c47c7dc..210415904 100644
>--- a/lib/librte_vhost/virtio_net.c
>+++ b/lib/librte_vhost/virtio_net.c
>@@ -2004,7 +2004,7 @@ virtio_dev_tx_batch_packed_zmbuf(struct virtio_net *dev,
>
> vhost_for_each_try_unroll(i, 0, PACKED_BATCH_SIZE) {
> zmbufs[i]->mbuf = pkts[i];
>- zmbufs[i]->desc_idx = avail_idx + i;
>+ zmbufs[i]->desc_idx = ids[i];
> zmbufs[i]->desc_count = 1;
> }
>
>@@ -2045,7 +2045,7 @@ virtio_dev_tx_single_packed_zmbuf(struct virtio_net *dev,
> return -1;
> }
> zmbuf->mbuf = *pkts;
>- zmbuf->desc_idx = vq->last_avail_idx;
>+ zmbuf->desc_idx = buf_id;
> zmbuf->desc_count = desc_count;
>
> rte_mbuf_refcnt_update(*pkts, 1);
>--
>2.17.1
>
Apart from above,
Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>
next prev parent reply other threads:[~2020-02-24 7:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 14:50 [dpdk-stable] " Marvin Liu
2020-02-24 7:25 ` Ye Xiaolong [this message]
2020-02-24 7:39 ` [dpdk-stable] [dpdk-dev] " Liu, Yong
2020-02-24 7:27 ` [dpdk-stable] " Maxime Coquelin
2020-02-24 15:14 ` [dpdk-stable] [PATCH v2] vhost: fix packed ring zero-copy Marvin Liu
2020-02-24 8:28 ` Maxime Coquelin
2020-02-24 10:32 ` David Marchand
2020-02-24 11:14 ` Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200224072531.GA87591@intel.com \
--to=xiaolong.ye@intel.com \
--cc=dev@dpdk.org \
--cc=maxime.coquelin@redhat.com \
--cc=stable@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=yong.liu@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).