From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 00D22A055A for ; Thu, 27 Feb 2020 10:35:01 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EC1891C01; Thu, 27 Feb 2020 10:35:00 +0100 (CET) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id B0A4D1C01 for ; Thu, 27 Feb 2020 10:34:59 +0100 (CET) Received: by mail-wr1-f67.google.com with SMTP id m16so2373243wrx.11 for ; Thu, 27 Feb 2020 01:34:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9w/NtUla9RoLjYyrx+NJl5I0rx0cLW4lZ65T5V6GcCk=; b=IOurWkEWL97Ww5TXgZBAERUfTTLAOIxkxvWf7YHfK8SHdPeg4+T526D4Rp9liu0a1/ 6J/lXxOaZQlPT2Pjw2ErvTWf6Fd4iG9oMOdTxL/pgeF0kvOiKgIin49R4i7Mk/M99PO0 RvL31ZYbe4CVs9KU32L0Kk1fZc1sKXeRJ57laAxEjKAkdcCony+ujass4OMwVybPZqUe Z/NuaMvf7SYCAoWdKRWfQXvTXXJjVCRdXfAbGvM1OR6n+1YEcBf2VdXQlvRJY4923mxZ l5hCL7uo3NXnxZARLX3uiHAtgP8yCafGI9lsuttN4mgSC9XCCZQ2baiACetWa//5T5nw 35sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9w/NtUla9RoLjYyrx+NJl5I0rx0cLW4lZ65T5V6GcCk=; b=YHEPgj55bPYKmJbTTR+pjT92Nor6L9GogfDEP56/e1FYIth699MMWu7a+8d/DUcQwk +u2ulITXw1MJ5sdTcA4/23ME8y9GAZCqJA930+7yCbK7/dYBgrnj/T4sjGCiEz5BXBra 8rqpx2wgauoP2ytYc0/2Wn4BxGvaOjDW+Bo/tP8l18WKIKPWLiYaOeqLlyGY5avRBnoy mYTX1M1epSLaeVYkOJ4D2xdZV04TeAJzn7Vo11e7u3xhIHOxg5ptmmfNCDqPrT0Ss58D zrhJzUswIB393Nn9XNAONuYrJJ+iuQ8Nfe1uX+w0o1VHX29RSkAw/89m4KluzHgxjWs2 vPMg== X-Gm-Message-State: APjAAAX+aeA/TN1oFs6Y14KBA5S4giyYvvxYtAg0ghEt/nziOVFhC1Ih NYX7ghuORHk8zf97Hz2xPO8= X-Google-Smtp-Source: APXvYqxW65wpx6FwTit7hknaJ7esSOtLes8nSrHBr2JXYI7Zh+ufjf3xwVk6rY1bL4Hw0jfvDKWy9A== X-Received: by 2002:adf:e506:: with SMTP id j6mr3705904wrm.309.1582796099469; Thu, 27 Feb 2020 01:34:59 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id p26sm6617364wmc.24.2020.02.27.01.34.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 01:34:58 -0800 (PST) From: luca.boccassi@gmail.com To: Matan Azrad Cc: Viacheslav Ovsiienko , dpdk stable Date: Thu, 27 Feb 2020 09:33:37 +0000 Message-Id: <20200227093402.17690-17-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200227093402.17690-1-luca.boccassi@gmail.com> References: <20200217174546.25334-54-luca.boccassi@gmail.com> <20200227093402.17690-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/mlx5: fix GENEVE tunnel flow validation' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/29/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From bd75bec91e91ff32d9f4fcecfcb0823c9562b780 Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Wed, 19 Feb 2020 06:52:11 +0000 Subject: [PATCH] net/mlx5: fix GENEVE tunnel flow validation [ upstream commit 5693233823b09b527376e94ce24df71918632dfa ] The new Mellanox devices support GENEVE tunnel stateless offloads by native HW parsers, FW doesn't need to configure flex parser to support it. The FW capability for GENEVE flex parser is not set for the above devices, hence the GENEVE flow validation failed for them. Remove the flex parser validation for GENEVE, stay only with the direct FW capability for GENEVE support. Fixes: e59a5dbcfd07 ("net/mlx5: add flow match on GENEVE item") Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 07979a09cb..b2ab5491ce 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -2131,9 +2131,7 @@ mlx5_flow_validate_item_geneve(const struct rte_flow_item *item, .protocol = RTE_BE16(UINT16_MAX), }; - if (!(priv->config.hca_attr.flex_parser_protocols & - MLX5_HCA_FLEX_GENEVE_ENABLED) || - !priv->config.hca_attr.tunnel_stateless_geneve_rx) + if (!priv->config.hca_attr.tunnel_stateless_geneve_rx) return rte_flow_error_set(error, ENOTSUP, RTE_FLOW_ERROR_TYPE_ITEM, item, "L3 Geneve is not enabled by device" -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-27 09:31:56.393497810 +0000 +++ 0017-net-mlx5-fix-GENEVE-tunnel-flow-validation.patch 2020-02-27 09:31:55.727945815 +0000 @@ -1,8 +1,10 @@ -From 5693233823b09b527376e94ce24df71918632dfa Mon Sep 17 00:00:00 2001 +From bd75bec91e91ff32d9f4fcecfcb0823c9562b780 Mon Sep 17 00:00:00 2001 From: Matan Azrad Date: Wed, 19 Feb 2020 06:52:11 +0000 Subject: [PATCH] net/mlx5: fix GENEVE tunnel flow validation +[ upstream commit 5693233823b09b527376e94ce24df71918632dfa ] + The new Mellanox devices support GENEVE tunnel stateless offloads by native HW parsers, FW doesn't need to configure flex parser to support it. @@ -14,7 +16,6 @@ FW capability for GENEVE support. Fixes: e59a5dbcfd07 ("net/mlx5: add flow match on GENEVE item") -Cc: stable@dpdk.org Signed-off-by: Matan Azrad Acked-by: Viacheslav Ovsiienko @@ -23,10 +24,10 @@ 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c -index 25482010d8..eb6bd274e5 100644 +index 07979a09cb..b2ab5491ce 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c -@@ -2135,9 +2135,7 @@ mlx5_flow_validate_item_geneve(const struct rte_flow_item *item, +@@ -2131,9 +2131,7 @@ mlx5_flow_validate_item_geneve(const struct rte_flow_item *item, .protocol = RTE_BE16(UINT16_MAX), };