From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B50C9A055A for ; Thu, 27 Feb 2020 10:35:21 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AC6C41C01; Thu, 27 Feb 2020 10:35:21 +0100 (CET) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id C49191BFED for ; Thu, 27 Feb 2020 10:35:20 +0100 (CET) Received: by mail-wm1-f66.google.com with SMTP id z12so2660019wmi.4 for ; Thu, 27 Feb 2020 01:35:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=CZhyaIN9QFvronZx305PHyjKsZphrpUM12pWQIxjDq4=; b=qCPTPmW51Mc67gTvvH0y+YikcKbJ24Xp8beC/o1JQARN/6zvwZOn0JHWxSeMlJWbeh 2Bv3Z3JYXKL2JlFV0UWjHIek7K3ELK9I3IPjZvvil7Iha/8/Zahm86loa3oHN+4tiaRB a352JYH7ulsADI17jDuIZ4LvAAsd66gJdEwzUhZvZPAthyJ9gKXsZVKsnprEQRCa+uGs itBP/7PBToW45HatThn8MV8/KTmCvtExgc9cUPX+3mQA+Ahz46uxLIN1ZjcXyT+N5zh6 WDG0MnPRjhGea9xXaoZhCCtKt0IWl0RVY6XNxhcVwbUzrxMgEC1f8eIVKt5K03QRr/7p EMZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=CZhyaIN9QFvronZx305PHyjKsZphrpUM12pWQIxjDq4=; b=aDnM0jdId9TWpSUVIxkeay9skWDsI4yjJ6bxf0oVLXlLutoEdbqj3AMyz4FbhgcQya tAGcXCcWlIScyG45N4Fs5YFBgJpjix4CBTovVc0tzPVm8jVTNyrmagRwhZmZ9za//Pol vGlPEdTUgJTlbN7t8xN2kSpMbH/vOZV6PxSePUCp9KpV8yKiUka/tF8RrTagT6tfijEy WRKCaw5I29drK2jfMem4V7n+F57E1zRzuCykK4LMV0JYMMvzqEVnZLxkKEgkxm+vrYqY zulUHv0u1XoCUm/R8066J7UbHQtbxEMxR6LDY+UYdBIdaDcXbzJZQU4Uc5hxEPvixlck uBAg== X-Gm-Message-State: APjAAAX6bVd+f0lMJ9qpLlg6ZK9UTMaQXoR+4HBX2d5efVlx8r0q5lJD FfU2HrdjBEvsAtTXAip9B/dfLydwXP4= X-Google-Smtp-Source: APXvYqxZiNzzy5pr0y9V8bkCYmzvK/RRPkS6y4q9PF5/zYRNKG1TnGiH89I7GKC2Kh3fPm8uzrap8g== X-Received: by 2002:a1c:7512:: with SMTP id o18mr4191763wmc.110.1582796120532; Thu, 27 Feb 2020 01:35:20 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 133sm7163931wme.32.2020.02.27.01.35.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 01:35:20 -0800 (PST) From: luca.boccassi@gmail.com To: Wisam Jaddo Cc: Bernard Iremonger , dpdk stable Date: Thu, 27 Feb 2020 09:33:47 +0000 Message-Id: <20200227093402.17690-27-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200227093402.17690-1-luca.boccassi@gmail.com> References: <20200217174546.25334-54-luca.boccassi@gmail.com> <20200227093402.17690-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/testpmd: fix identifier size for port attach' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/29/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From e09cfe4dfedf417770c52776b990f32b7af3c4ab Mon Sep 17 00:00:00 2001 From: Wisam Jaddo Date: Wed, 19 Feb 2020 18:47:30 +0200 Subject: [PATCH] app/testpmd: fix identifier size for port attach [ upstream commit f1cfa5687f2c7641e89cba60d1c2fb774e591cc7 ] Identifier for new port may contain white list options, and white list options will not fit into 128 from STR_TOKEN_SIZE, instead having 4096 char from STR_MULTI_TOKEN_SIZE will provide better and more options Fixes: edab33b1c01d ("app/testpmd: support port hotplug") Signed-off-by: Wisam Jaddo Acked-by: Bernard Iremonger --- app/test-pmd/cmdline.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index f287deaf7c..f01cf31f70 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -1437,7 +1437,7 @@ cmdline_parse_inst_t cmd_set_port_setup_on = { struct cmd_operate_attach_port_result { cmdline_fixed_string_t port; cmdline_fixed_string_t keyword; - cmdline_fixed_string_t identifier; + cmdline_multi_string_t identifier; }; static void cmd_operate_attach_port_parsed(void *parsed_result, @@ -1460,7 +1460,7 @@ cmdline_parse_token_string_t cmd_operate_attach_port_keyword = keyword, "attach"); cmdline_parse_token_string_t cmd_operate_attach_port_identifier = TOKEN_STRING_INITIALIZER(struct cmd_operate_attach_port_result, - identifier, NULL); + identifier, TOKEN_STRING_MULTI); cmdline_parse_inst_t cmd_operate_attach_port = { .f = cmd_operate_attach_port_parsed, -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-27 09:31:56.685649100 +0000 +++ 0027-app-testpmd-fix-identifier-size-for-port-attach.patch 2020-02-27 09:31:55.775946166 +0000 @@ -1,15 +1,16 @@ -From f1cfa5687f2c7641e89cba60d1c2fb774e591cc7 Mon Sep 17 00:00:00 2001 +From e09cfe4dfedf417770c52776b990f32b7af3c4ab Mon Sep 17 00:00:00 2001 From: Wisam Jaddo Date: Wed, 19 Feb 2020 18:47:30 +0200 Subject: [PATCH] app/testpmd: fix identifier size for port attach +[ upstream commit f1cfa5687f2c7641e89cba60d1c2fb774e591cc7 ] + Identifier for new port may contain white list options, and white list options will not fit into 128 from STR_TOKEN_SIZE, instead having 4096 char from STR_MULTI_TOKEN_SIZE will provide better and more options Fixes: edab33b1c01d ("app/testpmd: support port hotplug") -Cc: stable@dpdk.org Signed-off-by: Wisam Jaddo Acked-by: Bernard Iremonger @@ -18,10 +19,10 @@ 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c -index 38b6d804c6..a037a55c6a 100644 +index f287deaf7c..f01cf31f70 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c -@@ -1446,7 +1446,7 @@ cmdline_parse_inst_t cmd_set_port_setup_on = { +@@ -1437,7 +1437,7 @@ cmdline_parse_inst_t cmd_set_port_setup_on = { struct cmd_operate_attach_port_result { cmdline_fixed_string_t port; cmdline_fixed_string_t keyword; @@ -30,7 +31,7 @@ }; static void cmd_operate_attach_port_parsed(void *parsed_result, -@@ -1469,7 +1469,7 @@ cmdline_parse_token_string_t cmd_operate_attach_port_keyword = +@@ -1460,7 +1460,7 @@ cmdline_parse_token_string_t cmd_operate_attach_port_keyword = keyword, "attach"); cmdline_parse_token_string_t cmd_operate_attach_port_identifier = TOKEN_STRING_INITIALIZER(struct cmd_operate_attach_port_result,