From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE6E3A055A for ; Thu, 27 Feb 2020 10:34:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DE29A1BFA9; Thu, 27 Feb 2020 10:34:23 +0100 (CET) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 9EF311BFA9 for ; Thu, 27 Feb 2020 10:34:22 +0100 (CET) Received: by mail-wr1-f68.google.com with SMTP id z15so2447237wrl.1 for ; Thu, 27 Feb 2020 01:34:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=8FRFsyazJSKY9Tu5sJhlRTa8kqX5olaDn3UgHhZBJIE=; b=DysOAgeTrFlXgj4ejmUfdTpmW1uzF0DT4heTqNcdJ8ZjE3QNxThu+kb0PXCWT5fZEi EuOAsLdithw88kn2c0u2M6hB6c3f0dXOVwlkvJKbuHAFdOWECY0u0keuuGlEdv87P8s7 c2bq1K4J+fABHio+4ZOrboRze7wKDx+JjsPybxFhtl1p3XAFI6RhsDyL4V1jgLoY47Z0 D0aZdvPvNVwOhmPbVpJTxvHnObBPk62lKv2UCGRVhoKLC0G/DTg/WcV5njtGMFoAZ5HY RqFvVMsZ8/8H5kuUEvqa2AIR2Wmyc71uzQRaLsX2cgKV6XiyYnRsvi/HvtkWF5GvWNPw DSog== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=8FRFsyazJSKY9Tu5sJhlRTa8kqX5olaDn3UgHhZBJIE=; b=JhwFO7+NZfsfsNfg9zDFwECGHFmKeVW4llRFsmYYeb/2fOP3LfjEFQB55AgJRToevr 0s7CKj3NR40YcQX1MLxxaj1AK3h1+LSMJifrMOu8OjHRee2AGMvjSVwRlYV0PYZKmKlE e7qnJ5FE6n7eKy+SGV6caHsKKTkOFLmzYJ3M3oycE099l2j74mUlRV/zCr4/AKyJLBjC K1Ywmkq2NrZufQsGo6iG+EDxMTlmJQTv/rmQy1Wfk9zkX9WxlTaNjUapJ85zbE1KTcJA L5qQsJQvKnkOsFygG7GWCPnkc140lNf8KRPU92bIlXyli5lW9IlmLN/fUtiYe0R1Kg7B KpKA== X-Gm-Message-State: APjAAAUUD4XxGTiGLx+9XKjI8j/B2PsqCfToQoQwpSHXE0QYpsaml8Gg GIzSn611OMtLfhDJl7AlxMo1xH5X X-Google-Smtp-Source: APXvYqyZDkcRmz6NyRe1yl/eSMTVSkkDqdO27uw8mjSGk6UfXhZfLtKVmtpxuVxn94PJ/UqEnkt1wg== X-Received: by 2002:adf:fd91:: with SMTP id d17mr4108423wrr.340.1582796062378; Thu, 27 Feb 2020 01:34:22 -0800 (PST) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id q3sm6730300wrs.1.2020.02.27.01.34.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 27 Feb 2020 01:34:21 -0800 (PST) From: luca.boccassi@gmail.com To: Manish Chopra Cc: Rasesh Mody , dpdk stable Date: Thu, 27 Feb 2020 09:33:26 +0000 Message-Id: <20200227093402.17690-6-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200227093402.17690-1-luca.boccassi@gmail.com> References: <20200217174546.25334-54-luca.boccassi@gmail.com> <20200227093402.17690-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/qede: do not stop vport if not started' has been queued to stable release 19.11.1 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.1 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 02/29/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 7453074ee57c72795ce2cc70268181631c8714d0 Mon Sep 17 00:00:00 2001 From: Manish Chopra Date: Thu, 6 Feb 2020 12:01:46 -0800 Subject: [PATCH] net/qede: do not stop vport if not started [ upstream commit bf44e27af5a4840b2965c71a89eccfc01b5c58bf ] Stopping an already disabled vport leads to firmware assert. Stop the vport only if it was started. Fixes: 2ea6f76aff40 ("qede: add core driver") Signed-off-by: Manish Chopra Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 19d2e96191..e01d437f19 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1472,7 +1472,8 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev) if (eth_dev->data->dev_started) qede_dev_stop(eth_dev); - qede_stop_vport(edev); + if (qdev->vport_started) + qede_stop_vport(edev); qdev->vport_started = false; qede_fdir_dealloc_resc(eth_dev); qede_dealloc_fp_resc(eth_dev); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-02-27 09:31:56.051999658 +0000 +++ 0006-net-qede-do-not-stop-vport-if-not-started.patch 2020-02-27 09:31:55.663945346 +0000 @@ -1,13 +1,14 @@ -From bf44e27af5a4840b2965c71a89eccfc01b5c58bf Mon Sep 17 00:00:00 2001 +From 7453074ee57c72795ce2cc70268181631c8714d0 Mon Sep 17 00:00:00 2001 From: Manish Chopra Date: Thu, 6 Feb 2020 12:01:46 -0800 Subject: [PATCH] net/qede: do not stop vport if not started +[ upstream commit bf44e27af5a4840b2965c71a89eccfc01b5c58bf ] + Stopping an already disabled vport leads to firmware assert. Stop the vport only if it was started. Fixes: 2ea6f76aff40 ("qede: add core driver") -Cc: stable@dpdk.org Signed-off-by: Manish Chopra Signed-off-by: Rasesh Mody @@ -16,10 +17,10 @@ 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c -index 500440c2ca..74dfe895ad 100644 +index 19d2e96191..e01d437f19 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c -@@ -1509,7 +1509,8 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev) +@@ -1472,7 +1472,8 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev) if (eth_dev->data->dev_started) qede_dev_stop(eth_dev);