patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] pci: fix missing off_t define on FreeBSD
@ 2020-03-16 16:37 Bruce Richardson
  2020-03-17  9:24 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon
  0 siblings, 1 reply; 2+ messages in thread
From: Bruce Richardson @ 2020-03-16 16:37 UTC (permalink / raw)
  To: dev; +Cc: thomas, Bruce Richardson, stable

When removing the extra headers from rte_pci.h stdlib should have been
removed instead of stdio, since off_t is missing for BSD builds when just
including stdlib.h

Fixes: 0dcba5256287 ("pci: remove unneeded includes in public header file")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/librte_pci/rte_pci.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_pci/rte_pci.h b/lib/librte_pci/rte_pci.h
index c591af010..4087771c1 100644
--- a/lib/librte_pci/rte_pci.h
+++ b/lib/librte_pci/rte_pci.h
@@ -16,7 +16,7 @@
 extern "C" {
 #endif
 
-#include <stdlib.h>
+#include <stdio.h>
 #include <limits.h>
 #include <sys/queue.h>
 #include <inttypes.h>
-- 
2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] pci: fix missing off_t define on FreeBSD
  2020-03-16 16:37 [dpdk-stable] [PATCH] pci: fix missing off_t define on FreeBSD Bruce Richardson
@ 2020-03-17  9:24 ` " Thomas Monjalon
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2020-03-17  9:24 UTC (permalink / raw)
  To: Bruce Richardson; +Cc: dev, stable, david.marchand

16/03/2020 17:37, Bruce Richardson:
> When removing the extra headers from rte_pci.h stdlib should have been
> removed instead of stdio, since off_t is missing for BSD builds when just
> including stdlib.h
> 
> Fixes: 0dcba5256287 ("pci: remove unneeded includes in public header file")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

Sorry, I missed the failure seen in the community lab:
	http://mails.dpdk.org/archives/test-report/2020-March/120862.html
Note: we should always wait for tests to be run.
Thank you for the quick fix.

Applied, thanks



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-16 16:37 [dpdk-stable] [PATCH] pci: fix missing off_t define on FreeBSD Bruce Richardson
2020-03-17  9:24 ` [dpdk-stable] [dpdk-dev] " Thomas Monjalon

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox