patches for DPDK stable branches
 help / color / mirror / Atom feed
* [dpdk-stable] [PATCH] mempool: remove inline functions from export list
@ 2020-04-22  7:37 Fady Bader
  2020-04-23 12:53 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
  0 siblings, 1 reply; 4+ messages in thread
From: Fady Bader @ 2020-04-22  7:37 UTC (permalink / raw)
  To: dev; +Cc: thomas, olivier.matz, arybchenko, stable

The code didn't compile when using exported mempool functions under windows.

compilation error logs:
rte_mempool_exports.def : error LNK2001:
unresolved external symbol rte_mempool_cache_flush
rte_mempool_exports.def : error LNK2001:
unresolved external symbol rte_mempool_default_cache
rte_mempool_exports.def : error LNK2001:
unresolved external symbol rte_mempool_generic_get
rte_mempool_exports.def : error LNK2001:
unresolved external symbol rte_mempool_generic_put
lib\librte_mempool.dll.a : fatal error LNK1120: 4 unresolved externals
clang: error: linker command failed with exit code 1120 (use -v to see invocation)
[77/77] Linking target drivers/librte_bus_pci-0.200.2.dll.
ninja: build stopped: subcommand failed.

The cause was that there were some inline functions that were included
in the export list.
To solve this the functions were removed from rte_mempool_version.map
export list which are implemented in the header and shouldn't be exported.

Fixes: 4b5062755aa74517ed1d7bd ("mempool: allow user-owned cache")
Fixes: 656f2d3ede96902202a1a5f ("mempool: deprecate specific get and put functions")
Cc: stable@dpdk.org

Signed-off-by: Fady Bader <fady@mellanox.com>
---
 lib/librte_mempool/rte_mempool_version.map | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map
index d002dfc46..d67ed2e2b 100644
--- a/lib/librte_mempool/rte_mempool_version.map
+++ b/lib/librte_mempool/rte_mempool_version.map
@@ -4,18 +4,14 @@ DPDK_20.0 {
 	rte_mempool_audit;
 	rte_mempool_avail_count;
 	rte_mempool_cache_create;
-	rte_mempool_cache_flush;
 	rte_mempool_cache_free;
 	rte_mempool_calc_obj_size;
 	rte_mempool_check_cookies;
 	rte_mempool_contig_blocks_check_cookies;
 	rte_mempool_create;
 	rte_mempool_create_empty;
-	rte_mempool_default_cache;
 	rte_mempool_dump;
 	rte_mempool_free;
-	rte_mempool_generic_get;
-	rte_mempool_generic_put;
 	rte_mempool_in_use_count;
 	rte_mempool_list_dump;
 	rte_mempool_lookup;
-- 
2.16.1.windows.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] mempool: remove inline functions from export list
  2020-04-22  7:37 [dpdk-stable] [PATCH] mempool: remove inline functions from export list Fady Bader
@ 2020-04-23 12:53 ` Andrew Rybchenko
  2020-04-24 16:13   ` Thomas Monjalon
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Rybchenko @ 2020-04-23 12:53 UTC (permalink / raw)
  To: Fady Bader, dev; +Cc: thomas, olivier.matz, stable

On 4/22/20 10:37 AM, Fady Bader wrote:
> The code didn't compile when using exported mempool functions under windows.
> 
> compilation error logs:
> rte_mempool_exports.def : error LNK2001:
> unresolved external symbol rte_mempool_cache_flush
> rte_mempool_exports.def : error LNK2001:
> unresolved external symbol rte_mempool_default_cache
> rte_mempool_exports.def : error LNK2001:
> unresolved external symbol rte_mempool_generic_get
> rte_mempool_exports.def : error LNK2001:
> unresolved external symbol rte_mempool_generic_put
> lib\librte_mempool.dll.a : fatal error LNK1120: 4 unresolved externals
> clang: error: linker command failed with exit code 1120 (use -v to see invocation)
> [77/77] Linking target drivers/librte_bus_pci-0.200.2.dll.
> ninja: build stopped: subcommand failed.
> 
> The cause was that there were some inline functions that were included
> in the export list.
> To solve this the functions were removed from rte_mempool_version.map
> export list which are implemented in the header and shouldn't be exported.
> 
> Fixes: 4b5062755aa74517ed1d7bd ("mempool: allow user-owned cache")
> Fixes: 656f2d3ede96902202a1a5f ("mempool: deprecate specific get and put functions")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Fady Bader <fady@mellanox.com>

Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] mempool: remove inline functions from export list
  2020-04-23 12:53 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
@ 2020-04-24 16:13   ` Thomas Monjalon
  0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2020-04-24 16:13 UTC (permalink / raw)
  To: Fady Bader; +Cc: dev, stable, olivier.matz, Andrew Rybchenko

23/04/2020 14:53, Andrew Rybchenko:
> On 4/22/20 10:37 AM, Fady Bader wrote:
> > The code didn't compile when using exported mempool functions under windows.
> > 
> > compilation error logs:
> > rte_mempool_exports.def : error LNK2001:
> > unresolved external symbol rte_mempool_cache_flush
> > rte_mempool_exports.def : error LNK2001:
> > unresolved external symbol rte_mempool_default_cache
> > rte_mempool_exports.def : error LNK2001:
> > unresolved external symbol rte_mempool_generic_get
> > rte_mempool_exports.def : error LNK2001:
> > unresolved external symbol rte_mempool_generic_put
> > lib\librte_mempool.dll.a : fatal error LNK1120: 4 unresolved externals
> > clang: error: linker command failed with exit code 1120 (use -v to see invocation)
> > [77/77] Linking target drivers/librte_bus_pci-0.200.2.dll.
> > ninja: build stopped: subcommand failed.
> > 
> > The cause was that there were some inline functions that were included
> > in the export list.
> > To solve this the functions were removed from rte_mempool_version.map
> > export list which are implemented in the header and shouldn't be exported.
> > 
> > Fixes: 4b5062755aa74517ed1d7bd ("mempool: allow user-owned cache")
> > Fixes: 656f2d3ede96902202a1a5f ("mempool: deprecate specific get and put functions")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Fady Bader <fady@mellanox.com>
> 
> Acked-by: Andrew Rybchenko <arybchenko@solarflare.com>

Applied, thanks




^ permalink raw reply	[flat|nested] 4+ messages in thread

* [dpdk-stable] [PATCH] mempool: remove inline functions from export list
@ 2020-04-16 12:53 Fady Bader
  0 siblings, 0 replies; 4+ messages in thread
From: Fady Bader @ 2020-04-16 12:53 UTC (permalink / raw)
  To: thomas; +Cc: fady, stable

From: fady <fady@mellanox.com>

The code didn't compile when using exported mempool functions.

compilation error logs:
rte_mempool_exports.def : error LNK2001: unresolved external symbol rte_mempool_cache_flush
rte_mempool_exports.def : error LNK2001: unresolved external symbol rte_mempool_default_cache
rte_mempool_exports.def : error LNK2001: unresolved external symbol rte_mempool_generic_get
rte_mempool_exports.def : error LNK2001: unresolved external symbol rte_mempool_generic_put
lib\librte_mempool.dll.a : fatal error LNK1120: 4 unresolved externals
clang: error: linker command failed with exit code 1120 (use -v to see invocation)
[77/77] Linking target drivers/librte_bus_pci-0.200.2.dll.
ninja: build stopped: subcommand failed.

The cause was that there were some inline functions that were included in the export list.
To solve this I removed the 4 functions from rte_mempool_version.map export list which are implemented in the header and shouldn't be exported.

Fixes: inline functions export list
Cc: stable@dpdk.org

Signed-off-by: Fady Bader <fady@mellanox.com>
---
 lib/librte_mempool/rte_mempool_version.map | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/lib/librte_mempool/rte_mempool_version.map b/lib/librte_mempool/rte_mempool_version.map
index d002dfc46..d67ed2e2b 100644
--- a/lib/librte_mempool/rte_mempool_version.map
+++ b/lib/librte_mempool/rte_mempool_version.map
@@ -4,18 +4,14 @@ DPDK_20.0 {
 	rte_mempool_audit;
 	rte_mempool_avail_count;
 	rte_mempool_cache_create;
-	rte_mempool_cache_flush;
 	rte_mempool_cache_free;
 	rte_mempool_calc_obj_size;
 	rte_mempool_check_cookies;
 	rte_mempool_contig_blocks_check_cookies;
 	rte_mempool_create;
 	rte_mempool_create_empty;
-	rte_mempool_default_cache;
 	rte_mempool_dump;
 	rte_mempool_free;
-	rte_mempool_generic_get;
-	rte_mempool_generic_put;
 	rte_mempool_in_use_count;
 	rte_mempool_list_dump;
 	rte_mempool_lookup;
-- 
2.16.1.windows.4


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2020-04-24 16:13 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-22  7:37 [dpdk-stable] [PATCH] mempool: remove inline functions from export list Fady Bader
2020-04-23 12:53 ` [dpdk-stable] [dpdk-dev] " Andrew Rybchenko
2020-04-24 16:13   ` Thomas Monjalon
  -- strict thread matches above, loose matches on Subject: below --
2020-04-16 12:53 [dpdk-stable] " Fady Bader

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).