The register autoneg can't be updated synchronously with flow control mode setting in the state of port start , so NIC statistics error occurs. The patch fixes the issue. Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting") Cc: stable@dpdk.org Signed-off-by: Guinan Sun <guinanx.sun@intel.com> --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index cf5f1fe70..e6c747aef 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, struct ixgbe_hw *hw) int err; uint32_t mflcn; + hw->mac.ops.setup_fc(hw); + err = ixgbe_fc_enable(hw); /* Not negotiated is not an error case */ -- 2.17.1
Tested-by: Jiang, YuX <yux.jiang@intel.com> -----Original Message----- From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Guinan Sun Sent: Friday, May 8, 2020 4:30 PM To: dev@dpdk.org Cc: Sun, GuinanX <guinanx.sun@intel.com>; stable@dpdk.org Subject: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode The register autoneg can't be updated synchronously with flow control mode setting in the state of port start , so NIC statistics error occurs. The patch fixes the issue. Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting") Cc: stable@dpdk.org Signed-off-by: Guinan Sun <guinanx.sun@intel.com> --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index cf5f1fe70..e6c747aef 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, struct ixgbe_hw *hw) int err; uint32_t mflcn; + hw->mac.ops.setup_fc(hw); + err = ixgbe_fc_enable(hw); /* Not negotiated is not an error case */ -- 2.17.1
Hi, Guinan > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Guinan Sun > Sent: Friday, May 8, 2020 4:30 PM > To: dev@dpdk.org > Cc: Sun, GuinanX <guinanx.sun@intel.com>; stable@dpdk.org > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control mode > > The register autoneg can't be updated synchronously with flow control mode > setting in the state of port start , so NIC statistics error occurs. The patch fixes > the issue. > > Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting") > Cc: stable@dpdk.org > > Signed-off-by: Guinan Sun <guinanx.sun@intel.com> > --- > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > b/drivers/net/ixgbe/ixgbe_ethdev.c > index cf5f1fe70..e6c747aef 100644 > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, > struct ixgbe_hw *hw) > int err; > uint32_t mflcn; > > + hw->mac.ops.setup_fc(hw); 1. please use base code API ixgbe_setup_fc(), do not use internal function directly. 2. please more info for this patch, what register error you want to fix, and why it can fix. > + > err = ixgbe_fc_enable(hw); > > /* Not negotiated is not an error case */ > -- > 2.17.1
The register autoneg can't be updated synchronously with flow control mode setting in the state of port start , so NIC statistics error occurs. AUTO_NEG Advt register should be updated by ixgbe_setup_fc() when enabling flow control. The patch fixes the issue. Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting") Cc: stable@dpdk.org Signed-off-by: Guinan Sun <guinanx.sun@intel.com> --- v2 changes: * Replaced mac.ops.setup_fc() with ixgbe_setup_fc() * Modified commit message. --- drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index a4e5c539d..f8a84c565 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, struct ixgbe_hw *hw) int err; uint32_t mflcn; + ixgbe_setup_fc(hw); + err = ixgbe_fc_enable(hw); /* Not negotiated is not an error case */ -- 2.17.1
Hi zhaowei > -----Original Message----- > From: Zhao1, Wei > Sent: Monday, May 11, 2020 9:03 AM > To: Sun, GuinanX <guinanx.sun@intel.com>; dev@dpdk.org > Cc: Sun, GuinanX <guinanx.sun@intel.com>; stable@dpdk.org; Guo, Jia > <jia.guo@intel.com> > Subject: RE: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow control > mode > > > Hi, Guinan > > > -----Original Message----- > > From: dev <dev-bounces@dpdk.org> On Behalf Of Guinan Sun > > Sent: Friday, May 8, 2020 4:30 PM > > To: dev@dpdk.org > > Cc: Sun, GuinanX <guinanx.sun@intel.com>; stable@dpdk.org > > Subject: [dpdk-dev] [PATCH] net/ixgbe: fix statistics error in flow > > control mode > > > > The register autoneg can't be updated synchronously with flow control > > mode setting in the state of port start , so NIC statistics error > > occurs. The patch fixes the issue. > > > > Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting") > > Cc: stable@dpdk.org > > > > Signed-off-by: Guinan Sun <guinanx.sun@intel.com> > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c > > b/drivers/net/ixgbe/ixgbe_ethdev.c > > index cf5f1fe70..e6c747aef 100644 > > --- a/drivers/net/ixgbe/ixgbe_ethdev.c > > +++ b/drivers/net/ixgbe/ixgbe_ethdev.c > > @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, > > struct ixgbe_hw *hw) int err; uint32_t mflcn; > > > > +hw->mac.ops.setup_fc(hw); > > 1. please use base code API ixgbe_setup_fc(), do not use internal function > directly. > 2. please more info for this patch, what register error you want to fix, and why it > can fix. V2 patch will be send to resolve the problems. > > > > + > > err = ixgbe_fc_enable(hw); > > > > /* Not negotiated is not an error case */ > > -- > > 2.17.1 >
Reviewed-by: Wei Zhao <wei.zhao1@intel.com>
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Guinan Sun
> Sent: Tuesday, May 12, 2020 4:13 PM
> To: dev@dpdk.org
> Cc: Sun, GuinanX <guinanx.sun@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] net/ixgbe: fix statistics error in flow control
> mode
>
> The register autoneg can't be updated synchronously with flow control mode
> setting in the state of port start , so NIC statistics error occurs. AUTO_NEG
> Advt register should be updated by ixgbe_setup_fc() when enabling flow
> control.
> The patch fixes the issue.
>
> Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
> Cc: stable@dpdk.org
>
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> ---
> v2 changes:
> * Replaced mac.ops.setup_fc() with ixgbe_setup_fc()
> * Modified commit message.
> ---
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
> b/drivers/net/ixgbe/ixgbe_ethdev.c
> index a4e5c539d..f8a84c565 100644
> --- a/drivers/net/ixgbe/ixgbe_ethdev.c
> +++ b/drivers/net/ixgbe/ixgbe_ethdev.c
> @@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev,
> struct ixgbe_hw *hw)
> int err;
> uint32_t mflcn;
>
> + ixgbe_setup_fc(hw);
> +
> err = ixgbe_fc_enable(hw);
>
> /* Not negotiated is not an error case */
> --
> 2.17.1
On 05/12, Guinan Sun wrote:
>The register autoneg can't be updated synchronously
>with flow control mode setting in the state of port start
>, so NIC statistics error occurs. AUTO_NEG Advt register
>should be updated by ixgbe_setup_fc() when enabling flow control.
>The patch fixes the issue.
>
>Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
>Cc: stable@dpdk.org
>
>Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
>---
>v2 changes:
>* Replaced mac.ops.setup_fc() with ixgbe_setup_fc()
>* Modified commit message.
>---
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c
>index a4e5c539d..f8a84c565 100644
>--- a/drivers/net/ixgbe/ixgbe_ethdev.c
>+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>@@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, struct ixgbe_hw *hw)
> int err;
> uint32_t mflcn;
>
>+ ixgbe_setup_fc(hw);
>+
> err = ixgbe_fc_enable(hw);
>
> /* Not negotiated is not an error case */
>--
>2.17.1
>
Applied to dpdk-next-net-intel, Thanks.
Tested-by: Jiang, YuX <yux.jiang@intel.com>
-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ye Xiaolong
Sent: Wednesday, May 13, 2020 8:59 AM
To: Sun, GuinanX <guinanx.sun@intel.com>
Cc: dev@dpdk.org; stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2] net/ixgbe: fix statistics error in flow control mode
On 05/12, Guinan Sun wrote:
>The register autoneg can't be updated synchronously with flow control
>mode setting in the state of port start , so NIC statistics error
>occurs. AUTO_NEG Advt register should be updated by ixgbe_setup_fc()
>when enabling flow control.
>The patch fixes the issue.
>
>Fixes: a524f550da6e ("net/ixgbe: fix flow control mode setting")
>Cc: stable@dpdk.org
>
>Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
>---
>v2 changes:
>* Replaced mac.ops.setup_fc() with ixgbe_setup_fc()
>* Modified commit message.
>---
> drivers/net/ixgbe/ixgbe_ethdev.c | 2 ++
> 1 file changed, 2 insertions(+)
>
>diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c
>b/drivers/net/ixgbe/ixgbe_ethdev.c
>index a4e5c539d..f8a84c565 100644
>--- a/drivers/net/ixgbe/ixgbe_ethdev.c
>+++ b/drivers/net/ixgbe/ixgbe_ethdev.c
>@@ -2543,6 +2543,8 @@ ixgbe_flow_ctrl_enable(struct rte_eth_dev *dev, struct ixgbe_hw *hw)
> int err;
> uint32_t mflcn;
>
>+ ixgbe_setup_fc(hw);
>+
> err = ixgbe_fc_enable(hw);
>
> /* Not negotiated is not an error case */
>--
>2.17.1
>
Applied to dpdk-next-net-intel, Thanks.