From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Phil Yang <Phil.Yang@arm.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"konstantin.ananyev@intel.com" <konstantin.ananyev@intel.com>,
"wenzhuo.lu@intel.com" <wenzhuo.lu@intel.com>,
"qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
Lijian Zhang <Lijian.Zhang@arm.com>, Gavin Hu <Gavin.Hu@arm.com>,
Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
nd <nd@arm.com>, "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber ports
Date: Fri, 8 May 2020 16:36:07 +0800 [thread overview]
Message-ID: <20200508083607.GE75514@intel.com> (raw)
In-Reply-To: <VE1PR08MB46409E07980A5955D90F4109E9A20@VE1PR08MB4640.eurprd08.prod.outlook.com>
On 05/08, Phil Yang wrote:
>> Subject: [dpdk-dev] [PATCH] net/ixgbe: fix link state timing issue on fiber
>> ports
>>
>> With some models of fiber ports (e.g. X520-2 device ID 0x10fb), it
>> is possible when a port is started to experience a timing issue
>> which prevents the link from ever being fully set up.
>>
>> In ixgbe_dev_link_update_share(), if the media type is fiber and the
>> link is down, a flag (IXGBE_FLAG_NEED_LINK_CONFIG) is set. A callback
>> to ixgbe_dev_setup_link_thread_handler() is scheduled which should
>> try to set up the link and clear the flag afterwards.
>>
>> If the device is started before the flag is cleared, the scheduled
>> callback is cancelled. This causes the flag to remain set and
>> subsequent calls to ixgbe_dev_link_update_share() return
>> without trying to retrieve the link state because the flag is set.
>>
>> In ixgbe_dev_cancel_link_thread(), after cancelling the callback,
>> unset the flag on the device to avoid this condition.
>>
>> Fixes: 819d0d1d57f1 ("net/ixgbe: fix blocking system events")
>> Cc: stable@dpdk.org
>>
>> Bugzilla ID: 388
>>
>> Signed-off-by: Phil Yang <phil.yang@arm.com>
>> Signed-off-by: Lijian Zhang <lijian.zhang@arm.com>
>> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
>> ---
>
>Ping.
This fix makes sense to me, thanks for the work.
And it seems can't be applied to latest dpdk-next-net-intel cleanly, could you
do a rebase?
Thanks,
Xiaolong
>
>Thanks,
>Phil
>
><Snip>
next prev parent reply other threads:[~2020-05-08 8:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-19 6:41 [dpdk-stable] " Phil Yang
2020-03-19 10:51 ` Lijian Zhang
2020-05-08 2:48 ` [dpdk-stable] [dpdk-dev] " Phil Yang
2020-05-08 8:36 ` Ye Xiaolong [this message]
2020-05-08 10:31 ` Phil Yang
2020-05-08 10:28 ` [dpdk-stable] [PATCH v2] " Phil Yang
2020-05-11 2:49 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508083607.GE75514@intel.com \
--to=xiaolong.ye@intel.com \
--cc=Gavin.Hu@arm.com \
--cc=Honnappa.Nagarahalli@arm.com \
--cc=Lijian.Zhang@arm.com \
--cc=Phil.Yang@arm.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@intel.com \
--cc=nd@arm.com \
--cc=qi.z.zhang@intel.com \
--cc=stable@dpdk.org \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).