patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] vhost: fix dequeue_zero_zopy cannot be enabled
@ 2020-05-12  9:51 Xuan Ding
  2020-05-13  2:14 ` [dpdk-stable] [PATCH v2] vhost: fix zero-copy " Xuan Ding
  0 siblings, 1 reply; 6+ messages in thread
From: Xuan Ding @ 2020-05-12  9:51 UTC (permalink / raw)
  To: maxime.coquelin, zhihong.wang, xiaolong.ye; +Cc: dev, Xuan Ding, stable

Use flag instead of vsocket->is_server to determine whether vhost is
in client mode. Because vsocket->is_server is not ready yet.

Cc: stable@dpdk.org

Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---
 lib/librte_vhost/socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
index bb8d0d780..0a66ef976 100644
--- a/lib/librte_vhost/socket.c
+++ b/lib/librte_vhost/socket.c
@@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
 			ret = -1;
 			goto out_mutex;
 		}
-		if (!vsocket->is_server) {
+		if ((flags & RTE_VHOST_USER_CLIENT) != 0) {
 			VHOST_LOG_CONFIG(ERR,
 			"error: zero copy is incompatible with vhost client mode\n");
 			ret = -1;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [dpdk-stable] [PATCH v2] vhost: fix zero-copy cannot be enabled
  2020-05-12  9:51 [dpdk-stable] [PATCH] vhost: fix dequeue_zero_zopy cannot be enabled Xuan Ding
@ 2020-05-13  2:14 ` " Xuan Ding
  2020-05-19  6:28   ` Ye Xiaolong
  2020-05-19  7:03   ` Wang, Yinan
  0 siblings, 2 replies; 6+ messages in thread
From: Xuan Ding @ 2020-05-13  2:14 UTC (permalink / raw)
  To: maxime.coquelin, zhihong.wang, xiaolong.ye; +Cc: dev, Xuan Ding, stable

This patch fixes the situation where vhost-user cannot start as server with
dequeue_zero_copy enabled.

Using flag instead of vsocket->is_server to determine whether vhost-user is
in client mode. Because vsocket->is_server is not ready at this time.

Cc: stable@dpdk.org

Signed-off-by: Xuan Ding <xuan.ding@intel.com>
---

v2:
* Added the description of problem solved in commit log.
---
 lib/librte_vhost/socket.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
index bb8d0d780..0a66ef976 100644
--- a/lib/librte_vhost/socket.c
+++ b/lib/librte_vhost/socket.c
@@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
 			ret = -1;
 			goto out_mutex;
 		}
-		if (!vsocket->is_server) {
+		if ((flags & RTE_VHOST_USER_CLIENT) != 0) {
 			VHOST_LOG_CONFIG(ERR,
 			"error: zero copy is incompatible with vhost client mode\n");
 			ret = -1;
-- 
2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [PATCH v2] vhost: fix zero-copy cannot be enabled
  2020-05-13  2:14 ` [dpdk-stable] [PATCH v2] vhost: fix zero-copy " Xuan Ding
@ 2020-05-19  6:28   ` Ye Xiaolong
  2020-05-19  7:13     ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
  2020-05-19  7:03   ` Wang, Yinan
  1 sibling, 1 reply; 6+ messages in thread
From: Ye Xiaolong @ 2020-05-19  6:28 UTC (permalink / raw)
  To: Xuan Ding; +Cc: maxime.coquelin, zhihong.wang, dev, stable

On 05/13, Xuan Ding wrote:
>This patch fixes the situation where vhost-user cannot start as server with
>dequeue_zero_copy enabled.
>
>Using flag instead of vsocket->is_server to determine whether vhost-user is
>in client mode. Because vsocket->is_server is not ready at this time.
>
>Cc: stable@dpdk.org

Fixes: 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode")

And no need to cc stable since above commit is introduced in this release.

>
>Signed-off-by: Xuan Ding <xuan.ding@intel.com>
>---
>
>v2:
>* Added the description of problem solved in commit log.
>---
> lib/librte_vhost/socket.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
>index bb8d0d780..0a66ef976 100644
>--- a/lib/librte_vhost/socket.c
>+++ b/lib/librte_vhost/socket.c
>@@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
> 			ret = -1;
> 			goto out_mutex;
> 		}
>-		if (!vsocket->is_server) {
>+		if ((flags & RTE_VHOST_USER_CLIENT) != 0) {
> 			VHOST_LOG_CONFIG(ERR,
> 			"error: zero copy is incompatible with vhost client mode\n");
> 			ret = -1;
>-- 
>2.17.1
>

Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled
  2020-05-13  2:14 ` [dpdk-stable] [PATCH v2] vhost: fix zero-copy " Xuan Ding
  2020-05-19  6:28   ` Ye Xiaolong
@ 2020-05-19  7:03   ` Wang, Yinan
  1 sibling, 0 replies; 6+ messages in thread
From: Wang, Yinan @ 2020-05-19  7:03 UTC (permalink / raw)
  To: Ding, Xuan, maxime.coquelin, Wang, Zhihong, Ye, Xiaolong
  Cc: dev, Ding, Xuan, stable

Tested-by: Wang, Yinan <yinan.wang@intel.com>

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xuan Ding
> Sent: 2020^[$BG/^[(B5^[$B7n^[(B13^[$BF|^[(B 10:14
> To: maxime.coquelin@redhat.com; Wang, Zhihong <zhihong.wang@intel.com>;
> Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: dev@dpdk.org; Ding, Xuan <Xuan.Ding@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled
> 
> This patch fixes the situation where vhost-user cannot start as server with
> dequeue_zero_copy enabled.
> 
> Using flag instead of vsocket->is_server to determine whether vhost-user is in
> client mode. Because vsocket->is_server is not ready at this time.
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
> ---
> 
> v2:
> * Added the description of problem solved in commit log.
> ---
>  lib/librte_vhost/socket.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c index
> bb8d0d780..0a66ef976 100644
> --- a/lib/librte_vhost/socket.c
> +++ b/lib/librte_vhost/socket.c
> @@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t
> flags)
>  			ret = -1;
>  			goto out_mutex;
>  		}
> -		if (!vsocket->is_server) {
> +		if ((flags & RTE_VHOST_USER_CLIENT) != 0) {
>  			VHOST_LOG_CONFIG(ERR,
>  			"error: zero copy is incompatible with vhost client
> mode\n");
>  			ret = -1;
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled
  2020-05-19  6:28   ` Ye Xiaolong
@ 2020-05-19  7:13     ` " Ye Xiaolong
  2020-05-19 13:43       ` Ferruh Yigit
  0 siblings, 1 reply; 6+ messages in thread
From: Ye Xiaolong @ 2020-05-19  7:13 UTC (permalink / raw)
  To: Xuan Ding, Ferruh Yigit; +Cc: maxime.coquelin, zhihong.wang, dev, stable

Hi, Maxime & Ferruh

This patch is used to fix the regression caused by commit 
715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode") which
was introduced in RC2, I think we should get it in this release.

Thanks,
Xiaolong

On 05/19, Ye Xiaolong wrote:
>On 05/13, Xuan Ding wrote:
>>This patch fixes the situation where vhost-user cannot start as server with
>>dequeue_zero_copy enabled.
>>
>>Using flag instead of vsocket->is_server to determine whether vhost-user is
>>in client mode. Because vsocket->is_server is not ready at this time.
>>
>>Cc: stable@dpdk.org
>
>Fixes: 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode")
>
>And no need to cc stable since above commit is introduced in this release.
>
>>
>>Signed-off-by: Xuan Ding <xuan.ding@intel.com>
>>---
>>
>>v2:
>>* Added the description of problem solved in commit log.
>>---
>> lib/librte_vhost/socket.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>>diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
>>index bb8d0d780..0a66ef976 100644
>>--- a/lib/librte_vhost/socket.c
>>+++ b/lib/librte_vhost/socket.c
>>@@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
>> 			ret = -1;
>> 			goto out_mutex;
>> 		}
>>-		if (!vsocket->is_server) {
>>+		if ((flags & RTE_VHOST_USER_CLIENT) != 0) {
>> 			VHOST_LOG_CONFIG(ERR,
>> 			"error: zero copy is incompatible with vhost client mode\n");
>> 			ret = -1;
>>-- 
>>2.17.1
>>
>
>Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] vhost: fix zero-copy cannot be enabled
  2020-05-19  7:13     ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
@ 2020-05-19 13:43       ` Ferruh Yigit
  0 siblings, 0 replies; 6+ messages in thread
From: Ferruh Yigit @ 2020-05-19 13:43 UTC (permalink / raw)
  To: Ye Xiaolong, Xuan Ding; +Cc: maxime.coquelin, zhihong.wang, dev, stable

On 5/19/2020 8:13 AM, Ye Xiaolong wrote:
> Hi, Maxime & Ferruh
> 
> This patch is used to fix the regression caused by commit 
> 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode") which
> was introduced in RC2, I think we should get it in this release.

+1, v4 of the patch applied to next-net for -rc3

> 
> Thanks,
> Xiaolong
> 
> On 05/19, Ye Xiaolong wrote:
>> On 05/13, Xuan Ding wrote:
>>> This patch fixes the situation where vhost-user cannot start as server with
>>> dequeue_zero_copy enabled.
>>>
>>> Using flag instead of vsocket->is_server to determine whether vhost-user is
>>> in client mode. Because vsocket->is_server is not ready at this time.
>>>
>>> Cc: stable@dpdk.org
>>
>> Fixes: 715070ea10e6 ("vhost: prevent zero-copy with incompatible client mode")
>>
>> And no need to cc stable since above commit is introduced in this release.
>>
>>>
>>> Signed-off-by: Xuan Ding <xuan.ding@intel.com>
>>> ---
>>>
>>> v2:
>>> * Added the description of problem solved in commit log.
>>> ---
>>> lib/librte_vhost/socket.c | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/lib/librte_vhost/socket.c b/lib/librte_vhost/socket.c
>>> index bb8d0d780..0a66ef976 100644
>>> --- a/lib/librte_vhost/socket.c
>>> +++ b/lib/librte_vhost/socket.c
>>> @@ -926,7 +926,7 @@ rte_vhost_driver_register(const char *path, uint64_t flags)
>>> 			ret = -1;
>>> 			goto out_mutex;
>>> 		}
>>> -		if (!vsocket->is_server) {
>>> +		if ((flags & RTE_VHOST_USER_CLIENT) != 0) {
>>> 			VHOST_LOG_CONFIG(ERR,
>>> 			"error: zero copy is incompatible with vhost client mode\n");
>>> 			ret = -1;
>>> -- 
>>> 2.17.1
>>>
>>
>> Reviewed-by: Xiaolong Ye <xiaolong.ye@intel.com>


^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, back to index

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-12  9:51 [dpdk-stable] [PATCH] vhost: fix dequeue_zero_zopy cannot be enabled Xuan Ding
2020-05-13  2:14 ` [dpdk-stable] [PATCH v2] vhost: fix zero-copy " Xuan Ding
2020-05-19  6:28   ` Ye Xiaolong
2020-05-19  7:13     ` [dpdk-stable] [dpdk-dev] " Ye Xiaolong
2020-05-19 13:43       ` Ferruh Yigit
2020-05-19  7:03   ` Wang, Yinan

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox