From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17B56A0093 for ; Tue, 19 May 2020 14:59:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0796E1C1E4; Tue, 19 May 2020 14:59:08 +0200 (CEST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 9DCBD1C1E4 for ; Tue, 19 May 2020 14:59:06 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id v12so15743379wrp.12 for ; Tue, 19 May 2020 05:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oDAMgazqNGf6szzQVzH1Typ1eEDzkcAIbpYXjNPVWT8=; b=Y7EXHDhHmhlBBvIEUz2VRQS5zIOXVGwFcGhFy+wfM+iLb+MVs3ilwug6yuP37XN3p5 K+lyYoiQlbs/BKJJIzLyVLxdM8RMJkZlLgdI8Hh685hNMZtMlR9hk7ZxGou4/eBuizdx 1BjPjCYTFcbGI9oq94xFImD59PWfk9+YAbYYdrEAvB3tOS5O3N6p/L+n1Sg9NbF9uvML 92CNIBB+3Ns99iAMYGRBInuf16j6/fxZYwxEQA7CcKw0aknEly1SXwkz5pyoX4G3BZcO aZSgMlSYiJ2bNmecMCfLGeOCkfCTYB3c8jTClp7ZVT97351bRdlqXB/LRgM4EplzrArC u3wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oDAMgazqNGf6szzQVzH1Typ1eEDzkcAIbpYXjNPVWT8=; b=YY2R7X76fzowoShO8rTrMJZFQlmn8n//ByDlsW5cZHK80CBuSZx+VOrkAQbU4gMFj4 DModoLsNwjOELwrEeXOs7crCpkD/MaUJC3J+vMAdW5fFCnPFEPN4QNm46KckliE6/EpP +oWRAkfYrGhGv1xWWu4LeOteCYxd8VN/+8rzSouUsRmkgLb6m72ydIdlQfWZ/1YHFb1v 9XbBBD4WrAm+gBviuayJ8bZX7RDj9Wp7ZbQm6Fm2JO+5kkmvXUHOPEDgti6lCvXewGX3 O6fNgyaPIOFbE0cf2nPBGpgCg1+ORjrxx3vHuJJshW2FERabnVvrBpA31/yIsd4jOeES 58wg== X-Gm-Message-State: AOAM533vD5CnJNJZPFKYOuCXUyVZcVhIPJypgYsCGfBMAA+kYqlbhkYf wBIgPNDMRhemHwVuj94elV1J2rG/n59zWd2Q X-Google-Smtp-Source: ABdhPJzOh1bAelpkWgNPvxLKHyZIs9gQMYOGViaSH8hU3tMER3YfVKk7L+jkZ+iKCg1emkLlouwGQQ== X-Received: by 2002:adf:9d91:: with SMTP id p17mr24853623wre.119.1589893146350; Tue, 19 May 2020 05:59:06 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id s11sm20466890wrp.79.2020.05.19.05.59.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 05:59:05 -0700 (PDT) From: luca.boccassi@gmail.com To: Qiming Yang Cc: Xiaolong Ye , dpdk stable Date: Tue, 19 May 2020 13:53:31 +0100 Message-Id: <20200519125804.104349-21-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519125804.104349-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/i40e: fix X722 performance' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 2ce209609212398be82eb193c94264e85e766e6f Mon Sep 17 00:00:00 2001 From: Qiming Yang Date: Tue, 3 Mar 2020 13:45:00 +0800 Subject: [PATCH] net/i40e: fix X722 performance [ upstream commit b4668579286c56fded2816602e104abbcf0b5adb ] Lack of GL_SWR_PM_UP_THR value for mac type 4x10G X722 caused it can't reach line rate in one queue one core forwarding case. It's about 1% performance drop. This patch adds value as: Device-ID Value Comments 0x37D0 0x03030303 4x10G FPK This value is hardware specific. Fixes: 3320d4a240da ("net/i40e: workaround performance degradation") Signed-off-by: Qiming Yang Acked-by: Xiaolong Ye --- drivers/net/i40e/i40e_ethdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c index 86fc4f4076..55ba606f85 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c @@ -10408,6 +10408,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value) { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) }, { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) }, { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) }, + { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_SFP_X722) }, { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_KX_B) }, { I40E_GL_SWR_PM_SF_DEVICE(I40E_DEV_ID_QSFP_A) }, -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 13:56:19.661758188 +0100 +++ 0021-net-i40e-fix-X722-performance.patch 2020-05-19 13:56:18.203501531 +0100 @@ -1,8 +1,10 @@ -From b4668579286c56fded2816602e104abbcf0b5adb Mon Sep 17 00:00:00 2001 +From 2ce209609212398be82eb193c94264e85e766e6f Mon Sep 17 00:00:00 2001 From: Qiming Yang Date: Tue, 3 Mar 2020 13:45:00 +0800 Subject: [PATCH] net/i40e: fix X722 performance +[ upstream commit b4668579286c56fded2816602e104abbcf0b5adb ] + Lack of GL_SWR_PM_UP_THR value for mac type 4x10G X722 caused it can't reach line rate in one queue one core forwarding case. It's about 1% performance drop. This patch adds value as: @@ -13,7 +15,6 @@ This value is hardware specific. Fixes: 3320d4a240da ("net/i40e: workaround performance degradation") -Cc: stable@dpdk.org Signed-off-by: Qiming Yang Acked-by: Xiaolong Ye @@ -22,10 +23,10 @@ 1 file changed, 1 insertion(+) diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c -index 9fbda1c34c..c09b9b990c 100644 +index 86fc4f4076..55ba606f85 100644 --- a/drivers/net/i40e/i40e_ethdev.c +++ b/drivers/net/i40e/i40e_ethdev.c -@@ -10504,6 +10504,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value) +@@ -10408,6 +10408,7 @@ i40e_get_swr_pm_cfg(struct i40e_hw *hw, uint32_t *value) { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_KX_C) }, { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T) }, { I40E_GL_SWR_PM_EF_DEVICE(I40E_DEV_ID_10G_BASE_T4) },