From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B30B9A0093 for ; Tue, 19 May 2020 15:13:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A57271D8EC; Tue, 19 May 2020 15:13:40 +0200 (CEST) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 996411D8EC for ; Tue, 19 May 2020 15:13:39 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id e16so15848964wra.7 for ; Tue, 19 May 2020 06:13:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fxqfGlynfl5kczBTvuSOU3ZwMB5EpGT+DW20pLvanJk=; b=Sw4hsKFqBPJzumkqG4dwj7BPRAdWo+ddM9GmilRmHYKbmpU7pgjbCuQufYj4AkiIWQ kkYuU0Ad2hbRoM1IuerS+iQY0dZxCeKihrYdtQapp2uo/27oLrqUn7T5izjme0a8u9d4 J63ePi5ygFtwxwtpSKO0CBJw7pBF+DHqlmB7J9LXjmfXHY3H+Pyv90AzfW27C17APvTD ZRw9jj6Uc82SkEPjXBZOhYz008e3cjvDrpFLodcOth+kbmyaIHFg2y+ztIe2p0SGc53C +lFurhZ0pJh2ZDSPajowbsNwh7HOqRGjQtoflaO65Nvu58T8DoDIOJLkE5pFwoIffDi2 s+7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fxqfGlynfl5kczBTvuSOU3ZwMB5EpGT+DW20pLvanJk=; b=igapUSnpiDiZKXmXcwD2l99+y1YaGrCL/pOJMmp80DL7Gd6/QtAzBHQmtzd0HN4myJ O2QBsKsx0wEAh0u68h0rzZFoS52R5HXAk53TuxNV4AdDAhPn2liqYPaClwO3HrZa6eVn +X2PuCZSbyazTqFK4ctnfT8Gt/oFzv1MFo6RG88s/xmICc6MTye1qmar9/Z6+MXxXGov ba2ZxkUv6+ZeuxkLSoy3GW1r3C9ogmYhNhFoYy2ffkoeoEt/Ot/A225gARl/R4kLCa8Q N6XdyKm27jr9huLwGg2ZX6t1y0cRzEZLyiIxSjV+m99FXryrND4Drm/6We+bsu3apRkl Khew== X-Gm-Message-State: AOAM532FHKDtRl1I0+GcQ8E0ZrqIHZfFi0UR8z5LlRdISY8AQ4Dc0T+M l/1TLQA365nJyOb5n+fNluU= X-Google-Smtp-Source: ABdhPJyujumhk2uy0VNqvjZp9hes+v1rCFbX1wOOrPeavuQlBz+hTm4o7sMte4DRa2f+CIyNFf+dPQ== X-Received: by 2002:a5d:4e8f:: with SMTP id e15mr25652058wru.91.1589894019375; Tue, 19 May 2020 06:13:39 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id z11sm20860655wro.48.2020.05.19.06.13.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:13:38 -0700 (PDT) From: luca.boccassi@gmail.com To: Jasvinder Singh Cc: Cristian Dumitrescu , dpdk stable Date: Tue, 19 May 2020 14:04:43 +0100 Message-Id: <20200519130549.112823-148-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/softnic: fix memory leak for thread' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 60dfeffc23ad872474da8ac65e1323e072705d8d Mon Sep 17 00:00:00 2001 From: Jasvinder Singh Date: Mon, 27 Apr 2020 18:13:20 +0100 Subject: [PATCH] net/softnic: fix memory leak for thread [ upstream commit 22335d4348d4b4b615d5556947c0297e0fe5d79b ] For sending request messages to data plane threads, the caller invokes thread_msg_send_recv() function which never returns null response. Thus, removed redundant check on the returned response. Coverity issue: 357717, 357772 Fixes: 70709c78fda6 ("net/softnic: add command to enable/disable pipeline") Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- drivers/net/softnic/rte_eth_softnic_thread.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/softnic/rte_eth_softnic_thread.c b/drivers/net/softnic/rte_eth_softnic_thread.c index d610b1617e..d61846e030 100644 --- a/drivers/net/softnic/rte_eth_softnic_thread.c +++ b/drivers/net/softnic/rte_eth_softnic_thread.c @@ -359,8 +359,6 @@ softnic_thread_pipeline_enable(struct pmd_internals *softnic, /* Send request and wait for response */ rsp = thread_msg_send_recv(softnic, thread_id, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; @@ -444,8 +442,6 @@ softnic_thread_pipeline_disable(struct pmd_internals *softnic, /* Send request and wait for response */ rsp = thread_msg_send_recv(softnic, thread_id, req); - if (rsp == NULL) - return -1; /* Read response */ status = rsp->status; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:50.482343836 +0100 +++ 0148-net-softnic-fix-memory-leak-for-thread.patch 2020-05-19 14:04:44.472653013 +0100 @@ -1,8 +1,10 @@ -From 22335d4348d4b4b615d5556947c0297e0fe5d79b Mon Sep 17 00:00:00 2001 +From 60dfeffc23ad872474da8ac65e1323e072705d8d Mon Sep 17 00:00:00 2001 From: Jasvinder Singh Date: Mon, 27 Apr 2020 18:13:20 +0100 Subject: [PATCH] net/softnic: fix memory leak for thread +[ upstream commit 22335d4348d4b4b615d5556947c0297e0fe5d79b ] + For sending request messages to data plane threads, the caller invokes thread_msg_send_recv() function which never returns null response. Thus, removed redundant check on @@ -10,7 +12,6 @@ Coverity issue: 357717, 357772 Fixes: 70709c78fda6 ("net/softnic: add command to enable/disable pipeline") -Cc: stable@dpdk.org Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu