From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED40AA0093 for ; Tue, 19 May 2020 15:14:55 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E30401D913; Tue, 19 May 2020 15:14:55 +0200 (CEST) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 0762C1D702 for ; Tue, 19 May 2020 15:14:55 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id l17so15877659wrr.4 for ; Tue, 19 May 2020 06:14:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=akBxSPpjS7Zd//ihn5Spvu2PmtEBVQw+oKPchzQr2bY=; b=f2hlFfEGJlzHD3RJjvH1cUehQI2xmD6e+YxZbKkGgL5Kc8Ac/+mySu+mzL9FxhhgiJ yYP5XeINIfMpLL3CGzaVDMUxE0IjxZBrECto5F7eIRXmHyrc68txxPQqKFYhtES+QBaR vmEQmaOLbtJk0PEwfQcv8BXM/Bk1Z8GvZlmplgozlx9wz5Amp3GVzZNlP+Ve4a3zSuor M1QYXi+Um9f9cszvME29FSDs4WUndWhgUixsUCrtoCJHAqtxAjJRBQO2UGvoszQdnSJO XQ0TVrsF9IWz7NQeZNmU4RAnf1NNb547QLGqxzw3j8zfYuqBXj30J83B8Zaabun9hIAq 42Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=akBxSPpjS7Zd//ihn5Spvu2PmtEBVQw+oKPchzQr2bY=; b=ZuaWTmFGc9rm/ZaLf2TWVUKJwxu4c4g9IaRykNEwcGxiE66IqJ8n52uR72nicD9/QV 3AiknDtAKtSKZgje0FX+8qnKtq9lj4vXxEXGeeldNNtnZvZN3bWVnfeUNbJrijbAMYzl /wG7MARfOdZ/IfO1uPOvtvLCelEvfW+wBZPorC5HG5SJZW+7Sis0gLc9OLwkSevbgCyw in2WWQ8xaGzaJmNmrXHEw/DBJa+jHVOFgoowXvV2Y+ja3rs42Us+NncD6oGrVePiabLu 3ZlfDBZaaEpS34sFFubrT3c6PNGwkTGkBz6ZfvMwiPNhX9KUSzBtlq/P9GLTXnCokjfl RHxA== X-Gm-Message-State: AOAM530JXgU+II8gHfS5P3CEAGvsY9LDSgRWmXhVi9eYoKOXiLzokrPC IJylJyUc4BbNxKGLLhlrFxM= X-Google-Smtp-Source: ABdhPJxDfJtxRJ+ikL09AvwRKMUsTbX2+tuV10AJnOtVujoi+wDXyi/5ir4LGYwoC4mTGwsYXmcD6A== X-Received: by 2002:a5d:694d:: with SMTP id r13mr24548237wrw.238.1589894094715; Tue, 19 May 2020 06:14:54 -0700 (PDT) Received: from localhost ([2a01:4b00:f419:6f00:7a8e:ed70:5c52:ea3]) by smtp.gmail.com with ESMTPSA id u16sm20413143wrq.17.2020.05.19.06.14.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:14:54 -0700 (PDT) From: luca.boccassi@gmail.com To: Ferruh Yigit Cc: Konstantin Ananyev , Jerin Jacob , dpdk stable Date: Tue, 19 May 2020 14:05:06 +0100 Message-Id: <20200519130549.112823-171-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'event/octeontx2: fix build for O1 optimization' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From a009c7667f92df63260908faa5891eb862b54cbd Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Mon, 11 May 2020 17:07:25 +0100 Subject: [PATCH] event/octeontx2: fix build for O1 optimization MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit ea153cc853049c6f935693e48d2866782370a3fe ] Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using gcc 7.3.0 Build error In file included from .../drivers/event/octeontx2/ot x2_evdev.c:15:0: .../drivers/event/octeontx2/otx2_evdev_stats.h: In function ‘otx2_sso_xstats_get’: .../drivers/event/octeontx2/otx2_evdev_stats.h:124:9: error: ‘xstats’ may be used uninitialized in this function [-Werror=maybe-uninitialized] xstat = &xstats[ids[i] - start_offset]; ~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ This is false positive, 'xstats_mode_count' should be preventing taking the loop and accessing 'xstats'. Returning in that case to silence the compiler warning. Reported-by: Konstantin Ananyev Signed-off-by: Ferruh Yigit Tested-by: Konstantin Ananyev Acked-by: Konstantin Ananyev Acked-by: Jerin Jacob --- drivers/event/octeontx2/otx2_evdev_stats.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/event/octeontx2/otx2_evdev_stats.h b/drivers/event/octeontx2/otx2_evdev_stats.h index 9d7c694ee6..74fcec8a07 100644 --- a/drivers/event/octeontx2/otx2_evdev_stats.h +++ b/drivers/event/octeontx2/otx2_evdev_stats.h @@ -67,7 +67,7 @@ otx2_sso_xstats_get(const struct rte_eventdev *event_dev, switch (mode) { case RTE_EVENT_DEV_XSTATS_DEVICE: - break; + return 0; case RTE_EVENT_DEV_XSTATS_PORT: if (queue_port_id >= (signed int)dev->nb_event_ports) goto invalid_value; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:51.493924246 +0100 +++ 0171-event-octeontx2-fix-build-for-O1-optimization.patch 2020-05-19 14:04:44.512653738 +0100 @@ -1,4 +1,4 @@ -From ea153cc853049c6f935693e48d2866782370a3fe Mon Sep 17 00:00:00 2001 +From a009c7667f92df63260908faa5891eb862b54cbd Mon Sep 17 00:00:00 2001 From: Ferruh Yigit Date: Mon, 11 May 2020 17:07:25 +0100 Subject: [PATCH] event/octeontx2: fix build for O1 optimization @@ -6,6 +6,8 @@ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit +[ upstream commit ea153cc853049c6f935693e48d2866782370a3fe ] + Can be reproduced with "make EXTRA_CFLAGS='-O1'" command using gcc 7.3.0