From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08FF5A0093 for ; Tue, 19 May 2020 15:15:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D48E01D94C; Tue, 19 May 2020 15:15:32 +0200 (CEST) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 0E3361D94A for ; Tue, 19 May 2020 15:15:31 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id w64so3504694wmg.4 for ; Tue, 19 May 2020 06:15:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pvOGK34r4V+RzBe6f8MRRPlF4KQBuQod2nYYeUWlbks=; b=q/1n7omgqNwrYG8/A1HX8njogmU4Em7zxXRCGv4dRCpZv0nRtFqyKv+81WGLLVFoG5 Mri+9Ekd+Iv+wgw4C/JVrSeHsjW0MIOW0bP7m2jXIQm84IcFRnOpVyTeUJc8wofqo+US xsqbwePUFarpmC3hnpbFnRowMWm92F3fwiab+Sq0ZwC7nyn6T4CPKcDi3JCg8FoaDhp7 UFlLln6hVA21dGGE5P0SJW3d2hTxcQZTe3mkeH3soIu+7o2/UVpwts+vRY4WmMnPeCd2 U+OzyOIc4THXPUWxCYqyXHYUC/MJnXIEpeUlj6PCxcRGbION3NH671/Gbnvpw6ziPaE0 AgjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pvOGK34r4V+RzBe6f8MRRPlF4KQBuQod2nYYeUWlbks=; b=SAzwZ57cmiXMrZ+2Kxs96QRntyPH9nD34A2K+2gWOeaseLLMeLlQQTsgdCVLO8qZPk JSEiHR6aFbjLli3Vc+ZOahNMgp+Jik7pSZ1hWw4u6n4BvUGYVOnjw7oW0CR+QsMGgXEO 5SGyQBUptTK+aRHNTWHDDZznK9bmPbvN8vatZ2NXRVc2A6ZLtTZsIPYfyZTg8mxiWmU2 P7qQHwPYZB+i6devYqu6ivpg+93QRtPpPkBuyIeoBF6D9lGTHkmUihPYT3TboH/ZQNRj ZO9Mr6v98Ld60uBTx79qEiZHNR/9XcMLvyh+pzWYmVzf2SYvH3VdtQqjufAVFGWZlHS9 PBgw== X-Gm-Message-State: AOAM53181leU+9kxDxS3zB6E8Stqof9bANbw7x3sjRnUS6rGyih6OWr3 ltiS+9OhRiPUgccPddk876o= X-Google-Smtp-Source: ABdhPJwTgYKVLKV+xU6G9BQr8Kqp1zZqXMU+4IdZJEifR6vRWqE+L3t4lcYbrvJVFJBUjxzud6Dtqg== X-Received: by 2002:a1c:545b:: with SMTP id p27mr5279110wmi.81.1589894130799; Tue, 19 May 2020 06:15:30 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id o7sm3685165wmc.43.2020.05.19.06.15.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:15:30 -0700 (PDT) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: dpdk stable Date: Tue, 19 May 2020 14:05:20 +0100 Message-Id: <20200519130549.112823-185-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/netvsc: do RSS across Rx queue only' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From f815b93c27797ab45ba080d1715e195ecfdef994 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 30 Apr 2020 12:08:52 -0700 Subject: [PATCH] net/netvsc: do RSS across Rx queue only [ upstream commit 019a28912bf0113566ed5599192973bc1a7cbb07 ] If number of tx queues is greater than the number of rx queues; the driver ends up allocating more channels than rx queues. The problem is that the RSS indirection table is programmed such that some packets will end up on a channel that would never be polled. The fix is to limit the RSS indirection table by number of rx queues not channels. Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c index 46da5a4e81..15a085c849 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -575,7 +575,7 @@ static int hn_dev_configure(struct rte_eth_dev *dev) dev->data->nb_tx_queues); for (i = 0; i < NDIS_HASH_INDCNT; i++) - hv->rss_ind[i] = i % hv->num_queues; + hv->rss_ind[i] = i % dev->data->nb_rx_queues; hn_rss_hash_init(hv, rss_conf); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:52.098175590 +0100 +++ 0185-net-netvsc-do-RSS-across-Rx-queue-only.patch 2020-05-19 14:04:44.532654101 +0100 @@ -1,8 +1,10 @@ -From 019a28912bf0113566ed5599192973bc1a7cbb07 Mon Sep 17 00:00:00 2001 +From f815b93c27797ab45ba080d1715e195ecfdef994 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 30 Apr 2020 12:08:52 -0700 Subject: [PATCH] net/netvsc: do RSS across Rx queue only +[ upstream commit 019a28912bf0113566ed5599192973bc1a7cbb07 ] + If number of tx queues is greater than the number of rx queues; the driver ends up allocating more channels than rx queues. The problem is that the RSS indirection table is programmed such @@ -11,7 +13,6 @@ of rx queues not channels. Fixes: 92d23a57cafe ("net/netvsc: support configuring RSS parameters") -Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- @@ -19,7 +20,7 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/netvsc/hn_ethdev.c b/drivers/net/netvsc/hn_ethdev.c -index 7bf5465ce5..60102362e1 100644 +index 46da5a4e81..15a085c849 100644 --- a/drivers/net/netvsc/hn_ethdev.c +++ b/drivers/net/netvsc/hn_ethdev.c @@ -575,7 +575,7 @@ static int hn_dev_configure(struct rte_eth_dev *dev)