From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48592A0093 for ; Tue, 19 May 2020 15:15:47 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F3421D94F; Tue, 19 May 2020 15:15:47 +0200 (CEST) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 464161D955 for ; Tue, 19 May 2020 15:15:45 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id s8so15861767wrt.9 for ; Tue, 19 May 2020 06:15:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=OsrLKVlQkBudXjF6aU9lgjxJvq1rrWPP2AZ3MlWYBnE=; b=V3PvKT27RN2io4H1tivmXy+ClY2d+wjaA7rM7RF2R0t4Woc61pMhodFkFWYipZ7Xio DrPJ7OmlZMr964Zo3aNxhlOhh0FJGLCnllFh6UnOFti3uzafrhIXgKZtipqgoJyuMD7v tNELusAjW0pD2//ktqWymVCzmXl7IjZ1cCRHkjN4fn7x+GsPrXXWmb70F6alth2DNOqw aHqMHly3yaeMMIpw3hSJYlGdDFKsNEKkNFikNdawEImsF5N4974nH8rGXxMd/KwjNkVq FKY5hesIXVKy3C820jWJ9PBuGHhNQCVveDJIMEOK34PKFwLJSRgOa34Hmel9aX2rtA7y ZLWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=OsrLKVlQkBudXjF6aU9lgjxJvq1rrWPP2AZ3MlWYBnE=; b=H9e+/VpSIp1U3Mb+PHN9MSKOO5LuzokboiLp0oUta2oDkrBQ9Ymv+sRDZyASR2x0UP 5rodNJYgndK0qf9oiacryGEem1yh76iXSX3UYM1AU6sk61oCJ8Eli/UPk0zCaGaH/iko OQ71vw+bNzQB/O3Izx0z7dMRSrluyX2M4imZtP5LefiaVoOtQmduqGTie3hwAP2vSZ2S YiS4cXgBlQSNRBR8JBtZzW9LUhayjE6K/HG5RyFmIqwryefmc4GgKxm0NrjVaPQ/DN2v IR1S0LxkqZMMU0SifQTWCUx0CwaPJPt/UffhBiaO/LXuJPB0gd6/Kh5NBzROH7+NvvJ4 cJow== X-Gm-Message-State: AOAM532hZOyhbJaWnmMF0Mjs2J17mhrlnWEgoa6Z88hk6AlnjqcfH9QS vK2BzHwfZtwknWqSATFfDwO6shPrt7YstvR8 X-Google-Smtp-Source: ABdhPJyfZxdtrGjdwXK2e+ziOsA+0JcNWknOFjhrkQL1uXNCSafyPduHrcFw3YuEcsvAVPFtAX1nVA== X-Received: by 2002:a5d:650f:: with SMTP id x15mr25840649wru.100.1589894144992; Tue, 19 May 2020 06:15:44 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id m65sm4082695wmm.17.2020.05.19.06.15.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:15:44 -0700 (PDT) From: luca.boccassi@gmail.com To: Zhihong Peng Cc: Zhimin Huang , Xiaolong Ye , dpdk stable Date: Tue, 19 May 2020 14:05:24 +0100 Message-Id: <20200519130549.112823-189-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/ixgbe: fix link status synchronization on BSD' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From f05c433b440fb20cccfa18ac0328f2ac9abdca60 Mon Sep 17 00:00:00 2001 From: Zhihong Peng Date: Thu, 16 Apr 2020 23:52:12 -0400 Subject: [PATCH] net/ixgbe: fix link status synchronization on BSD [ upstream commit 0012111a3d879b0b0e27d14a841e2a729545727d ] DPDK does not implement interrupt mechanism on BSD, so force NIC status synchronization. Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF") Signed-off-by: Zhihong Peng Tested-by: Zhimin Huang Acked-by: Xiaolong Ye --- drivers/net/ixgbe/ixgbe_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c index 29b7501e0a..e0f59e307d 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c @@ -4253,6 +4253,11 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0) wait = 0; +/* BSD has no interrupt mechanism, so force NIC status synchronization. */ +#ifdef RTE_EXEC_ENV_FREEBSD + wait = 1; +#endif + if (vf) diag = ixgbevf_check_link(hw, &link_speed, &link_up, wait); else -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:52.264636938 +0100 +++ 0189-net-ixgbe-fix-link-status-synchronization-on-BSD.patch 2020-05-19 14:04:44.540654246 +0100 @@ -1,13 +1,14 @@ -From 0012111a3d879b0b0e27d14a841e2a729545727d Mon Sep 17 00:00:00 2001 +From f05c433b440fb20cccfa18ac0328f2ac9abdca60 Mon Sep 17 00:00:00 2001 From: Zhihong Peng Date: Thu, 16 Apr 2020 23:52:12 -0400 Subject: [PATCH] net/ixgbe: fix link status synchronization on BSD +[ upstream commit 0012111a3d879b0b0e27d14a841e2a729545727d ] + DPDK does not implement interrupt mechanism on BSD, so force NIC status synchronization. Fixes: dc66e5fd01b9 ("net/ixgbe: improve link state check on VF") -Cc: stable@dpdk.org Signed-off-by: Zhihong Peng Tested-by: Zhimin Huang @@ -17,10 +18,10 @@ 1 file changed, 5 insertions(+) diff --git a/drivers/net/ixgbe/ixgbe_ethdev.c b/drivers/net/ixgbe/ixgbe_ethdev.c -index aa1e8aac51..cf5f1fe709 100644 +index 29b7501e0a..e0f59e307d 100644 --- a/drivers/net/ixgbe/ixgbe_ethdev.c +++ b/drivers/net/ixgbe/ixgbe_ethdev.c -@@ -4257,6 +4257,11 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, +@@ -4253,6 +4253,11 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev, if (wait_to_complete == 0 || dev->data->dev_conf.intr_conf.lsc != 0) wait = 0;