From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 972D8A0093 for ; Tue, 19 May 2020 15:17:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8E4A31D979; Tue, 19 May 2020 15:17:00 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 34F881D979 for ; Tue, 19 May 2020 15:16:59 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id v12so15814460wrp.12 for ; Tue, 19 May 2020 06:16:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=LwafepGeOmtwbX7viSYw0E7h8i5US9A07dQZFZTrHHo=; b=JEk98wdjcyqzrXX/qqlnoY2Ei1sNiaYqu82fGO/aN4oqvbE1ZGjAholLDTTKgK3YDh TqtV2/ZmXBS6brZnAqUSbmoNxzCbuU+l5LtwPuAaOdAdK9c8rXIO8pQagFozijDnDsh5 52mQfUKAwseB1AcnEIrsYFzA9j0wLRVa1iRDM0+goSCit1LAJByMU2pkyOw+ojtB3hyt YrlBtZUag7VO0ZbsoNshxABwLTFEcV4kBiq/eCpdLKJEIScK02PicK/TNUs6Hw1lNn3I +b7w2Ac6l8RjX6fQqqonQr15NmEf3+cCtlWdfRf8zsGbmoofZg0kjLKmmND4mXnkEgDM t2YQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=LwafepGeOmtwbX7viSYw0E7h8i5US9A07dQZFZTrHHo=; b=fhUHaqFHQ1FrQDHP1WQXjjHa9GX1UTibbJVBiixRIz5B4V4cZW/cEREWj8TGPAxH1N uwWrRZw6JNt3C5cky9J5i7p40Z7fRMowC+bOo9oJAJclllc/SyzhuUXLWg3wDUeONu5Z 0B0LLcG+byZ2W31cZYUeKjnEtLFAns2Z9555Bg8Ky6vcEzhX6AOqk72rw6zNUAZQfFqo Afja3T49u5x2KmvY2ExLqm2GcaCBo4ciPOt3QKifcH2gN2pWXyGP7FO4yBM5l79pJxW2 PZ777wbUAQfclvMOEQZKCNSy2x9CwqLMVjcUmkKzxX7AmDTAscZ1FTx6XAXZBLSL4v5X AONQ== X-Gm-Message-State: AOAM533M1huc4lM5WMffBKWC/R9MN/YTkuG9uYV4nS4eagbapRXsmB5B 7I7xHQCjxDZjG5LEqDVKMhw= X-Google-Smtp-Source: ABdhPJwH7o5ZaxL7dBKkFH1w4R+GO1o0tx6n5jprUoDReJ0egmz3xqqo04S9hv9Ze3BV+Ej+RlBLVQ== X-Received: by 2002:adf:ed06:: with SMTP id a6mr25120534wro.8.1589894218887; Tue, 19 May 2020 06:16:58 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id 37sm21378526wrk.61.2020.05.19.06.16.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:16:58 -0700 (PDT) From: luca.boccassi@gmail.com To: Alexander Kozyrev Cc: Matan Azrad , dpdk stable Date: Tue, 19 May 2020 14:05:46 +0100 Message-Id: <20200519130549.112823-211-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/mlx5: fix Tx queue release debug log timing' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 40a2233e7897b48d042bd59c90ba9c22e4788a59 Mon Sep 17 00:00:00 2001 From: Alexander Kozyrev Date: Wed, 6 May 2020 18:10:59 +0000 Subject: [PATCH] net/mlx5: fix Tx queue release debug log timing [ upstream commit 776aec28fc47dbf29466555b34cd79ab9cf7a7bc ] Program received signal SIGSEGV, Segmentation fault. 0x00000000008ef7c4 in mlx5_tx_queue_release (dpdk_txq=0x17ce01680) at drivers/net/mlx5/mlx5_txq.c:302 301 mlx5_txq_release(ETH_DEV(priv), i); 302 DRV_LOG(DEBUG, "port %u removing Tx queue %u from list", 303 PORT_ID(priv), txq->idx); The problem is txq is freed inside the mlx5_txq_release() function and no longer valid in the debug log right after this invocation. Move the debug log before the mlx5_txq_release() function to fix this. Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") Signed-off-by: Alexander Kozyrev Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_txq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c index 3e29613d4b..c7751e83c0 100644 --- a/drivers/net/mlx5/mlx5_txq.c +++ b/drivers/net/mlx5/mlx5_txq.c @@ -295,9 +295,9 @@ mlx5_tx_queue_release(void *dpdk_txq) priv = txq_ctrl->priv; for (i = 0; (i != priv->txqs_n); ++i) if ((*priv->txqs)[i] == txq) { - mlx5_txq_release(ETH_DEV(priv), i); DRV_LOG(DEBUG, "port %u removing Tx queue %u from list", PORT_ID(priv), txq->idx); + mlx5_txq_release(ETH_DEV(priv), i); break; } } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:53.206934177 +0100 +++ 0211-net-mlx5-fix-Tx-queue-release-debug-log-timing.patch 2020-05-19 14:04:44.608655479 +0100 @@ -1,8 +1,10 @@ -From 776aec28fc47dbf29466555b34cd79ab9cf7a7bc Mon Sep 17 00:00:00 2001 +From 40a2233e7897b48d042bd59c90ba9c22e4788a59 Mon Sep 17 00:00:00 2001 From: Alexander Kozyrev Date: Wed, 6 May 2020 18:10:59 +0000 Subject: [PATCH] net/mlx5: fix Tx queue release debug log timing +[ upstream commit 776aec28fc47dbf29466555b34cd79ab9cf7a7bc ] + Program received signal SIGSEGV, Segmentation fault. 0x00000000008ef7c4 in mlx5_tx_queue_release (dpdk_txq=0x17ce01680) at drivers/net/mlx5/mlx5_txq.c:302 @@ -14,7 +16,6 @@ Move the debug log before the mlx5_txq_release() function to fix this. Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") -Cc: stable@dpdk.org Signed-off-by: Alexander Kozyrev Acked-by: Matan Azrad @@ -23,10 +24,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c -index 29e5cabab6..a211fa91b2 100644 +index 3e29613d4b..c7751e83c0 100644 --- a/drivers/net/mlx5/mlx5_txq.c +++ b/drivers/net/mlx5/mlx5_txq.c -@@ -298,9 +298,9 @@ mlx5_tx_queue_release(void *dpdk_txq) +@@ -295,9 +295,9 @@ mlx5_tx_queue_release(void *dpdk_txq) priv = txq_ctrl->priv; for (i = 0; (i != priv->txqs_n); ++i) if ((*priv->txqs)[i] == txq) {