From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4E361A0093 for ; Tue, 19 May 2020 15:08:22 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 403AC1D68E; Tue, 19 May 2020 15:08:22 +0200 (CEST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 843121D603 for ; Tue, 19 May 2020 15:08:21 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id f134so3009925wmf.1 for ; Tue, 19 May 2020 06:08:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=6DwPTIJd62IKzduSivHRFv1QmvfCRUdEZ2f1UF+fQ/Y=; b=KF2Nwvom+OMeweqv7GzGo8+ffmUaGR360i3PytJ0oMBgXGb4iJCN+nq1zJP8roOmSJ 5LeXwMtC3kI9M+8Sdv5frvaSVkdu6WklBYyULZxfNn7tQ0k9pytLXwBGZVWUQpVHUimr NTHY0P5QwrYQuYvTbA8vaRSi0avdP8Fn5R8GiC6SakGQ4e+EnjjVF4zKmHSQyXD68wws Wgp97pfHuqRAwVRSPcig9gHjNA7Qp2Ji0r2hVSYifScSO5WtpxiUx+GiE7bRHhwnmrM1 kWrIKQG9ghQm7GxfKZzax0meTgMfd+Vkp/DwO+QUH0wdj56b/jdgNlJ14o4fHGky13V3 vITA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=6DwPTIJd62IKzduSivHRFv1QmvfCRUdEZ2f1UF+fQ/Y=; b=smqWpDzWBAog3kPLnCrgepO0SU5Kmx+tItsTpCTgMrZGsCm0DtIH7UJoMOiRX5fCc7 cSBczPA1W3/QriKXmG0uwaUSHBGdRleXOb/frBh7ulETX09CpHdj98ujQteWCXgJ3RU0 MVJrrL5IQqRyONrDtFrgpOEZRsx9B5anTgrtQ4FSD1bSI7KPYnQRZUFH9VPkmPNqEio2 pAA64RWEhKzpKk2wRUeby6UEdh2sPzTDSrhOqfBpGJ0D1y3J++DZyvhKhhlEdTtHqAw+ e1GUGBJiMWLbiLMwInAx+/iED/OwhJlKgKk0TUfMLbD4KPLfmzVQtP0h10kcmabScJNW HSeA== X-Gm-Message-State: AOAM532Rkki+0pCq2zJ3tg0aIT7twUwmkuoeSZhpgGLj0ldSAxswJGBT 0SsAAj5AlLRLSapekN0ZD8S2nJLjYS/a6en2 X-Google-Smtp-Source: ABdhPJyJMFRR69Okx3bO1ZWmJqm4ePTcsiqeOBE+DvL+wwOjETRv+Wzs+o/kCGAlfakOiifv5GY5zA== X-Received: by 2002:a1c:3286:: with SMTP id y128mr5390696wmy.119.1589893701283; Tue, 19 May 2020 06:08:21 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id d9sm3943648wmd.10.2020.05.19.06.08.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:08:20 -0700 (PDT) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: dpdk stable Date: Tue, 19 May 2020 14:03:02 +0100 Message-Id: <20200519130549.112823-47-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/netvsc: handle Tx completions based on burst size' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 9f54fa3e2b37e2ba173f18c0f1e4cca6b4e74596 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 31 Mar 2020 10:14:02 -0700 Subject: [PATCH] net/netvsc: handle Tx completions based on burst size [ upstream commit 56edef9906558c69a1440173a5a3aac8f8f8710f ] If tx_free_thresh is quite low, it is possible that we need to cleanup based on burst size. Fixes: fc30efe3a22e ("net/netvsc: change Rx descriptor setup and sizing") Signed-off-by: Stephen Hemminger --- drivers/net/netvsc/hn_rxtx.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/netvsc/hn_rxtx.c b/drivers/net/netvsc/hn_rxtx.c index e8df846042..cbdfcc628b 100644 --- a/drivers/net/netvsc/hn_rxtx.c +++ b/drivers/net/netvsc/hn_rxtx.c @@ -1375,7 +1375,7 @@ hn_xmit_pkts(void *ptxq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) struct hn_data *hv = txq->hv; struct rte_eth_dev *vf_dev; bool need_sig = false; - uint16_t nb_tx; + uint16_t nb_tx, avail; int ret; if (unlikely(hv->closed)) @@ -1390,7 +1390,8 @@ hn_xmit_pkts(void *ptxq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) return (*vf_dev->tx_pkt_burst)(sub_q, tx_pkts, nb_pkts); } - if (rte_mempool_avail_count(txq->txdesc_pool) <= txq->free_thresh) + avail = rte_mempool_avail_count(txq->txdesc_pool); + if (nb_pkts > avail || avail <= txq->free_thresh) hn_process_events(hv, txq->queue_id, 0); for (nb_tx = 0; nb_tx < nb_pkts; nb_tx++) { -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:46.453207797 +0100 +++ 0047-net-netvsc-handle-Tx-completions-based-on-burst-size.patch 2020-05-19 14:04:44.184647792 +0100 @@ -1,13 +1,14 @@ -From 56edef9906558c69a1440173a5a3aac8f8f8710f Mon Sep 17 00:00:00 2001 +From 9f54fa3e2b37e2ba173f18c0f1e4cca6b4e74596 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 31 Mar 2020 10:14:02 -0700 Subject: [PATCH] net/netvsc: handle Tx completions based on burst size +[ upstream commit 56edef9906558c69a1440173a5a3aac8f8f8710f ] + If tx_free_thresh is quite low, it is possible that we need to cleanup based on burst size. Fixes: fc30efe3a22e ("net/netvsc: change Rx descriptor setup and sizing") -Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger ---