From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C196AA0093 for ; Tue, 19 May 2020 15:09:11 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B65491D174; Tue, 19 May 2020 15:09:11 +0200 (CEST) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by dpdk.org (Postfix) with ESMTP id 310E21D6B1 for ; Tue, 19 May 2020 15:09:11 +0200 (CEST) Received: by mail-wr1-f66.google.com with SMTP id y3so15878836wrt.1 for ; Tue, 19 May 2020 06:09:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PplGR4aFrN73/HF2ldMLWXBKV3Ahk7vyX1S2vh2bh8g=; b=PlfLveec/CLbeI4HEPY+0PQoNspFz75CCNO7/DwGv/CSvnGww57JrCDvMqEYtjTuQb D4/QS3y8gvRIoyVw+LVYNibfeM3d7c+LoURCYXOffe2b024mgfY8naRq9Mtji6FgDW1a CqfA5f+Flzp7vf1zXqS25dGG/fG2HLleaL9nV/ADbJl6Qwdfp0Q3SpVaohkodCcamnJI ogOhSal9waa+V4dViZiFgVUYH9UjM/Yeq37VeWeU0khnHJscr8aNVQTIeXumMgD5nTJO Kb1xWScEYDiCZ/GgpP9Jpo8jael+aIxrNLJkZ2+G956bUpH/XE2oIjs+Wjy617dQNS/u Cmwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PplGR4aFrN73/HF2ldMLWXBKV3Ahk7vyX1S2vh2bh8g=; b=jqjD2vV4kUO/Vv68bHgUlW00hbpO7XH/bUPCWpWwUKG/XuIr7AS76142R3barYuAPq njSimwuwnbdpG8yQUQwGfKVLJlxj1FF3SVXweBlFNJvv2W1t5Yg9Wy+wKgZEKZewssA9 qMEked1Rr+9X4GO20MWgoVLW8Yvx40RaRZ5POGXji3z9BKJcMNL1w2utbsheS6CXub2C VeQeli9vUHf/mbZRn0XZ9F7MeA1PLJmnwBeY26YgVKywOaGU51Kv/Q3AijlP81eX1sDl 1wZgTV5zxZO8AjCe+Mkz4KFZboId4q/QB/UAILMuSs5oI1N9lT2d6o55l9feibaL+P7d xIzg== X-Gm-Message-State: AOAM530MMgrZcn+1kKmEiEg5rK0rJEIfyg8j4v388OOx9qI1tvKnz+uL 8FYmO+q4BE8xuccXEPpWsDA= X-Google-Smtp-Source: ABdhPJxGdZSIAe0s4Jxnk+PVpvMs3ZBFbOCPEtok0rgilR4KUrnSemI/98CPOXIpLv55PQS5gE2lOQ== X-Received: by 2002:a05:6000:14b:: with SMTP id r11mr11328416wrx.124.1589893750321; Tue, 19 May 2020 06:09:10 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id m82sm4097242wmf.3.2020.05.19.06.09.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 May 2020 06:09:09 -0700 (PDT) From: luca.boccassi@gmail.com To: Yunjian Wang Cc: Ferruh Yigit , dpdk stable Date: Tue, 19 May 2020 14:03:19 +0100 Message-Id: <20200519130549.112823-64-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200519130549.112823-1-luca.boccassi@gmail.com> References: <20200519125804.104349-1-luca.boccassi@gmail.com> <20200519130549.112823-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/pfe: fix double free of MAC address' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/21/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 670758fe8b981048653aec28701c3ebf0445775d Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Thu, 9 Apr 2020 09:59:00 +0800 Subject: [PATCH] net/pfe: fix double free of MAC address [ upstream commit 497eb88c14481c262bfb4af3a7d2050d62e35295 ] The 'mac_addrs' freeing has been moved to rte_eth_dev_release_port(), so freeing 'mac_addrs' like this in pfe_eth_exit() is unnecessary and will cause double free. Fixes: 67fc3ff97c39 ("net/pfe: introduce basic functions") Signed-off-by: Yunjian Wang Reviewed-by: Ferruh Yigit --- drivers/net/pfe/pfe_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/pfe/pfe_ethdev.c b/drivers/net/pfe/pfe_ethdev.c index 59b5b8387b..bdf2a7c76a 100644 --- a/drivers/net/pfe/pfe_ethdev.c +++ b/drivers/net/pfe/pfe_ethdev.c @@ -396,7 +396,6 @@ pfe_eth_exit(struct rte_eth_dev *dev, struct pfe *pfe) /* Close the device file for link status */ pfe_eth_close_cdev(dev->data->dev_private); - rte_free(dev->data->mac_addrs); rte_eth_dev_release_port(dev); pfe->nb_devs--; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-19 14:04:47.105279461 +0100 +++ 0064-net-pfe-fix-double-free-of-MAC-address.patch 2020-05-19 14:04:44.220648445 +0100 @@ -1,14 +1,15 @@ -From 497eb88c14481c262bfb4af3a7d2050d62e35295 Mon Sep 17 00:00:00 2001 +From 670758fe8b981048653aec28701c3ebf0445775d Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Thu, 9 Apr 2020 09:59:00 +0800 Subject: [PATCH] net/pfe: fix double free of MAC address +[ upstream commit 497eb88c14481c262bfb4af3a7d2050d62e35295 ] + The 'mac_addrs' freeing has been moved to rte_eth_dev_release_port(), so freeing 'mac_addrs' like this in pfe_eth_exit() is unnecessary and will cause double free. Fixes: 67fc3ff97c39 ("net/pfe: introduce basic functions") -Cc: stable@dpdk.org Signed-off-by: Yunjian Wang Reviewed-by: Ferruh Yigit