patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] net/ixgbe: fix MACsec private API
@ 2020-05-22  5:59 Guinan Sun
  2020-05-22  9:11 ` Ye Xiaolong
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Guinan Sun @ 2020-05-22  5:59 UTC (permalink / raw)
  To: dev; +Cc: Zhao1 Wei, Guinan Sun, stable

The driver type need to be checked in private API.
The patch fixes the issue.

Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting")
Cc: stable@dpdk.org

Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
 drivers/net/ixgbe/rte_pmd_ixgbe.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c b/drivers/net/ixgbe/rte_pmd_ixgbe.c
index 8bcaded6e..9bff557f9 100644
--- a/drivers/net/ixgbe/rte_pmd_ixgbe.c
+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c
@@ -522,6 +522,9 @@ rte_pmd_ixgbe_macsec_enable(uint16_t port, uint8_t en, uint8_t rp)
 
 	dev = &rte_eth_devices[port];
 
+	if (!is_ixgbe_supported(dev))
+		return -ENOTSUP;
+
 	macsec_setting.offload_en = 1;
 	macsec_setting.encrypt_en = en;
 	macsec_setting.replayprotect_en = rp;
@@ -542,6 +545,9 @@ rte_pmd_ixgbe_macsec_disable(uint16_t port)
 
 	dev = &rte_eth_devices[port];
 
+	if (!is_ixgbe_supported(dev))
+		return -ENOTSUP;
+
 	ixgbe_dev_macsec_setting_reset(dev);
 
 	ixgbe_dev_macsec_register_disable(dev);
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [PATCH] net/ixgbe: fix MACsec private API
  2020-05-22  5:59 [dpdk-stable] [PATCH] net/ixgbe: fix MACsec private API Guinan Sun
@ 2020-05-22  9:11 ` Ye Xiaolong
  2020-05-22  9:17 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
  2020-05-22 15:13 ` Ferruh Yigit
  2 siblings, 0 replies; 4+ messages in thread
From: Ye Xiaolong @ 2020-05-22  9:11 UTC (permalink / raw)
  To: Guinan Sun; +Cc: dev, Zhao1 Wei, stable

On 05/22, Guinan Sun wrote:
>The driver type need to be checked in private API.
>The patch fixes the issue.
>
>Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting")
>Cc: stable@dpdk.org
>
>Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
>---
> drivers/net/ixgbe/rte_pmd_ixgbe.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
>diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c b/drivers/net/ixgbe/rte_pmd_ixgbe.c
>index 8bcaded6e..9bff557f9 100644
>--- a/drivers/net/ixgbe/rte_pmd_ixgbe.c
>+++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c
>@@ -522,6 +522,9 @@ rte_pmd_ixgbe_macsec_enable(uint16_t port, uint8_t en, uint8_t rp)
> 
> 	dev = &rte_eth_devices[port];
> 
>+	if (!is_ixgbe_supported(dev))
>+		return -ENOTSUP;
>+
> 	macsec_setting.offload_en = 1;
> 	macsec_setting.encrypt_en = en;
> 	macsec_setting.replayprotect_en = rp;
>@@ -542,6 +545,9 @@ rte_pmd_ixgbe_macsec_disable(uint16_t port)
> 
> 	dev = &rte_eth_devices[port];
> 
>+	if (!is_ixgbe_supported(dev))
>+		return -ENOTSUP;
>+
> 	ixgbe_dev_macsec_setting_reset(dev);
> 
> 	ixgbe_dev_macsec_register_disable(dev);
>-- 
>2.17.1
>

Applied to dpdk-next-net-intel, Thanks.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ixgbe: fix MACsec private API
  2020-05-22  5:59 [dpdk-stable] [PATCH] net/ixgbe: fix MACsec private API Guinan Sun
  2020-05-22  9:11 ` Ye Xiaolong
@ 2020-05-22  9:17 ` " Kevin Traynor
  2020-05-22 15:13 ` Ferruh Yigit
  2 siblings, 0 replies; 4+ messages in thread
From: Kevin Traynor @ 2020-05-22  9:17 UTC (permalink / raw)
  To: Guinan Sun, dev; +Cc: Zhao1 Wei, stable

On 22/05/2020 06:59, Guinan Sun wrote:
> The driver type need to be checked in private API.
> The patch fixes the issue.
> 
> Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> ---
>  drivers/net/ixgbe/rte_pmd_ixgbe.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/net/ixgbe/rte_pmd_ixgbe.c b/drivers/net/ixgbe/rte_pmd_ixgbe.c
> index 8bcaded6e..9bff557f9 100644
> --- a/drivers/net/ixgbe/rte_pmd_ixgbe.c
> +++ b/drivers/net/ixgbe/rte_pmd_ixgbe.c
> @@ -522,6 +522,9 @@ rte_pmd_ixgbe_macsec_enable(uint16_t port, uint8_t en, uint8_t rp)
>  
>  	dev = &rte_eth_devices[port];
>  
> +	if (!is_ixgbe_supported(dev))
> +		return -ENOTSUP;
> +
>  	macsec_setting.offload_en = 1;
>  	macsec_setting.encrypt_en = en;
>  	macsec_setting.replayprotect_en = rp;
> @@ -542,6 +545,9 @@ rte_pmd_ixgbe_macsec_disable(uint16_t port)
>  
>  	dev = &rte_eth_devices[port];
>  
> +	if (!is_ixgbe_supported(dev))
> +		return -ENOTSUP;
> +
>  	ixgbe_dev_macsec_setting_reset(dev);
>  
>  	ixgbe_dev_macsec_register_disable(dev);
> 

Acked-by: Kevin Traynor <ktraynor@redhat.com>


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ixgbe: fix MACsec private API
  2020-05-22  5:59 [dpdk-stable] [PATCH] net/ixgbe: fix MACsec private API Guinan Sun
  2020-05-22  9:11 ` Ye Xiaolong
  2020-05-22  9:17 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
@ 2020-05-22 15:13 ` Ferruh Yigit
  2 siblings, 0 replies; 4+ messages in thread
From: Ferruh Yigit @ 2020-05-22 15:13 UTC (permalink / raw)
  To: Guinan Sun, dev; +Cc: Zhao1 Wei, stable

On 5/22/2020 6:59 AM, Guinan Sun wrote:
> The driver type need to be checked in private API.
> The patch fixes the issue.
> 
> Fixes: 50556c88104c ("net/ixgbe: fix MACsec setting")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-22  5:59 [dpdk-stable] [PATCH] net/ixgbe: fix MACsec private API Guinan Sun
2020-05-22  9:11 ` Ye Xiaolong
2020-05-22  9:17 ` [dpdk-stable] [dpdk-dev] " Kevin Traynor
2020-05-22 15:13 ` Ferruh Yigit

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox