From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1257EA0093 for ; Fri, 22 May 2020 11:41:08 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 07A9F1D966; Fri, 22 May 2020 11:41:08 +0200 (CEST) Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by dpdk.org (Postfix) with ESMTP id 4F99A1D966 for ; Fri, 22 May 2020 11:41:05 +0200 (CEST) Received: by mail-wm1-f67.google.com with SMTP id w64so9165517wmg.4 for ; Fri, 22 May 2020 02:41:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=YQiakh6KVbBJKXjoSOUzblROlqPUnfYfF5ghKH7LsLc=; b=ZTq/DDN+hc08jP/TdOsTnUVXcS0To8qWNXz+ppsVaNK3cM+GlPD38KEpZl+gAJt1u/ RUh4ny7K2RYeNkpgQ/BVmGz6uwAgRO7UzrdHju9saidVKfGo8CWbkThld7DsFNRTvUEA TC/+CIrobLqSELKb/BFznc18fGfvBZwlYdxg0zAyaGI7oSU3roX+KIT2p8sLXywUf7vH ipxLcpNNe2hIBxsXz1XuyD6eG9VH2yuBXblClcSuP8LniXDY8SFuzYJE6rxnGN89Uhfy UfGw+QfvkefuqCzRVFRssIYxEx8a7tzjtG89aYKQYyCT/7Rh6UuAiwJoluTU4JGxhGBk R1Ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=YQiakh6KVbBJKXjoSOUzblROlqPUnfYfF5ghKH7LsLc=; b=WLstc5WHaB1sfz7McqOYRAEafYZXwkxU0xuF7T9PyT9LbJoPI/f/fJPDr3AEsmzO1l odVQS+t7+PB3Gg/yg7+2lFh9XbYGaeUVEw/cD60wSx8X4mhOdnkZO6K3JsqGTugzXt6E 8vbQOBVrF8iY+kKcosU2y+pI/HewwoUMaejRDVEHNdlSgvpq6nPwe0xDYwxrqU2zVUA9 05dPCWjhunDRxDvxfUuEOZ2Gqe0GnhBpMF/REgsK//cF3Hl8eINnDshmyStakvXziD/V oHbWt8z1HWtDUP2LlztwO1J7OR8PeK1lu+TX84YMDLwqoSB2N3eWjmk/6xLnUr4M038i QSvA== X-Gm-Message-State: AOAM531CE6Sphk3HQGzzL1wvyAiiS22+xkQ920zcsCw5rbEXy6Qo7gZw r5x2xOeVA+1r+JcQ7sFQ1j7I0vaPCpw= X-Google-Smtp-Source: ABdhPJxdD8HnryS7vE3zB4YSW8rEvbvo3UAx+omFdH6YhdzmDB1kOtS/oRDbfbtiTQL1yClRZ8jiGQ== X-Received: by 2002:a1c:46c2:: with SMTP id t185mr11860180wma.99.1590140465036; Fri, 22 May 2020 02:41:05 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id t129sm10547744wmg.27.2020.05.22.02.41.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2020 02:41:04 -0700 (PDT) From: luca.boccassi@gmail.com To: Rasesh Mody Cc: Shahed Shaikh , Igor Russkikh , dpdk stable Date: Fri, 22 May 2020 10:39:53 +0100 Message-Id: <20200522094022.1025696-14-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200522094022.1025696-1-luca.boccassi@gmail.com> References: <20200519130549.112823-214-luca.boccassi@gmail.com> <20200522094022.1025696-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/qede: fix link state configuration' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/24/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 4de7d8bc2151a12801432c72df41828d3eab4138 Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Wed, 13 May 2020 21:09:02 -0700 Subject: [PATCH] net/qede: fix link state configuration [ upstream commit d789705873d47d70a3ba0a6a4dfb83fb629d3464 ] Move link state enable/disable to dev_start() and dev_stop() respectively. This will ensure when devices are stopped, link status will be appropriately shown as down. Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") Signed-off-by: Shahed Shaikh Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/qede_ethdev.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index c7a4c031b7..4b3f506506 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1076,6 +1076,9 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev) if (qede_activate_vport(eth_dev, true)) goto err; + /* Bring-up the link */ + qede_dev_set_link_state(eth_dev, true); + /* Update link status */ qede_link_update(eth_dev, 0); @@ -1097,6 +1100,12 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev) PMD_INIT_FUNC_TRACE(edev); + /* Bring the link down */ + qede_dev_set_link_state(eth_dev, false); + + /* Update link status */ + qede_link_update(eth_dev, 0); + /* Disable vport */ if (qede_activate_vport(eth_dev, false)) return; @@ -1481,8 +1490,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev) eth_dev->data->nb_rx_queues = 0; eth_dev->data->nb_tx_queues = 0; - /* Bring the link down */ - qede_dev_set_link_state(eth_dev, false); qdev->ops->common->slowpath_stop(edev); qdev->ops->common->remove(edev); rte_intr_disable(&pci_dev->intr_handle); @@ -2605,9 +2612,6 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) eth_dev->dev_ops = (is_vf) ? &qede_eth_vf_dev_ops : &qede_eth_dev_ops; - /* Bring-up the link */ - qede_dev_set_link_state(eth_dev, true); - adapter->num_tx_queues = 0; adapter->num_rx_queues = 0; SLIST_INIT(&adapter->arfs_info.arfs_list_head); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-22 10:37:39.763972707 +0100 +++ 0014-net-qede-fix-link-state-configuration.patch 2020-05-22 10:37:39.088411997 +0100 @@ -1,14 +1,15 @@ -From d789705873d47d70a3ba0a6a4dfb83fb629d3464 Mon Sep 17 00:00:00 2001 +From 4de7d8bc2151a12801432c72df41828d3eab4138 Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Wed, 13 May 2020 21:09:02 -0700 Subject: [PATCH] net/qede: fix link state configuration +[ upstream commit d789705873d47d70a3ba0a6a4dfb83fb629d3464 ] + Move link state enable/disable to dev_start() and dev_stop() respectively. This will ensure when devices are stopped, link status will be appropriately shown as down. Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") -Cc: stable@dpdk.org Signed-off-by: Shahed Shaikh Signed-off-by: Rasesh Mody @@ -18,10 +19,10 @@ 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c -index e71fa1e6a7..0b1fca9aca 100644 +index c7a4c031b7..4b3f506506 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c -@@ -1144,6 +1144,9 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev) +@@ -1076,6 +1076,9 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev) if (qede_activate_vport(eth_dev, true)) goto err; @@ -31,7 +32,7 @@ /* Update link status */ qede_link_update(eth_dev, 0); -@@ -1166,6 +1169,12 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev) +@@ -1097,6 +1100,12 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev) PMD_INIT_FUNC_TRACE(edev); @@ -44,7 +45,7 @@ /* Disable vport */ if (qede_activate_vport(eth_dev, false)) return; -@@ -1550,8 +1559,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev) +@@ -1481,8 +1490,6 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev) eth_dev->data->nb_rx_queues = 0; eth_dev->data->nb_tx_queues = 0; @@ -53,7 +54,7 @@ qdev->ops->common->slowpath_stop(edev); qdev->ops->common->remove(edev); rte_intr_disable(&pci_dev->intr_handle); -@@ -2672,9 +2679,6 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) +@@ -2605,9 +2612,6 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) eth_dev->dev_ops = (is_vf) ? &qede_eth_vf_dev_ops : &qede_eth_dev_ops;