From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 36824A0093 for ; Fri, 22 May 2020 11:40:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2C6251D969; Fri, 22 May 2020 11:40:36 +0200 (CEST) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 30E0D1D969 for ; Fri, 22 May 2020 11:40:35 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id s8so9494219wrt.9 for ; Fri, 22 May 2020 02:40:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zv3Fo7aETjQcGxiWOABnN7s/ZMtqOwDPu/r8ghlc7dw=; b=RoS8B6rsYKJ4vQGT4q9yfHWTEzIAbBbH5N+02RcCSMlMzaOXTIfaKL1ll7OkG/Wt/G oqqe+jzP0T1O6VFzsVhrZC+5puWQx2amGeo9NPAmcdofmquE56FxnSC4ppR9AXryrJ9G GzoMypLE+RS5VuEQheS94zmJpvr1Bh6QhlrrwboRBF3YOiR0dP4d0M9YpfqzPGbSlxT8 z3oB71+Y1CS0TY0gnYw5PmykF6eFDK9ndDxxIg2WDwPWysVqpe9eR60zmvLBx+Kl6UMW gj/xYholgtMUGmLRMm1loirqprjnbdY5PPnuTd4mXnv9s8v1ATMWVRYHRQAi+5pFKdm7 fFjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zv3Fo7aETjQcGxiWOABnN7s/ZMtqOwDPu/r8ghlc7dw=; b=VR7FH7sgnFSfql6vFyOK3Vjh1nbicox5GadYJVNc+SJ8dTdKo4TLS5BLtOrwyNaUIx aX8hXo4wk5GLrd1ekOHOE+hpXW4OMmCT1aeONd5r2RkiXmjWdwYjQfrhkBrK+v1NwyPy VsyA4lu7sq+hAqZt4namKS08F2xObmYEwn4ZY0o5QiYCTMTu4WosACtY5AUwZzwGdQO3 SRf0LgasKai2Y3UdQwwh6VNbsUXuBHAUpswXWf4L1puplfdPBHRI0xC7iNozPgrpBTBT x3nUqJtSxEQoZhSyk2v7N8jyYYP5qlAd7BOiv7QkrO27qFz0B3QOEjzrWkZbeZ1Dq8FX rz6Q== X-Gm-Message-State: AOAM531n47JbRKbz0cU9hIvZXFFbPrro9NRnzWwndUdfscs4XSdw4fba SgsEOyz7zF99X39JTTTPKhM= X-Google-Smtp-Source: ABdhPJxtNNatpfDT/nYEyr4/3ddiH3AwMgaBB4oPq88ssj9faJVu0AfRtRVPXW7QBJ6R8oAn04+J/g== X-Received: by 2002:adf:ce90:: with SMTP id r16mr2592339wrn.86.1590140434914; Fri, 22 May 2020 02:40:34 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id z9sm8999896wrp.66.2020.05.22.02.40.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2020 02:40:34 -0700 (PDT) From: luca.boccassi@gmail.com To: Kevin Traynor Cc: David Marchand , dpdk stable Date: Fri, 22 May 2020 10:39:44 +0100 Message-Id: <20200522094022.1025696-5-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200522094022.1025696-1-luca.boccassi@gmail.com> References: <20200519130549.112823-214-luca.boccassi@gmail.com> <20200522094022.1025696-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'build: disable gcc 10 zero-length-bounds warning' has been queued to stable release 19.11.3 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 05/24/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From f40d9a3cbbf10a46087ac0835ee41587d9313903 Mon Sep 17 00:00:00 2001 From: Kevin Traynor Date: Thu, 14 May 2020 14:18:57 +0100 Subject: [PATCH] build: disable gcc 10 zero-length-bounds warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit cfacbcb5a23bc26cb913528c372adddabbb33ca1 ] gcc 10 issues warnings about the use of rearm_data marker from struct rte_mbuf. e.g. ../drivers/net/enic/enic_rxtx_vec_avx2.c: In function ‘rx_one’: ../drivers/net/enic/enic_rxtx_vec_avx2.c:21:2: warning: array subscript 0 is outside the bounds of an interior zero-length array ‘RTE_MARKER64’ {aka ‘long unsigned int[0]’} [-Wzero-length-bounds] 21 | *(uint64_t *)&mb->rearm_data = enic->mbuf_initializer; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from ../lib/librte_mbuf/rte_mbuf.h:45, from ../drivers/net/enic/enic_rxtx_vec_avx2.c:6: ../lib/librte_mbuf/rte_mbuf_core.h:484:15: note: while referencing ‘rearm_data’ 484 | RTE_MARKER64 rearm_data; | Disable this warning for gcc 10 in order to allow v20.05 to build without changes to struct rte_mbuf. Bugzilla ID: 396 Signed-off-by: Kevin Traynor Reviewed-by: David Marchand --- config/meson.build | 4 ++++ mk/toolchain/gcc/rte.vars.mk | 5 +++++ 2 files changed, 9 insertions(+) diff --git a/config/meson.build b/config/meson.build index 35ef12e30c..78bfdf3094 100644 --- a/config/meson.build +++ b/config/meson.build @@ -191,6 +191,10 @@ warning_flags = [ '-Wno-packed-not-aligned', '-Wno-missing-field-initializers' ] +if cc.get_id() == 'gcc' and cc.version().version_compare('>=10.0') +# FIXME: Bugzilla 396 + warning_flags += '-Wno-zero-length-bounds' +endif if not dpdk_conf.get('RTE_ARCH_64') # for 32-bit, don't warn about casting a 32-bit pointer to 64-bit int - it's fine!! warning_flags += '-Wno-pointer-to-int-cast' diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk index 9fc704193b..b3473c06fd 100644 --- a/mk/toolchain/gcc/rte.vars.mk +++ b/mk/toolchain/gcc/rte.vars.mk @@ -83,6 +83,11 @@ ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1) WERROR_FLAGS += -Wno-uninitialized endif +ifeq ($(shell test $(GCC_VERSION) -ge 100 && echo 1), 1) +# FIXME: Bugzilla 396 +WERROR_FLAGS += -Wno-zero-length-bounds +endif + HOST_WERROR_FLAGS := $(WERROR_FLAGS) ifeq ($(shell test $(HOST_GCC_VERSION) -gt 70 && echo 1), 1) -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-05-22 10:37:39.433709093 +0100 +++ 0005-build-disable-gcc-10-zero-length-bounds-warning.patch 2020-05-22 10:37:39.060411495 +0100 @@ -1,4 +1,4 @@ -From cfacbcb5a23bc26cb913528c372adddabbb33ca1 Mon Sep 17 00:00:00 2001 +From f40d9a3cbbf10a46087ac0835ee41587d9313903 Mon Sep 17 00:00:00 2001 From: Kevin Traynor Date: Thu, 14 May 2020 14:18:57 +0100 Subject: [PATCH] build: disable gcc 10 zero-length-bounds warning @@ -6,6 +6,8 @@ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit +[ upstream commit cfacbcb5a23bc26cb913528c372adddabbb33ca1 ] + gcc 10 issues warnings about the use of rearm_data marker from struct rte_mbuf. @@ -28,7 +30,6 @@ without changes to struct rte_mbuf. Bugzilla ID: 396 -Cc: stable@dpdk.org Signed-off-by: Kevin Traynor Reviewed-by: David Marchand @@ -38,10 +39,10 @@ 2 files changed, 9 insertions(+) diff --git a/config/meson.build b/config/meson.build -index a1c38c053e..43ab113106 100644 +index 35ef12e30c..78bfdf3094 100644 --- a/config/meson.build +++ b/config/meson.build -@@ -208,6 +208,10 @@ warning_flags = [ +@@ -191,6 +191,10 @@ warning_flags = [ '-Wno-packed-not-aligned', '-Wno-missing-field-initializers' ] @@ -53,10 +54,10 @@ # for 32-bit, don't warn about casting a 32-bit pointer to 64-bit int - it's fine!! warning_flags += '-Wno-pointer-to-int-cast' diff --git a/mk/toolchain/gcc/rte.vars.mk b/mk/toolchain/gcc/rte.vars.mk -index f19305e495..928f0e0830 100644 +index 9fc704193b..b3473c06fd 100644 --- a/mk/toolchain/gcc/rte.vars.mk +++ b/mk/toolchain/gcc/rte.vars.mk -@@ -81,6 +81,11 @@ ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1) +@@ -83,6 +83,11 @@ ifeq ($(shell test $(GCC_VERSION) -lt 47 && echo 1), 1) WERROR_FLAGS += -Wno-uninitialized endif