* Re: [dpdk-stable] [PATCH] net/ice: fix switch action number check
2020-05-21 7:34 [dpdk-stable] [PATCH] net/ice: fix switch action number check Wei Zhao
@ 2020-05-21 8:03 ` Zhao1, Wei
2020-05-21 9:21 ` [dpdk-stable] [dpdk-dev] " Xiao, QimaiX
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Zhao1, Wei @ 2020-05-21 8:03 UTC (permalink / raw)
To: dev; +Cc: stable, Zhang, Qi Z, Ye, Xiaolong, Xiao, QimaiX
add Qimai
> -----Original Message-----
> From: Zhao1, Wei <wei.zhao1@intel.com>
> Sent: Thursday, May 21, 2020 3:34 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Ye, Xiaolong
> <xiaolong.ye@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/ice: fix switch action number check
>
> The action number for switch filter should be 1, any other such as 0 or more
> than 1 is invalid.
>
> Fixes: 3428c6b6ec1f ("net/ice: add action number check for switch")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/ice/ice_switch_filter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_switch_filter.c
> b/drivers/net/ice/ice_switch_filter.c
> index dd3f4847a..20e8187d3 100644
> --- a/drivers/net/ice/ice_switch_filter.c
> +++ b/drivers/net/ice/ice_switch_filter.c
> @@ -1388,7 +1388,7 @@ ice_switch_check_action(const struct
> rte_flow_action *actions,
> }
> }
>
> - if (actions_num > 1) {
> + if (actions_num != 1) {
> rte_flow_error_set(error,
> EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,
> actions,
> --
> 2.19.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/ice: fix switch action number check
2020-05-21 7:34 [dpdk-stable] [PATCH] net/ice: fix switch action number check Wei Zhao
2020-05-21 8:03 ` Zhao1, Wei
@ 2020-05-21 9:21 ` Xiao, QimaiX
2020-05-25 1:50 ` [dpdk-stable] " Ye Xiaolong
2020-05-25 1:53 ` Zhang, Qi Z
3 siblings, 0 replies; 5+ messages in thread
From: Xiao, QimaiX @ 2020-05-21 9:21 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable, Zhang, Qi Z, Ye, Xiaolong, Zhao1, Wei
Tested-by: Xiao, QimaiX <qimaix.xiao@intel.com>
Regards,
Xiao Qimai
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Wei Zhao
> Sent: Thursday, May 21, 2020 3:34 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Ye, Xiaolong
> <xiaolong.ye@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [dpdk-dev] [PATCH] net/ice: fix switch action number check
>
> The action number for switch filter should be 1, any other such as 0 or more
> than 1 is invalid.
>
> Fixes: 3428c6b6ec1f ("net/ice: add action number check for switch")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
> ---
> drivers/net/ice/ice_switch_filter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ice/ice_switch_filter.c
> b/drivers/net/ice/ice_switch_filter.c
> index dd3f4847a..20e8187d3 100644
> --- a/drivers/net/ice/ice_switch_filter.c
> +++ b/drivers/net/ice/ice_switch_filter.c
> @@ -1388,7 +1388,7 @@ ice_switch_check_action(const struct
> rte_flow_action *actions,
> }
> }
>
> - if (actions_num > 1) {
> + if (actions_num != 1) {
> rte_flow_error_set(error,
> EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,
> actions,
> --
> 2.19.1
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-stable] [PATCH] net/ice: fix switch action number check
2020-05-21 7:34 [dpdk-stable] [PATCH] net/ice: fix switch action number check Wei Zhao
2020-05-21 8:03 ` Zhao1, Wei
2020-05-21 9:21 ` [dpdk-stable] [dpdk-dev] " Xiao, QimaiX
@ 2020-05-25 1:50 ` Ye Xiaolong
2020-05-25 1:53 ` Zhang, Qi Z
3 siblings, 0 replies; 5+ messages in thread
From: Ye Xiaolong @ 2020-05-25 1:50 UTC (permalink / raw)
To: Wei Zhao; +Cc: dev, stable, qi.z.zhang
On 05/21, Wei Zhao wrote:
>The action number for switch filter should be 1, any
>other such as 0 or more than 1 is invalid.
>
>Fixes: 3428c6b6ec1f ("net/ice: add action number check for switch")
>Cc: stable@dpdk.org
>
>Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
>---
> drivers/net/ice/ice_switch_filter.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ice/ice_switch_filter.c b/drivers/net/ice/ice_switch_filter.c
>index dd3f4847a..20e8187d3 100644
>--- a/drivers/net/ice/ice_switch_filter.c
>+++ b/drivers/net/ice/ice_switch_filter.c
>@@ -1388,7 +1388,7 @@ ice_switch_check_action(const struct rte_flow_action *actions,
> }
> }
>
>- if (actions_num > 1) {
>+ if (actions_num != 1) {
> rte_flow_error_set(error,
> EINVAL, RTE_FLOW_ERROR_TYPE_ACTION,
> actions,
>--
>2.19.1
>
Applied to dpdk-next-net-intel, Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-stable] [PATCH] net/ice: fix switch action number check
2020-05-21 7:34 [dpdk-stable] [PATCH] net/ice: fix switch action number check Wei Zhao
` (2 preceding siblings ...)
2020-05-25 1:50 ` [dpdk-stable] " Ye Xiaolong
@ 2020-05-25 1:53 ` Zhang, Qi Z
3 siblings, 0 replies; 5+ messages in thread
From: Zhang, Qi Z @ 2020-05-25 1:53 UTC (permalink / raw)
To: Zhao1, Wei, dev; +Cc: stable, Ye, Xiaolong
> -----Original Message-----
> From: Zhao1, Wei <wei.zhao1@intel.com>
> Sent: Thursday, May 21, 2020 3:34 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Ye, Xiaolong
> <xiaolong.ye@intel.com>; Zhao1, Wei <wei.zhao1@intel.com>
> Subject: [PATCH] net/ice: fix switch action number check
>
> The action number for switch filter should be 1, any other such as 0 or more
> than 1 is invalid.
>
> Fixes: 3428c6b6ec1f ("net/ice: add action number check for switch")
> Cc: stable@dpdk.org
>
> Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread