* [dpdk-stable] [PATCH 01/37] bus/fslmc: fix getting the FD error [not found] <20200527132326.1382-1-hemant.agrawal@nxp.com> @ 2020-05-27 13:22 ` Hemant Agrawal 2020-05-27 18:07 ` [dpdk-stable] [dpdk-dev] " Akhil Goyal 2020-05-27 13:22 ` [dpdk-stable] [PATCH 02/37] net/dpaa: fix fd offset data type Hemant Agrawal [not found] ` <20200707092244.12791-1-hemant.agrawal@nxp.com> 2 siblings, 1 reply; 6+ messages in thread From: Hemant Agrawal @ 2020-05-27 13:22 UTC (permalink / raw) To: dev, ferruh.yigit; +Cc: stable, Nipun Gupta From: Nipun Gupta <nipun.gupta@nxp.com> Fix the incorrect register for getting error Fixes: 03e36408b9fb ("bus/fslmc: add macros required by QDMA for FLE and FD") Cc: stable@dpdk.org Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com> --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h index 4682a5299..f1c70251a 100644 --- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h +++ b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h @@ -286,7 +286,7 @@ enum qbman_fd_format { #define DPAA2_GET_FD_FRC(fd) ((fd)->simple.frc) #define DPAA2_GET_FD_FLC(fd) \ (((uint64_t)((fd)->simple.flc_hi) << 32) + (fd)->simple.flc_lo) -#define DPAA2_GET_FD_ERR(fd) ((fd)->simple.bpid_offset & 0x000000FF) +#define DPAA2_GET_FD_ERR(fd) ((fd)->simple.ctrl & 0x000000FF) #define DPAA2_GET_FLE_OFFSET(fle) (((fle)->fin_bpid_offset & 0x0FFF0000) >> 16) #define DPAA2_SET_FLE_SG_EXT(fle) ((fle)->fin_bpid_offset |= (uint64_t)1 << 29) #define DPAA2_IS_SET_FLE_SG_EXT(fle) \ -- 2.17.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 01/37] bus/fslmc: fix getting the FD error 2020-05-27 13:22 ` [dpdk-stable] [PATCH 01/37] bus/fslmc: fix getting the FD error Hemant Agrawal @ 2020-05-27 18:07 ` Akhil Goyal 0 siblings, 0 replies; 6+ messages in thread From: Akhil Goyal @ 2020-05-27 18:07 UTC (permalink / raw) To: Hemant Agrawal, dev, ferruh.yigit; +Cc: stable, Nipun Gupta > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Hemant Agrawal > Sent: Wednesday, May 27, 2020 6:53 PM > To: dev@dpdk.org; ferruh.yigit@intel.com > Cc: stable@dpdk.org; Nipun Gupta <nipun.gupta@nxp.com> > Subject: [dpdk-dev] [PATCH 01/37] bus/fslmc: fix getting the FD error > > From: Nipun Gupta <nipun.gupta@nxp.com> > > Fix the incorrect register for getting error > > Fixes: 03e36408b9fb ("bus/fslmc: add macros required by QDMA for FLE and FD") > Cc: stable@dpdk.org > > Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com> > --- Acked-by: Akhil Goyal <akhil.goyal@nxp.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH 02/37] net/dpaa: fix fd offset data type [not found] <20200527132326.1382-1-hemant.agrawal@nxp.com> 2020-05-27 13:22 ` [dpdk-stable] [PATCH 01/37] bus/fslmc: fix getting the FD error Hemant Agrawal @ 2020-05-27 13:22 ` Hemant Agrawal 2020-05-27 18:08 ` [dpdk-stable] [dpdk-dev] " Akhil Goyal [not found] ` <20200707092244.12791-1-hemant.agrawal@nxp.com> 2 siblings, 1 reply; 6+ messages in thread From: Hemant Agrawal @ 2020-05-27 13:22 UTC (permalink / raw) To: dev, ferruh.yigit; +Cc: stable, Nipun Gupta From: Nipun Gupta <nipun.gupta@nxp.com> On DPAA fd offset is 9 bits, but we are using uint8_t in the SG case. This patch fixes the same. Fixes: 8cffdcbe85aa ("net/dpaa: support scattered Rx") Cc: stable@dpdk.org Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com> --- drivers/net/dpaa/dpaa_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c index 5dba1db8b..3aeecb7d2 100644 --- a/drivers/net/dpaa/dpaa_rxtx.c +++ b/drivers/net/dpaa/dpaa_rxtx.c @@ -305,7 +305,7 @@ dpaa_eth_sg_to_mbuf(const struct qm_fd *fd, uint32_t ifid) struct qm_sg_entry *sgt, *sg_temp; void *vaddr, *sg_vaddr; int i = 0; - uint8_t fd_offset = fd->offset; + uint16_t fd_offset = fd->offset; vaddr = DPAA_MEMPOOL_PTOV(bp_info, qm_fd_addr(fd)); if (!vaddr) { -- 2.17.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH 02/37] net/dpaa: fix fd offset data type 2020-05-27 13:22 ` [dpdk-stable] [PATCH 02/37] net/dpaa: fix fd offset data type Hemant Agrawal @ 2020-05-27 18:08 ` Akhil Goyal 0 siblings, 0 replies; 6+ messages in thread From: Akhil Goyal @ 2020-05-27 18:08 UTC (permalink / raw) To: Hemant Agrawal, dev, ferruh.yigit; +Cc: stable, Nipun Gupta > From: Nipun Gupta <nipun.gupta@nxp.com> > > On DPAA fd offset is 9 bits, but we are using uint8_t in the > SG case. This patch fixes the same. > Fixes: 8cffdcbe85aa ("net/dpaa: support scattered Rx") > Cc: stable@dpdk.org > > Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com> > --- Acked-by: Akhil Goyal <akhil.goyal@nxp.com> ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <20200707092244.12791-1-hemant.agrawal@nxp.com>]
* [dpdk-stable] [PATCH v2 01/29] bus/fslmc: fix getting the FD error [not found] ` <20200707092244.12791-1-hemant.agrawal@nxp.com> @ 2020-07-07 9:22 ` Hemant Agrawal 2020-07-07 9:22 ` [dpdk-stable] [PATCH v2 02/29] net/dpaa: fix fd offset data type Hemant Agrawal 1 sibling, 0 replies; 6+ messages in thread From: Hemant Agrawal @ 2020-07-07 9:22 UTC (permalink / raw) To: dev; +Cc: ferruh.yigit, stable, Nipun Gupta From: Nipun Gupta <nipun.gupta@nxp.com> Fix the incorrect register for getting error Fixes: 03e36408b9fb ("bus/fslmc: add macros required by QDMA for FLE and FD") Cc: stable@dpdk.org Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com> Acked-by: Akhil Goyal <akhil.goyal@nxp.com> --- drivers/bus/fslmc/portal/dpaa2_hw_pvt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h index 4682a5299..f1c70251a 100644 --- a/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h +++ b/drivers/bus/fslmc/portal/dpaa2_hw_pvt.h @@ -286,7 +286,7 @@ enum qbman_fd_format { #define DPAA2_GET_FD_FRC(fd) ((fd)->simple.frc) #define DPAA2_GET_FD_FLC(fd) \ (((uint64_t)((fd)->simple.flc_hi) << 32) + (fd)->simple.flc_lo) -#define DPAA2_GET_FD_ERR(fd) ((fd)->simple.bpid_offset & 0x000000FF) +#define DPAA2_GET_FD_ERR(fd) ((fd)->simple.ctrl & 0x000000FF) #define DPAA2_GET_FLE_OFFSET(fle) (((fle)->fin_bpid_offset & 0x0FFF0000) >> 16) #define DPAA2_SET_FLE_SG_EXT(fle) ((fle)->fin_bpid_offset |= (uint64_t)1 << 29) #define DPAA2_IS_SET_FLE_SG_EXT(fle) \ -- 2.17.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
* [dpdk-stable] [PATCH v2 02/29] net/dpaa: fix fd offset data type [not found] ` <20200707092244.12791-1-hemant.agrawal@nxp.com> 2020-07-07 9:22 ` [dpdk-stable] [PATCH v2 01/29] bus/fslmc: fix getting the FD error Hemant Agrawal @ 2020-07-07 9:22 ` Hemant Agrawal 1 sibling, 0 replies; 6+ messages in thread From: Hemant Agrawal @ 2020-07-07 9:22 UTC (permalink / raw) To: dev; +Cc: ferruh.yigit, stable, Nipun Gupta From: Nipun Gupta <nipun.gupta@nxp.com> On DPAA fd offset is 9 bits, but we are using uint8_t in the SG case. This patch fixes the same. Fixes: 8cffdcbe85aa ("net/dpaa: support scattered Rx") Cc: stable@dpdk.org Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com> Acked-by: Akhil Goyal <akhil.goyal@nxp.com> --- drivers/net/dpaa/dpaa_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dpaa/dpaa_rxtx.c b/drivers/net/dpaa/dpaa_rxtx.c index 5dba1db8b..3aeecb7d2 100644 --- a/drivers/net/dpaa/dpaa_rxtx.c +++ b/drivers/net/dpaa/dpaa_rxtx.c @@ -305,7 +305,7 @@ dpaa_eth_sg_to_mbuf(const struct qm_fd *fd, uint32_t ifid) struct qm_sg_entry *sgt, *sg_temp; void *vaddr, *sg_vaddr; int i = 0; - uint8_t fd_offset = fd->offset; + uint16_t fd_offset = fd->offset; vaddr = DPAA_MEMPOOL_PTOV(bp_info, qm_fd_addr(fd)); if (!vaddr) { -- 2.17.1 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-07-07 9:27 UTC | newest] Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- [not found] <20200527132326.1382-1-hemant.agrawal@nxp.com> 2020-05-27 13:22 ` [dpdk-stable] [PATCH 01/37] bus/fslmc: fix getting the FD error Hemant Agrawal 2020-05-27 18:07 ` [dpdk-stable] [dpdk-dev] " Akhil Goyal 2020-05-27 13:22 ` [dpdk-stable] [PATCH 02/37] net/dpaa: fix fd offset data type Hemant Agrawal 2020-05-27 18:08 ` [dpdk-stable] [dpdk-dev] " Akhil Goyal [not found] ` <20200707092244.12791-1-hemant.agrawal@nxp.com> 2020-07-07 9:22 ` [dpdk-stable] [PATCH v2 01/29] bus/fslmc: fix getting the FD error Hemant Agrawal 2020-07-07 9:22 ` [dpdk-stable] [PATCH v2 02/29] net/dpaa: fix fd offset data type Hemant Agrawal
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).