From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED88DA04A3 for ; Fri, 5 Jun 2020 20:27:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E47A31D515; Fri, 5 Jun 2020 20:27:06 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id EC3B81D530 for ; Fri, 5 Jun 2020 20:27:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591381625; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v/zaJgYpVPlEgG0WQncLGl18YN7N4fd9u65EqSdjAzU=; b=QHNCic2f4sP+dfASX0i56h/LPGnXhwDnk9ADgL96mYd/v7KwWhUpHvUlck1XzKQgDJx8eF 4Jn8mIikrgPon2VtG+nBh1ULreIBX9Z+TpeMaO+X6CVyVf6YudmW37B2sEJx0XIzpAhoMD lfri7hplC0GAMqiSLl6jSgmgkIePYWI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-329-yO2Hw3LbO7-jBZook5l0_Q-1; Fri, 05 Jun 2020 14:27:02 -0400 X-MC-Unique: yO2Hw3LbO7-jBZook5l0_Q-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 415E518A8227; Fri, 5 Jun 2020 18:27:01 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5B5CC60C47; Fri, 5 Jun 2020 18:27:00 +0000 (UTC) From: Kevin Traynor To: Rohit Raj Cc: Hemant Agrawal , dpdk stable Date: Fri, 5 Jun 2020 19:24:38 +0100 Message-Id: <20200605182525.22483-41-ktraynor@redhat.com> In-Reply-To: <20200605182525.22483-1-ktraynor@redhat.com> References: <20200605182525.22483-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/dpaa2: fix 10G port negotiation' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/10/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/d2a2e4d347c293888a070a5e3f6e267cd914e525 Thanks. Kevin. --- >From d2a2e4d347c293888a070a5e3f6e267cd914e525 Mon Sep 17 00:00:00 2001 From: Rohit Raj Date: Fri, 8 May 2020 18:32:03 +0530 Subject: [PATCH] net/dpaa2: fix 10G port negotiation [ upstream commit 7e6ecac281e4571d942889d6de687bb87623899b ] Fixed 10G port negotiation issue with another 10G/non 10G port. When running testpmd with 10G interfaces on 10BaseT interface on LS2088ARDB, the ports were showing link as down. This was identified to be caused by the setting of link as down during config. Also, the line rate was not being updated in device link params, thus having the incorrect link speed in status (as 0). Fixes: c5acbb5ea20e ("net/dpaa2: support link status event") Signed-off-by: Rohit Raj Acked-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index e50467285e..c801d922cf 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -437,7 +437,4 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev) dpaa2_vlan_offload_set(dev, ETH_VLAN_FILTER_MASK); - /* update the current status */ - dpaa2_dev_link_update(dev, 0); - return 0; } @@ -1481,4 +1478,5 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev) dev->tx_pkt_burst = dpaa2_dev_tx; dev->data->dev_link.link_status = state.up; + dev->data->dev_link.link_speed = state.rate; if (state.up) -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-06-05 19:20:53.102357569 +0100 +++ 0041-net-dpaa2-fix-10G-port-negotiation.patch 2020-06-05 19:20:50.819040609 +0100 @@ -1 +1 @@ -From 7e6ecac281e4571d942889d6de687bb87623899b Mon Sep 17 00:00:00 2001 +From d2a2e4d347c293888a070a5e3f6e267cd914e525 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7e6ecac281e4571d942889d6de687bb87623899b ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index 2cde55e7cc..4fc550a885 100644 +index e50467285e..c801d922cf 100644 @@ -29 +30 @@ -@@ -554,7 +554,4 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev) +@@ -437,7 +437,4 @@ dpaa2_eth_dev_configure(struct rte_eth_dev *dev) @@ -37 +38 @@ -@@ -1758,4 +1755,5 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev) +@@ -1481,4 +1478,5 @@ dpaa2_dev_set_link_up(struct rte_eth_dev *dev)