From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8A4BFA04A3 for ; Fri, 5 Jun 2020 20:27:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7CC821D51A; Fri, 5 Jun 2020 20:27:13 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 437861D538 for ; Fri, 5 Jun 2020 20:27:12 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591381631; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=v6sSDoToin9R0ZEXcTvWVRyZkR5/fo2oKi2+2V3lO0k=; b=VANi112O8RCXntFcB71e4ZoH79hWFjOx6WHId77WOl2kobk0bm1S5a2fl+kdi8MFrM+jRm BzPeqd7Cn6YX2b5egy3Yu9e/FYxgPszqzMJIcMjZ3aVs1p9NmjLRTYLv6WlqegOvhDfGin KmiQEpZ584USl+9sICVT/aVitDUajv0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-212-l-AWNVLxM0uqtscrSNp2uw-1; Fri, 05 Jun 2020 14:27:08 -0400 X-MC-Unique: l-AWNVLxM0uqtscrSNp2uw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 286421005510; Fri, 5 Jun 2020 18:27:07 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4592C60C47; Fri, 5 Jun 2020 18:27:06 +0000 (UTC) From: Kevin Traynor To: Alexander Kozyrev Cc: Matan Azrad , dpdk stable Date: Fri, 5 Jun 2020 19:24:43 +0100 Message-Id: <20200605182525.22483-46-ktraynor@redhat.com> In-Reply-To: <20200605182525.22483-1-ktraynor@redhat.com> References: <20200605182525.22483-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/mlx5: fix Tx queue release debug log timing' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/10/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/9d406e92ccf555d396653466d23ab7175bee2e05 Thanks. Kevin. --- >From 9d406e92ccf555d396653466d23ab7175bee2e05 Mon Sep 17 00:00:00 2001 From: Alexander Kozyrev Date: Wed, 6 May 2020 18:10:59 +0000 Subject: [PATCH] net/mlx5: fix Tx queue release debug log timing [ upstream commit 776aec28fc47dbf29466555b34cd79ab9cf7a7bc ] Program received signal SIGSEGV, Segmentation fault. 0x00000000008ef7c4 in mlx5_tx_queue_release (dpdk_txq=0x17ce01680) at drivers/net/mlx5/mlx5_txq.c:302 301 mlx5_txq_release(ETH_DEV(priv), i); 302 DRV_LOG(DEBUG, "port %u removing Tx queue %u from list", 303 PORT_ID(priv), txq->idx); The problem is txq is freed inside the mlx5_txq_release() function and no longer valid in the debug log right after this invocation. Move the debug log before the mlx5_txq_release() function to fix this. Fixes: a6d83b6a9209 ("net/mlx5: standardize on negative errno values") Signed-off-by: Alexander Kozyrev Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_txq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_txq.c b/drivers/net/mlx5/mlx5_txq.c index e6020fbcbf..7ee036f97a 100644 --- a/drivers/net/mlx5/mlx5_txq.c +++ b/drivers/net/mlx5/mlx5_txq.c @@ -224,7 +224,7 @@ mlx5_tx_queue_release(void *dpdk_txq) for (i = 0; (i != priv->txqs_n); ++i) if ((*priv->txqs)[i] == txq) { - mlx5_txq_release(ETH_DEV(priv), i); DRV_LOG(DEBUG, "port %u removing Tx queue %u from list", PORT_ID(priv), txq_ctrl->idx); + mlx5_txq_release(ETH_DEV(priv), i); break; } -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-06-05 19:20:53.350474765 +0100 +++ 0046-net-mlx5-fix-Tx-queue-release-debug-log-timing.patch 2020-06-05 19:20:50.825040472 +0100 @@ -1 +1 @@ -From 776aec28fc47dbf29466555b34cd79ab9cf7a7bc Mon Sep 17 00:00:00 2001 +From 9d406e92ccf555d396653466d23ab7175bee2e05 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 776aec28fc47dbf29466555b34cd79ab9cf7a7bc ] + @@ -17 +18,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index 29e5cabab6..a211fa91b2 100644 +index e6020fbcbf..7ee036f97a 100644 @@ -29 +30 @@ -@@ -299,7 +299,7 @@ mlx5_tx_queue_release(void *dpdk_txq) +@@ -224,7 +224,7 @@ mlx5_tx_queue_release(void *dpdk_txq) @@ -34 +35 @@ - PORT_ID(priv), txq->idx); + PORT_ID(priv), txq_ctrl->idx);