From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E6034A04A3 for ; Fri, 5 Jun 2020 20:27:17 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CBD541D547; Fri, 5 Jun 2020 20:27:17 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 0A0CF1D510 for ; Fri, 5 Jun 2020 20:27:16 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591381636; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SSVDYlKFJLIqc8xbZPUbyyqMwIdw0RVVo7az6Lcf7kk=; b=gEaj5k3Zs2TTSqZqtZnoEBHi08jtEr9yZBDaUVTvPHfTQpPICVIruEo4jltbtuamUBY6wA OrJQMJSKRF/jaDNNJquRiB5SspWKDTG5CIHTSk5Bc7sQaQASqaSBtpBQQhlV1TLl2usnPv trMWVtxkCTWhgL7g/b+n9eHRgPlDr+c= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-40-WzYE9TFONBGx7v8ia6bUZg-1; Fri, 05 Jun 2020 14:27:13 -0400 X-MC-Unique: WzYE9TFONBGx7v8ia6bUZg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A0D6918A8223; Fri, 5 Jun 2020 18:27:12 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id BE77061983; Fri, 5 Jun 2020 18:27:11 +0000 (UTC) From: Kevin Traynor To: Pavan Nikhilesh Cc: Jerin Jacob , dpdk stable Date: Fri, 5 Jun 2020 19:24:47 +0100 Message-Id: <20200605182525.22483-50-ktraynor@redhat.com> In-Reply-To: <20200605182525.22483-1-ktraynor@redhat.com> References: <20200605182525.22483-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/eventdev: check Tx adapter service ID' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/10/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/055173ee37ae10860d2c6ce432650c38cdbc2bb0 Thanks. Kevin. --- >From 055173ee37ae10860d2c6ce432650c38cdbc2bb0 Mon Sep 17 00:00:00 2001 From: Pavan Nikhilesh Date: Thu, 14 May 2020 01:52:48 +0530 Subject: [PATCH] app/eventdev: check Tx adapter service ID [ upstream commit 40984bf253e1bccea72a38b2a0edd7c16ea22831 ] Fix unchecked return values reported by coverity. Coverity issue: 357755 Fixes: 032a965a8f1d ("app/eventdev: support Tx adapter") Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob --- app/test-eventdev/test_pipeline_common.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c index c988da28c9..b586804090 100644 --- a/app/test-eventdev/test_pipeline_common.c +++ b/app/test-eventdev/test_pipeline_common.c @@ -367,10 +367,14 @@ pipeline_event_tx_adapter_setup(struct evt_options *opt, uint32_t service_id; - rte_event_eth_tx_adapter_service_id_get(consm, - &service_id); + ret = rte_event_eth_tx_adapter_service_id_get(consm, + &service_id); + if (ret != -ESRCH && ret != 0) { + evt_err("Failed to get Tx adptr service ID"); + return ret; + } ret = evt_service_setup(service_id); if (ret) { evt_err("Failed to setup service core" - " for Tx adapter\n"); + " for Tx adapter"); return ret; } -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-06-05 19:20:53.573236910 +0100 +++ 0050-app-eventdev-check-Tx-adapter-service-ID.patch 2020-06-05 19:20:50.854039814 +0100 @@ -1 +1 @@ -From 40984bf253e1bccea72a38b2a0edd7c16ea22831 Mon Sep 17 00:00:00 2001 +From 055173ee37ae10860d2c6ce432650c38cdbc2bb0 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 40984bf253e1bccea72a38b2a0edd7c16ea22831 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index 84c42b33ce..17088b1b48 100644 +index c988da28c9..b586804090 100644 @@ -22,2 +23,2 @@ -@@ -393,10 +393,14 @@ pipeline_event_tx_adapter_setup(struct evt_options *opt, - uint32_t service_id = -1U; +@@ -367,10 +367,14 @@ pipeline_event_tx_adapter_setup(struct evt_options *opt, + uint32_t service_id;