From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F783A04A3 for ; Fri, 5 Jun 2020 20:27:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 56D5E1D519; Fri, 5 Jun 2020 20:27:32 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id CE3D81D510 for ; Fri, 5 Jun 2020 20:27:30 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591381650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8kpkO14n9bgKeIo7vw6jMhGxj8XmEP4KLsvDqCipDLw=; b=FencYpQ/kyt+bqKJImk2Izk5nZfQABTfb3ViXIAIo7mEVdfIvDXoTv0cCfCK/E8/Eywy17 q3phJWSqiudpJALu7tSFm7ZjAV2Fq0zGs4M56ZVfYHPfyacyn6EK98/UvGo7X6VvQDyIs8 iabwT2qmihH9NzJ0uV2SnJ7EC2ywo2U= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-8-jesBp9sUO1mtkYL9ae_e6A-1; Fri, 05 Jun 2020 14:27:26 -0400 X-MC-Unique: jesBp9sUO1mtkYL9ae_e6A-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3DEF4107ACCA; Fri, 5 Jun 2020 18:27:25 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id 319FE60C47; Fri, 5 Jun 2020 18:27:24 +0000 (UTC) From: Kevin Traynor To: Rasesh Mody Cc: Shahed Shaikh , Igor Russkikh , dpdk stable Date: Fri, 5 Jun 2020 19:24:55 +0100 Message-Id: <20200605182525.22483-58-ktraynor@redhat.com> In-Reply-To: <20200605182525.22483-1-ktraynor@redhat.com> References: <20200605182525.22483-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/qede: fix link state configuration' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/10/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/464774735cbd1937307fa579c2c1a76530194200 Thanks. Kevin. --- >From 464774735cbd1937307fa579c2c1a76530194200 Mon Sep 17 00:00:00 2001 From: Rasesh Mody Date: Wed, 13 May 2020 21:09:02 -0700 Subject: [PATCH] net/qede: fix link state configuration [ upstream commit d789705873d47d70a3ba0a6a4dfb83fb629d3464 ] Move link state enable/disable to dev_start() and dev_stop() respectively. This will ensure when devices are stopped, link status will be appropriately shown as down. Fixes: dd28bc8c6ef4 ("net/qede: fix VF port creation sequence") Signed-off-by: Shahed Shaikh Signed-off-by: Rasesh Mody Signed-off-by: Igor Russkikh --- drivers/net/qede/qede_ethdev.c | 14 +++++++++----- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 791556dc52..340c35a1be 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -1059,4 +1059,7 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev) goto err; + /* Bring-up the link */ + qede_dev_set_link_state(eth_dev, true); + /* Update link status */ qede_link_update(eth_dev, 0); @@ -1080,4 +1083,10 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev) PMD_INIT_FUNC_TRACE(edev); + /* Bring the link down */ + qede_dev_set_link_state(eth_dev, false); + + /* Update link status */ + qede_link_update(eth_dev, 0); + /* Disable vport */ if (qede_activate_vport(eth_dev, false)) @@ -1452,6 +1461,4 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev) eth_dev->data->nb_tx_queues = 0; - /* Bring the link down */ - qede_dev_set_link_state(eth_dev, false); qdev->ops->common->slowpath_stop(edev); qdev->ops->common->remove(edev); @@ -2552,7 +2559,4 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) } - /* Bring-up the link */ - qede_dev_set_link_state(eth_dev, true); - adapter->num_tx_queues = 0; adapter->num_rx_queues = 0; -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-06-05 19:20:53.995381414 +0100 +++ 0058-net-qede-fix-link-state-configuration.patch 2020-06-05 19:20:50.879039246 +0100 @@ -1 +1 @@ -From d789705873d47d70a3ba0a6a4dfb83fb629d3464 Mon Sep 17 00:00:00 2001 +From 464774735cbd1937307fa579c2c1a76530194200 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit d789705873d47d70a3ba0a6a4dfb83fb629d3464 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index e71fa1e6a7..0b1fca9aca 100644 +index 791556dc52..340c35a1be 100644 @@ -24 +25 @@ -@@ -1145,4 +1145,7 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev) +@@ -1059,4 +1059,7 @@ static int qede_dev_start(struct rte_eth_dev *eth_dev) @@ -32 +33 @@ -@@ -1167,4 +1170,10 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev) +@@ -1080,4 +1083,10 @@ static void qede_dev_stop(struct rte_eth_dev *eth_dev) @@ -43 +44 @@ -@@ -1551,6 +1560,4 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev) +@@ -1452,6 +1461,4 @@ static void qede_dev_close(struct rte_eth_dev *eth_dev) @@ -50,2 +51,2 @@ -@@ -2673,7 +2680,4 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) - eth_dev->dev_ops = (is_vf) ? &qede_eth_vf_dev_ops : &qede_eth_dev_ops; +@@ -2552,7 +2559,4 @@ static int qede_common_dev_init(struct rte_eth_dev *eth_dev, bool is_vf) + }