From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E8AC2A04A3 for ; Fri, 5 Jun 2020 20:27:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C01E91D54D; Fri, 5 Jun 2020 20:27:36 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id D250F1D518 for ; Fri, 5 Jun 2020 20:27:34 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591381653; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jvRBQKPBsCymfMF0Dx4h69I70LchOBpbZQNEejtFitM=; b=ZIsx5mLmi5RaXN8eqLh50xkot8t/FFF/Fcsbz+OqEfJ+NTnkee33bHIccgeTDVuIMr8U/t VGle169YyOqeyGh8TDs8B9bSSoD6g6YhDvR9vDK3chs2wZC7YG3h8HZIjguGJL1fI9VRWM 1sZOgExKX27azU9zfKv2UBQjGAFlw6I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-405-R90ZIAyjMl6ObrR3qjGKQQ-1; Fri, 05 Jun 2020 14:27:30 -0400 X-MC-Unique: R90ZIAyjMl6ObrR3qjGKQQ-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 17E19835B8F; Fri, 5 Jun 2020 18:27:29 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0C1EF60C47; Fri, 5 Jun 2020 18:27:27 +0000 (UTC) From: Kevin Traynor To: Ajit Khaparde Cc: Somnath Kotur , Kalesh AP , dpdk stable Date: Fri, 5 Jun 2020 19:24:58 +0100 Message-Id: <20200605182525.22483-61-ktraynor@redhat.com> In-Reply-To: <20200605182525.22483-1-ktraynor@redhat.com> References: <20200605182525.22483-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/bnxt: fix error log for command timeout' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/10/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/ba4ca794ad3c71244d01d2a4b928b668135d72a2 Thanks. Kevin. --- >From ba4ca794ad3c71244d01d2a4b928b668135d72a2 Mon Sep 17 00:00:00 2001 From: Ajit Khaparde Date: Thu, 14 May 2020 23:37:34 -0700 Subject: [PATCH] net/bnxt: fix error log for command timeout [ upstream commit 4939f374ad369b4b15ba17a186bd17bf736371f0 ] Log the command sequence number to aid debug in case of a FW command timeout. Fixes: 804e746c7b73 ("net/bnxt: add hardware resource manager init code") Signed-off-by: Ajit Khaparde Reviewed-by: Somnath Kotur Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt_hwrm.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 6e6d47751e..cfb4cb63ad 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -142,6 +142,7 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, if (i >= timeout) { - PMD_DRV_LOG(ERR, "Error(timeout) sending msg 0x%04x\n", - req->req_type); + PMD_DRV_LOG(ERR, + "Error(timeout) sending msg 0x%04x, seq_id %d\n", + req->req_type, req->seq_id); return -ETIMEDOUT; } -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-06-05 19:20:54.150493312 +0100 +++ 0061-net-bnxt-fix-error-log-for-command-timeout.patch 2020-06-05 19:20:50.889039018 +0100 @@ -1 +1 @@ -From 4939f374ad369b4b15ba17a186bd17bf736371f0 Mon Sep 17 00:00:00 2001 +From ba4ca794ad3c71244d01d2a4b928b668135d72a2 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4939f374ad369b4b15ba17a186bd17bf736371f0 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 77a911067e..d80d67a2d5 100644 +index 6e6d47751e..cfb4cb63ad 100644 @@ -23,2 +24 @@ -@@ -165,6 +165,7 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, - return -ETIMEDOUT; +@@ -142,6 +142,7 @@ static int bnxt_hwrm_send_message(struct bnxt *bp, void *msg, @@ -25,0 +26 @@ + if (i >= timeout) {