From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A0C1CA04A3 for ; Fri, 5 Jun 2020 20:28:09 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7F96C1D515; Fri, 5 Jun 2020 20:28:09 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id D015E1D58A for ; Fri, 5 Jun 2020 20:28:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1591381687; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5g/N570dTNT8XBptbcUQSbFwkRhZ7/BgNPjTnca6sgA=; b=Yra4AkCmBeESQZO1Ta+xP3kNNAyIhoqmVZH9B7nB26+GZRNQM/C9HagjgFzuMbekM/oxGh GkQniKqMD03E51IkdhEXRzcOYuzrVHjTISnkK1s09H/uBkm6pjIA8RFUxGTjKFz6uxwBKH rU53BmOluQgVBRkVuFG7WJOHh2oFuz4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-28-2TIvIbRDPzmbvlV7DQFTjw-1; Fri, 05 Jun 2020 14:28:03 -0400 X-MC-Unique: 2TIvIbRDPzmbvlV7DQFTjw-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 3AA64835B8C; Fri, 5 Jun 2020 18:28:02 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5930760C47; Fri, 5 Jun 2020 18:28:01 +0000 (UTC) From: Kevin Traynor To: Jasvinder Singh Cc: Cristian Dumitrescu , dpdk stable Date: Fri, 5 Jun 2020 19:25:21 +0100 Message-Id: <20200605182525.22483-84-ktraynor@redhat.com> In-Reply-To: <20200605182525.22483-1-ktraynor@redhat.com> References: <20200605182525.22483-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'examples/ip_pipeline: remove check of null response' has been queued to LTS release 18.11.9 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 06/10/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/fc250052402d70045eaf9e26b8be58de01be36c0 Thanks. Kevin. --- >From fc250052402d70045eaf9e26b8be58de01be36c0 Mon Sep 17 00:00:00 2001 From: Jasvinder Singh Date: Mon, 27 Apr 2020 17:56:49 +0100 Subject: [PATCH] examples/ip_pipeline: remove check of null response [ upstream commit 358eb13389070b34809f478678351ab99f813e5b ] For sending request messages to data plane threads, the caller invokes *_msg_send_recv() functions which never return null response. Thus, removed redundant check on the returned response. Coverity issue: 357750, 357740, 357749, 357758, 357702, 357736 Coverity issue: 357679, 357791, 357738, 357778, 357716, 357705 Coverity issue: 357776, 357753, 357729, 357735, 357773, 357723 Fixes: 32e5d9b154cb ("examples/ip_pipeline: add enable and disable commands") Fixes: 50e73d051806 ("examples/ip_pipeline: add stats read commands") Fixes: 6b1b3c3c9d30 ("examples/ip_pipeline: add port enable and disable commands") Fixes: a3a95b7d58b9 ("examples/ip_pipeline: add table entry commands") Fixes: 3186282f8e12 ("examples/ip_pipeline: add table bulk add command") Fixes: f634e4c5698a ("examples/ip_pipeline: add table entry delete command") Fixes: c64b9121a963 ("examples/ip_pipeline: add table entry stats command") Fixes: 7e11393e40ef ("examples/ip_pipeline: add meter profile commands") Fixes: e92058d604e6 ("examples/ip_pipeline: add meter stats command") Fixes: 2b82ef4861c0 ("examples/ip_pipeline: add DSCP table update command") Fixes: d0d306c7f2a1 ("examples/ip_pipeline: add TTL stats command") Fixes: a3169ee5ec59 ("examples/ip_pipeline: support rule time read") Signed-off-by: Jasvinder Singh Acked-by: Cristian Dumitrescu --- examples/ip_pipeline/thread.c | 44 ----------------------------------- 1 file changed, 44 deletions(-) diff --git a/examples/ip_pipeline/thread.c b/examples/ip_pipeline/thread.c index 272fbbeed1..adb83167cd 100644 --- a/examples/ip_pipeline/thread.c +++ b/examples/ip_pipeline/thread.c @@ -326,6 +326,4 @@ thread_pipeline_enable(uint32_t thread_id, /* Send request and wait for response */ rsp = thread_msg_send_recv(thread_id, req); - if (rsp == NULL) - return -1; /* Read response */ @@ -413,6 +411,4 @@ thread_pipeline_disable(uint32_t thread_id, /* Send request and wait for response */ rsp = thread_msg_send_recv(thread_id, req); - if (rsp == NULL) - return -1; /* Read response */ @@ -816,6 +812,4 @@ pipeline_port_in_stats_read(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ @@ -864,6 +858,4 @@ pipeline_port_in_enable(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ @@ -910,6 +902,4 @@ pipeline_port_in_disable(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ @@ -964,6 +954,4 @@ pipeline_port_out_stats_read(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ @@ -1020,6 +1008,4 @@ pipeline_table_stats_read(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ @@ -1437,8 +1423,4 @@ pipeline_table_rule_add(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) { - free(rule); - return -1; - } /* Read response */ @@ -1539,8 +1521,4 @@ pipeline_table_rule_add_default(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) { - free(rule); - return -1; - } /* Read response */ @@ -1656,8 +1634,4 @@ pipeline_table_rule_add_bulk(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) { - table_rule_list_free(list); - return -ENOMEM; - } /* Read response */ @@ -1734,6 +1708,4 @@ pipeline_table_rule_delete(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ @@ -1791,6 +1763,4 @@ pipeline_table_rule_delete_default(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ @@ -1858,6 +1828,4 @@ pipeline_table_rule_stats_read(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ @@ -1916,6 +1884,4 @@ pipeline_table_mtr_profile_add(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ @@ -1968,6 +1934,4 @@ pipeline_table_mtr_profile_delete(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ @@ -2038,6 +2002,4 @@ pipeline_table_rule_mtr_read(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ @@ -2097,6 +2059,4 @@ pipeline_table_dscp_table_update(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ @@ -2165,6 +2125,4 @@ pipeline_table_rule_ttl_read(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ @@ -2230,6 +2188,4 @@ pipeline_table_rule_time_read(const char *pipeline_name, /* Send request and wait for response */ rsp = pipeline_msg_send_recv(p, req); - if (rsp == NULL) - return -1; /* Read response */ -- 2.21.3 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-06-05 19:20:55.382139891 +0100 +++ 0084-examples-ip_pipeline-remove-check-of-null-response.patch 2020-06-05 19:20:50.989036747 +0100 @@ -1 +1 @@ -From 358eb13389070b34809f478678351ab99f813e5b Mon Sep 17 00:00:00 2001 +From fc250052402d70045eaf9e26b8be58de01be36c0 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 358eb13389070b34809f478678351ab99f813e5b ] + @@ -26 +27,0 @@ -Cc: stable@dpdk.org