* [dpdk-stable] [PATCH v2] lib/ring: fix bulk enqueue API to allow HTS/RTS modes
@ 2020-06-10 5:57 Feifei Wang
2020-07-01 8:44 ` [dpdk-stable] [dpdk-dev] " David Marchand
0 siblings, 1 reply; 2+ messages in thread
From: Feifei Wang @ 2020-06-10 5:57 UTC (permalink / raw)
To: Honnappa Nagarahalli, Konstantin Ananyev; +Cc: dev, nd, Feifei Wang, stable
Remove the unwanted call to "_rte_ring_do_enqueue_elem" to allow for
correct handling of RTS/HTS modes.
Fixes: e6ba4731c0f3 ("ring: introduce RTS ring mode")
Cc: stable@dpdk.org
Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
Acked-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
V2: update commit message as Honnappa suggested.
lib/librte_ring/rte_ring_elem.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/librte_ring/rte_ring_elem.h b/lib/librte_ring/rte_ring_elem.h
index a5a4c46f9..469aee7da 100644
--- a/lib/librte_ring/rte_ring_elem.h
+++ b/lib/librte_ring/rte_ring_elem.h
@@ -578,9 +578,6 @@ static __rte_always_inline unsigned int
rte_ring_enqueue_bulk_elem(struct rte_ring *r, const void *obj_table,
unsigned int esize, unsigned int n, unsigned int *free_space)
{
- return __rte_ring_do_enqueue_elem(r, obj_table, esize, n,
- RTE_RING_QUEUE_FIXED, r->prod.sync_type, free_space);
-
switch (r->prod.sync_type) {
case RTE_RING_SYNC_MT:
return rte_ring_mp_enqueue_bulk_elem(r, obj_table, esize, n,
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH v2] lib/ring: fix bulk enqueue API to allow HTS/RTS modes
2020-06-10 5:57 [dpdk-stable] [PATCH v2] lib/ring: fix bulk enqueue API to allow HTS/RTS modes Feifei Wang
@ 2020-07-01 8:44 ` David Marchand
0 siblings, 0 replies; 2+ messages in thread
From: David Marchand @ 2020-07-01 8:44 UTC (permalink / raw)
To: Feifei Wang
Cc: Honnappa Nagarahalli, Konstantin Ananyev, dev, nd, dpdk stable
On Wed, Jun 10, 2020 at 7:57 AM Feifei Wang <feifei.wang2@arm.com> wrote:
>
> Remove the unwanted call to "_rte_ring_do_enqueue_elem" to allow for
> correct handling of RTS/HTS modes.
>
> Fixes: e6ba4731c0f3 ("ring: introduce RTS ring mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Acked-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Kept ack from Konstantin on v1.
Applied, thanks.
--
David Marchand
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-01 8:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-10 5:57 [dpdk-stable] [PATCH v2] lib/ring: fix bulk enqueue API to allow HTS/RTS modes Feifei Wang
2020-07-01 8:44 ` [dpdk-stable] [dpdk-dev] " David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).