patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH 1/3] arch/arm: add vcopyq intrinsic for aarch32
       [not found] <20200424065053.119885-1-ruifeng.wang@arm.com>
@ 2020-04-24  6:50 ` Ruifeng Wang
  2020-05-01 14:55   ` Ferruh Yigit
  2020-04-24  6:50 ` [dpdk-stable] [PATCH 3/3] net/ixgbe: fix include of vector header file Ruifeng Wang
                   ` (2 subsequent siblings)
  3 siblings, 1 reply; 7+ messages in thread
From: Ruifeng Wang @ 2020-04-24  6:50 UTC (permalink / raw)
  To: wenzhuo.lu, konstantin.ananyev, jerinj, viktorin
  Cc: dev, gavin.hu, honnappa.nagarahalli, juraj.linkes, nd,
	Ruifeng Wang, stable

vcopyq_laneq_u32 should be implemented for aarch32 which doesn't have
the intrinsic.

Fixes: 3c4b4024c225 ("arch/arm: add vcopyq_laneq_u32 for old gcc")
Cc: stable@dpdk.org

Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
 lib/librte_eal/arm/include/rte_vect.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/arm/include/rte_vect.h b/lib/librte_eal/arm/include/rte_vect.h
index 9287a1117..d7c8aa61e 100644
--- a/lib/librte_eal/arm/include/rte_vect.h
+++ b/lib/librte_eal/arm/include/rte_vect.h
@@ -62,7 +62,11 @@ vaddvq_u16(uint16x8_t a)
 
 #endif
 
-#if RTE_CC_IS_GNU && (GCC_VERSION < 70000)
+#if defined(RTE_ARCH_ARM) || \
+(defined(RTE_ARCH_ARM64) && RTE_CC_IS_GNU && (GCC_VERSION < 70000))
+/* NEON intrinsic vcopyq_laneq_u32() is not supported in ARMv7-A(AArch32)
+ * On AArch64, this intrinsic is supported since GCC versioin 7.
+ */
 static inline uint32x4_t
 vcopyq_laneq_u32(uint32x4_t a, const int lane_a,
 		 uint32x4_t b, const int lane_b)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-stable] [PATCH 3/3] net/ixgbe: fix include of vector header file
       [not found] <20200424065053.119885-1-ruifeng.wang@arm.com>
  2020-04-24  6:50 ` [dpdk-stable] [PATCH 1/3] arch/arm: add vcopyq intrinsic for aarch32 Ruifeng Wang
@ 2020-04-24  6:50 ` Ruifeng Wang
       [not found] ` <20200623065856.41189-1-ruifeng.wang@arm.com>
       [not found] ` <20200624071016.210656-1-ruifeng.wang@arm.com>
  3 siblings, 0 replies; 7+ messages in thread
From: Ruifeng Wang @ 2020-04-24  6:50 UTC (permalink / raw)
  To: wenzhuo.lu, konstantin.ananyev, jerinj, viktorin
  Cc: dev, gavin.hu, honnappa.nagarahalli, juraj.linkes, nd,
	Ruifeng Wang, stable

The include of 'arm_neon.h' causes issues to old gcc and aarch32.
Including 'rte_vect.h' instead fixes these issues.

Fixes: b20971b6cca0 ("net/ixgbe: implement vector driver for ARM")
Cc: stable@dpdk.org

Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
 drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
index 293b7c8bd..aa27ee177 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
@@ -5,13 +5,12 @@
 #include <stdint.h>
 #include <rte_ethdev_driver.h>
 #include <rte_malloc.h>
+#include <rte_vect.h>
 
 #include "ixgbe_ethdev.h"
 #include "ixgbe_rxtx.h"
 #include "ixgbe_rxtx_vec_common.h"
 
-#include <arm_neon.h>
-
 #pragma GCC diagnostic ignored "-Wcast-qual"
 
 static inline void
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-stable] [PATCH 1/3] arch/arm: add vcopyq intrinsic for aarch32
  2020-04-24  6:50 ` [dpdk-stable] [PATCH 1/3] arch/arm: add vcopyq intrinsic for aarch32 Ruifeng Wang
@ 2020-05-01 14:55   ` Ferruh Yigit
  0 siblings, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2020-05-01 14:55 UTC (permalink / raw)
  To: Ruifeng Wang, wenzhuo.lu, konstantin.ananyev, jerinj, viktorin
  Cc: dev, gavin.hu, honnappa.nagarahalli, juraj.linkes, nd, stable

On 4/24/2020 7:50 AM, Ruifeng Wang wrote:
> vcopyq_laneq_u32 should be implemented for aarch32 which doesn't have
> the intrinsic.
> 
> Fixes: 3c4b4024c225 ("arch/arm: add vcopyq_laneq_u32 for old gcc")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>

This fixes build of examples/l3fwd for armv7.

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-stable] [PATCH v2 1/4] arch/arm: add vcopyq intrinsic for aarch32
       [not found] ` <20200623065856.41189-1-ruifeng.wang@arm.com>
@ 2020-06-23  6:58   ` Ruifeng Wang
  2020-06-23  6:58   ` [dpdk-stable] [PATCH v2 3/4] net/ixgbe: fix include of vector header file Ruifeng Wang
  1 sibling, 0 replies; 7+ messages in thread
From: Ruifeng Wang @ 2020-06-23  6:58 UTC (permalink / raw)
  To: Jan Viktorin, Ruifeng Wang
  Cc: dev, ferruh.yigit, honnappa.nagarahalli, juraj.linkes, nd, stable

vcopyq_laneq_u32 should be implemented for aarch32 which doesn't have
the intrinsic.
This fixes build of examples/l3fwd for armv7.

Fixes: 3c4b4024c225 ("arch/arm: add vcopyq_laneq_u32 for old gcc")
Cc: stable@dpdk.org

Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/librte_eal/arm/include/rte_vect.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/arm/include/rte_vect.h b/lib/librte_eal/arm/include/rte_vect.h
index 9287a1117..d7c8aa61e 100644
--- a/lib/librte_eal/arm/include/rte_vect.h
+++ b/lib/librte_eal/arm/include/rte_vect.h
@@ -62,7 +62,11 @@ vaddvq_u16(uint16x8_t a)
 
 #endif
 
-#if RTE_CC_IS_GNU && (GCC_VERSION < 70000)
+#if defined(RTE_ARCH_ARM) || \
+(defined(RTE_ARCH_ARM64) && RTE_CC_IS_GNU && (GCC_VERSION < 70000))
+/* NEON intrinsic vcopyq_laneq_u32() is not supported in ARMv7-A(AArch32)
+ * On AArch64, this intrinsic is supported since GCC versioin 7.
+ */
 static inline uint32x4_t
 vcopyq_laneq_u32(uint32x4_t a, const int lane_a,
 		 uint32x4_t b, const int lane_b)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-stable] [PATCH v2 3/4] net/ixgbe: fix include of vector header file
       [not found] ` <20200623065856.41189-1-ruifeng.wang@arm.com>
  2020-06-23  6:58   ` [dpdk-stable] [PATCH v2 1/4] arch/arm: add vcopyq intrinsic for aarch32 Ruifeng Wang
@ 2020-06-23  6:58   ` Ruifeng Wang
  1 sibling, 0 replies; 7+ messages in thread
From: Ruifeng Wang @ 2020-06-23  6:58 UTC (permalink / raw)
  To: Jerin Jacob, Ruifeng Wang, Wei Zhao, Jeff Guo
  Cc: dev, ferruh.yigit, honnappa.nagarahalli, juraj.linkes, nd, stable

The include of 'arm_neon.h' causes issues to old gcc and aarch32.
Including 'rte_vect.h' instead fixes these issues.

Fixes: b20971b6cca0 ("net/ixgbe: implement vector driver for ARM")
Cc: stable@dpdk.org

Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
index 293b7c8bd..aa27ee177 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
@@ -5,13 +5,12 @@
 #include <stdint.h>
 #include <rte_ethdev_driver.h>
 #include <rte_malloc.h>
+#include <rte_vect.h>
 
 #include "ixgbe_ethdev.h"
 #include "ixgbe_rxtx.h"
 #include "ixgbe_rxtx_vec_common.h"
 
-#include <arm_neon.h>
-
 #pragma GCC diagnostic ignored "-Wcast-qual"
 
 static inline void
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-stable] [PATCH v3 1/4] arch/arm: add vcopyq intrinsic for aarch32
       [not found] ` <20200624071016.210656-1-ruifeng.wang@arm.com>
@ 2020-06-24  7:10   ` Ruifeng Wang
  2020-06-24  7:10   ` [dpdk-stable] [PATCH v3 3/4] net/ixgbe: fix include of vector header file Ruifeng Wang
  1 sibling, 0 replies; 7+ messages in thread
From: Ruifeng Wang @ 2020-06-24  7:10 UTC (permalink / raw)
  To: Jan Viktorin, Ruifeng Wang
  Cc: dev, ferruh.yigit, honnappa.nagarahalli, juraj.linkes, nd, stable

vcopyq_laneq_u32 should be implemented for aarch32 which doesn't have
the intrinsic.
This fixes build of examples/l3fwd for armv7.

Fixes: 3c4b4024c225 ("arch/arm: add vcopyq_laneq_u32 for old gcc")
Cc: stable@dpdk.org

Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
 lib/librte_eal/arm/include/rte_vect.h | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/lib/librte_eal/arm/include/rte_vect.h b/lib/librte_eal/arm/include/rte_vect.h
index 9287a1117..d7c8aa61e 100644
--- a/lib/librte_eal/arm/include/rte_vect.h
+++ b/lib/librte_eal/arm/include/rte_vect.h
@@ -62,7 +62,11 @@ vaddvq_u16(uint16x8_t a)
 
 #endif
 
-#if RTE_CC_IS_GNU && (GCC_VERSION < 70000)
+#if defined(RTE_ARCH_ARM) || \
+(defined(RTE_ARCH_ARM64) && RTE_CC_IS_GNU && (GCC_VERSION < 70000))
+/* NEON intrinsic vcopyq_laneq_u32() is not supported in ARMv7-A(AArch32)
+ * On AArch64, this intrinsic is supported since GCC versioin 7.
+ */
 static inline uint32x4_t
 vcopyq_laneq_u32(uint32x4_t a, const int lane_a,
 		 uint32x4_t b, const int lane_b)
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-stable] [PATCH v3 3/4] net/ixgbe: fix include of vector header file
       [not found] ` <20200624071016.210656-1-ruifeng.wang@arm.com>
  2020-06-24  7:10   ` [dpdk-stable] [PATCH v3 1/4] arch/arm: add vcopyq intrinsic for aarch32 Ruifeng Wang
@ 2020-06-24  7:10   ` Ruifeng Wang
  1 sibling, 0 replies; 7+ messages in thread
From: Ruifeng Wang @ 2020-06-24  7:10 UTC (permalink / raw)
  To: Jerin Jacob, Ruifeng Wang, Wei Zhao, Jeff Guo
  Cc: dev, ferruh.yigit, honnappa.nagarahalli, juraj.linkes, nd, stable

The include of 'arm_neon.h' causes issues to old gcc and aarch32.
Including 'rte_vect.h' instead fixes these issues.

Fixes: b20971b6cca0 ("net/ixgbe: implement vector driver for ARM")
Cc: stable@dpdk.org

Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
index 293b7c8bd..aa27ee177 100644
--- a/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
+++ b/drivers/net/ixgbe/ixgbe_rxtx_vec_neon.c
@@ -5,13 +5,12 @@
 #include <stdint.h>
 #include <rte_ethdev_driver.h>
 #include <rte_malloc.h>
+#include <rte_vect.h>
 
 #include "ixgbe_ethdev.h"
 #include "ixgbe_rxtx.h"
 #include "ixgbe_rxtx_vec_common.h"
 
-#include <arm_neon.h>
-
 #pragma GCC diagnostic ignored "-Wcast-qual"
 
 static inline void
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20200424065053.119885-1-ruifeng.wang@arm.com>
2020-04-24  6:50 ` [dpdk-stable] [PATCH 1/3] arch/arm: add vcopyq intrinsic for aarch32 Ruifeng Wang
2020-05-01 14:55   ` Ferruh Yigit
2020-04-24  6:50 ` [dpdk-stable] [PATCH 3/3] net/ixgbe: fix include of vector header file Ruifeng Wang
     [not found] ` <20200623065856.41189-1-ruifeng.wang@arm.com>
2020-06-23  6:58   ` [dpdk-stable] [PATCH v2 1/4] arch/arm: add vcopyq intrinsic for aarch32 Ruifeng Wang
2020-06-23  6:58   ` [dpdk-stable] [PATCH v2 3/4] net/ixgbe: fix include of vector header file Ruifeng Wang
     [not found] ` <20200624071016.210656-1-ruifeng.wang@arm.com>
2020-06-24  7:10   ` [dpdk-stable] [PATCH v3 1/4] arch/arm: add vcopyq intrinsic for aarch32 Ruifeng Wang
2020-06-24  7:10   ` [dpdk-stable] [PATCH v3 3/4] net/ixgbe: fix include of vector header file Ruifeng Wang

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox