* [dpdk-stable] [PATCH] net/nfp: fix RSS hash configuration reporting
@ 2020-07-10 14:28 Heinrich Kuhn
2020-07-10 22:59 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
0 siblings, 1 reply; 3+ messages in thread
From: Heinrich Kuhn @ 2020-07-10 14:28 UTC (permalink / raw)
To: dev; +Cc: Heinrich Kuhn, stable, Simon Horman
Prior to this fix the NFP PMD implementation of the .rss_hash_conf_get
callback did not propagate the current hardware state of rss_hf back up
to the caller. Users of the hash_conf_get callback would receive an
incorrect representation of what the RSS configuration currently is in
hardware.
Fixes: 934e4c60fbff ("nfp: add RSS")
Cc: stable@dpdk.org
Signed-off-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
Signed-off-by: Simon Horman <simon.horman@netronome.com>
---
drivers/net/nfp/nfp_net.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 88e3f01d6..f47200cc4 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -2626,6 +2626,9 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev,
if (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV6)
rss_hf |= ETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_NONFRAG_IPV6_UDP;
+ /* Propagate current RSS hash functions to caller */
+ rss_conf->rss_hf = rss_hf;
+
/* Reading the key size */
rss_conf->rss_key_len = nn_cfg_readl(hw, NFP_NET_CFG_RSS_KEY_SZ);
--
2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [dpdk-stable] [dpdk-dev] [PATCH] net/nfp: fix RSS hash configuration reporting
2020-07-10 14:28 [dpdk-stable] [PATCH] net/nfp: fix RSS hash configuration reporting Heinrich Kuhn
@ 2020-07-10 22:59 ` Ferruh Yigit
0 siblings, 0 replies; 3+ messages in thread
From: Ferruh Yigit @ 2020-07-10 22:59 UTC (permalink / raw)
To: Heinrich Kuhn, dev; +Cc: stable, Simon Horman
On 7/10/2020 3:28 PM, Heinrich Kuhn wrote:
> Prior to this fix the NFP PMD implementation of the .rss_hash_conf_get
> callback did not propagate the current hardware state of rss_hf back up
> to the caller. Users of the hash_conf_get callback would receive an
> incorrect representation of what the RSS configuration currently is in
> hardware.
>
> Fixes: 934e4c60fbff ("nfp: add RSS")
> Cc: stable@dpdk.org
>
> Signed-off-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
> Signed-off-by: Simon Horman <simon.horman@netronome.com>
Applied to dpdk-next-net/master, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* [dpdk-stable] [PATCH] net/nfp: fix RSS hash configuration reporting
@ 2020-07-10 14:27 Heinrich Kuhn
0 siblings, 0 replies; 3+ messages in thread
From: Heinrich Kuhn @ 2020-07-10 14:27 UTC (permalink / raw)
To: heinrich.kuhn; +Cc: stable, Simon Horman
Prior to this fix the NFP PMD implementation of the .rss_hash_conf_get
callback did not propagate the current hardware state of rss_hf back up
to the caller. Users of the hash_conf_get callback would receive an
incorrect representation of what the RSS configuration currently is in
hardware.
Fixes: 934e4c60fbff ("nfp: add RSS")
Cc: stable@dpdk.org
Signed-off-by: Heinrich Kuhn <heinrich.kuhn@netronome.com>
Signed-off-by: Simon Horman <simon.horman@netronome.com>
---
drivers/net/nfp/nfp_net.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/nfp/nfp_net.c b/drivers/net/nfp/nfp_net.c
index 88e3f01d6..f47200cc4 100644
--- a/drivers/net/nfp/nfp_net.c
+++ b/drivers/net/nfp/nfp_net.c
@@ -2626,6 +2626,9 @@ nfp_net_rss_hash_conf_get(struct rte_eth_dev *dev,
if (cfg_rss_ctrl & NFP_NET_CFG_RSS_IPV6)
rss_hf |= ETH_RSS_NONFRAG_IPV4_UDP | ETH_RSS_NONFRAG_IPV6_UDP;
+ /* Propagate current RSS hash functions to caller */
+ rss_conf->rss_hf = rss_hf;
+
/* Reading the key size */
rss_conf->rss_key_len = nn_cfg_readl(hw, NFP_NET_CFG_RSS_KEY_SZ);
--
2.26.2
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-10 22:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-10 14:28 [dpdk-stable] [PATCH] net/nfp: fix RSS hash configuration reporting Heinrich Kuhn
2020-07-10 22:59 ` [dpdk-stable] [dpdk-dev] " Ferruh Yigit
-- strict thread matches above, loose matches on Subject: below --
2020-07-10 14:27 [dpdk-stable] " Heinrich Kuhn
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).