From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 57330A0518 for ; Fri, 24 Jul 2020 14:01:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4F0B01C02A; Fri, 24 Jul 2020 14:01:12 +0200 (CEST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id CB45C1C02A for ; Fri, 24 Jul 2020 14:01:10 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id b6so8058330wrs.11 for ; Fri, 24 Jul 2020 05:01:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=pRBHnsKaJ5ZVaDan/8tWdf7o4n2cxXHs0qMUmtfWzfo=; b=b92riyZ8UHYnhyu0Ph3uUkaZ7zNbs1t9BMgjFXaEKgb4ile1TlmD8tstFhh9i0bJlb tETyAsoZ+ABZlrCKXRXqwMLqR33UgySDGTBTyjoqARLpAKRvh1h4amJy5xCAj26SmDe4 a3UdRbJPdDYW4cPHc9ZQIfZyT6DvzA33/DAvQ13Zz0oZmEW3OLHOUy2Lo2IBx0WRUM7z LaugKWx28BGhkW9fcekhyGKdArUodcaNQPlzKiJHHKEQrIW9U75xoc6l81GeRqJxBeai IGxOfpt0lhXAKYea2SVmwmkQHzCYUyndvi3vPr5URxlvtMDYZlaCdn8tM5O3T/ooAFz3 kwWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=pRBHnsKaJ5ZVaDan/8tWdf7o4n2cxXHs0qMUmtfWzfo=; b=HjUhUdQFWk2Y+cJYyZG/q7kRSOUpJgKkm289g4a1wHDinrmBXK0Jpb1EUi43GQDmj8 cndSXL1ZfqghyZSDe3K5aYN0zYdYlV7fouYl/2RyX613MoSUOzQPQkWwEexU8mldkj/Z rqiDangPU06xpoD4u5x841XlFIZC49dSNBrGGK2SGi5s0Oh+IQ3ko1/++gCkkqi5F3N4 VcYlZ3N5DNua0Yf7abodxhJgY7pcaL/yRQj5mr/cyTbgKc/zCBt8vxVYwNTAmE0dALFY qZN15sDq8bcmYW8sPz5v3E5JWhvA93LeHcIoGJsmj2Ra4oEJroEznRUao/No1y9ZZmC6 sqsw== X-Gm-Message-State: AOAM532cptXYYue3XIlVQ+mu8Ut2blsUz1HIeCVVG7wPkz6i9bCgNnaZ ypwYKuqGUx9bjoxLs2xX2VQ= X-Google-Smtp-Source: ABdhPJxQg3fR/XlQfByYwEO/ueVG+gteFSQsH5YsA3ctDrR9bMl6cM6FddGtz8X1HQ4YXFukkceICA== X-Received: by 2002:adf:a4d7:: with SMTP id h23mr9140243wrb.276.1595592070493; Fri, 24 Jul 2020 05:01:10 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id t189sm5100203wmf.47.2020.07.24.05.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 05:01:09 -0700 (PDT) From: luca.boccassi@gmail.com To: Yunjian Wang Cc: Ferruh Yigit , dpdk stable Date: Fri, 24 Jul 2020 12:57:29 +0100 Message-Id: <20200724120030.1863487-11-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200724120030.1863487-1-luca.boccassi@gmail.com> References: <20200724120030.1863487-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'app/testpmd: fix memory leak on error path' has been queued to stable release 19.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/26/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 77b9982fa2eba4652be86d61c5662958a2902f0c Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Mon, 25 May 2020 09:46:23 +0800 Subject: [PATCH] app/testpmd: fix memory leak on error path [ upstream commit eb577e575d160eae08bcd9b7acf8a9d8fe795f89 ] This patch fixes the resource leak issue. Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands") Signed-off-by: Yunjian Wang Reviewed-by: Ferruh Yigit --- app/test-pmd/cmdline_mtr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c index ab5c8642d..045c2e28d 100644 --- a/app/test-pmd/cmdline_mtr.c +++ b/app/test-pmd/cmdline_mtr.c @@ -1262,6 +1262,7 @@ static void cmd_set_port_meter_policer_action_parsed(void *parsed_result, ret = rte_mtr_policer_actions_update(port_id, mtr_id, action_mask, actions, &error); if (ret != 0) { + free(actions); print_err_msg(&error); return; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-07-24 12:53:49.024237896 +0100 +++ 0011-app-testpmd-fix-memory-leak-on-error-path.patch 2020-07-24 12:53:48.159004075 +0100 @@ -1,12 +1,13 @@ -From eb577e575d160eae08bcd9b7acf8a9d8fe795f89 Mon Sep 17 00:00:00 2001 +From 77b9982fa2eba4652be86d61c5662958a2902f0c Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Mon, 25 May 2020 09:46:23 +0800 Subject: [PATCH] app/testpmd: fix memory leak on error path +[ upstream commit eb577e575d160eae08bcd9b7acf8a9d8fe795f89 ] + This patch fixes the resource leak issue. Fixes: e63b50162aa3 ("app/testpmd: clean metering and policing commands") -Cc: stable@dpdk.org Signed-off-by: Yunjian Wang Reviewed-by: Ferruh Yigit @@ -15,7 +16,7 @@ 1 file changed, 1 insertion(+) diff --git a/app/test-pmd/cmdline_mtr.c b/app/test-pmd/cmdline_mtr.c -index caa7e9864..ee16244de 100644 +index ab5c8642d..045c2e28d 100644 --- a/app/test-pmd/cmdline_mtr.c +++ b/app/test-pmd/cmdline_mtr.c @@ -1262,6 +1262,7 @@ static void cmd_set_port_meter_policer_action_parsed(void *parsed_result,