From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 83ED0A0518 for ; Fri, 24 Jul 2020 14:08:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7A8AC1BFE7; Fri, 24 Jul 2020 14:08:15 +0200 (CEST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id D25CC1C1AC for ; Fri, 24 Jul 2020 14:08:13 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id z18so4526377wrm.12 for ; Fri, 24 Jul 2020 05:08:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=vD4WRmUPYabDn3atrULtYXYiPeW7h+qSvkb6x+JgjiQ=; b=UxGh9IZxh1AJLBfKoIKiyhsCphEOG+H6A6HJw+chDHpKDszsF4qm88Ty/LPh8Gjbxy P/6O5UTrRSYB0JBZCF7iVrxq2ftaT3h1jhBlbQwIKE+S5c5fZm0LpoKs4RhbIKwtP1Fp ShA9nfh87RuosYpE1ThL3g579CWvKv+cfiaNJlJWu1BQjvpIHm05N4wzNO4IUpd845/X vjAj3E3ZNFXVWr7uLncb20v+KNmROnc8Qeh/99s0lpEXuSefQ5hQ4bYX12Ez3IhFVLT8 ICO4fygvfNmkTYu0DCG37P03mK4pMzFQ1GObRFsqA6brMTArkr0HIkY1ge6LzW3es/Sq q4Ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=vD4WRmUPYabDn3atrULtYXYiPeW7h+qSvkb6x+JgjiQ=; b=NKzEEN6600WdYfuyq9m2GuWrVHbc02CF4S4ZB7/GvWfdVq+pEbVnd2TIqaUaXtK5qr Q3F4sd/JqhtXh4SBA6CRtrkmm2p/tN1CuqkVcM6NIj84cqRcBTLZqt32GTNVg8dRZqVO WSWMGYRQG2XNaOJP4F8HmnJHO0wwpiNvwT0hZdvVaraqGAmI7sheeSEeqOBAihepMZwN qA28V6Y+T/odXXQEg1beriJ9r3+jlC33ru/BFlq6PNrWsS71KXveCod6tqfh/bKhzRps nwpBZpchEkaPocShFIdk9Q6AuBtEvxDqJTBP7RGbcDRwFwEU4vZxLl9rgyPWdGM1yZ2K DW8w== X-Gm-Message-State: AOAM530GKo4xIImfBdY8yqwRBuUG2OYBaz2HyJmWXH2o0uQdccZkO0Lw NVjEHcQE+mrC/Z8lWtI7V+0rG285ZcClgg== X-Google-Smtp-Source: ABdhPJw58tyKeWXPr6agAlXHJ1ZQslU8l6YD51ewImINChJS9RSdWjcnzoN1Gv9UYZcfpBG6FUqc5A== X-Received: by 2002:adf:f8d0:: with SMTP id f16mr491822wrq.66.1595592493558; Fri, 24 Jul 2020 05:08:13 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id c25sm7159084wml.18.2020.07.24.05.08.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 05:08:11 -0700 (PDT) From: luca.boccassi@gmail.com To: Xiaoyun Wang Cc: dpdk stable Date: Fri, 24 Jul 2020 12:59:12 +0100 Message-Id: <20200724120030.1863487-114-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200724120030.1863487-1-luca.boccassi@gmail.com> References: <20200724120030.1863487-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/hinic/base: remove unused function parameters' has been queued to stable release 19.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/26/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 5cae30960b80367cc858c79fdd04a951db88699d Mon Sep 17 00:00:00 2001 From: Xiaoyun Wang Date: Sat, 27 Jun 2020 11:55:45 +0800 Subject: [PATCH] net/hinic/base: remove unused function parameters [ upstream commit 214164a6bf7f840c3f111430c4e7d6373195afe1 ] Remove unused parameters for mgmt channel with no ack. Fixes: a4957d87e05a ("net/hinic/base: add mgmt module") Signed-off-by: Xiaoyun Wang --- drivers/net/hinic/base/hinic_pmd_hwdev.c | 2 +- drivers/net/hinic/base/hinic_pmd_mgmt.c | 3 +-- drivers/net/hinic/base/hinic_pmd_mgmt.h | 3 +-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/hinic/base/hinic_pmd_hwdev.c b/drivers/net/hinic/base/hinic_pmd_hwdev.c index 45b976536..8a0faa697 100644 --- a/drivers/net/hinic/base/hinic_pmd_hwdev.c +++ b/drivers/net/hinic/base/hinic_pmd_hwdev.c @@ -599,7 +599,7 @@ static int hinic_pf_rx_tx_flush(struct hinic_hwdev *hwdev) err = hinic_msg_to_mgmt_no_ack(hwdev, HINIC_MOD_COMM, HINIC_MGMT_CMD_START_FLR, &clr_res, - sizeof(clr_res), NULL, NULL); + sizeof(clr_res)); if (err) { PMD_DRV_LOG(WARNING, "Notice flush msg failed, err: %d", err); ret = err; diff --git a/drivers/net/hinic/base/hinic_pmd_mgmt.c b/drivers/net/hinic/base/hinic_pmd_mgmt.c index ea79c300a..a57036d53 100644 --- a/drivers/net/hinic/base/hinic_pmd_mgmt.c +++ b/drivers/net/hinic/base/hinic_pmd_mgmt.c @@ -504,8 +504,7 @@ int hinic_msg_to_mgmt_sync(void *hwdev, enum hinic_mod_type mod, u8 cmd, } int hinic_msg_to_mgmt_no_ack(void *hwdev, enum hinic_mod_type mod, u8 cmd, - void *buf_in, u16 in_size, __rte_unused void *buf_out, - __rte_unused u16 *out_size) + void *buf_in, u16 in_size) { struct hinic_msg_pf_to_mgmt *pf_to_mgmt = ((struct hinic_hwdev *)hwdev)->pf_to_mgmt; diff --git a/drivers/net/hinic/base/hinic_pmd_mgmt.h b/drivers/net/hinic/base/hinic_pmd_mgmt.h index 52b319ead..0f3286510 100644 --- a/drivers/net/hinic/base/hinic_pmd_mgmt.h +++ b/drivers/net/hinic/base/hinic_pmd_mgmt.h @@ -101,8 +101,7 @@ struct hinic_msg_pf_to_mgmt { }; int hinic_msg_to_mgmt_no_ack(void *hwdev, enum hinic_mod_type mod, u8 cmd, - void *buf_in, u16 in_size, void *buf_out, - u16 *out_size); + void *buf_in, u16 in_size); int hinic_comm_pf_to_mgmt_init(struct hinic_hwdev *hwdev); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-07-24 12:53:52.940512142 +0100 +++ 0114-net-hinic-base-remove-unused-function-parameters.patch 2020-07-24 12:53:48.383008248 +0100 @@ -1,12 +1,13 @@ -From 214164a6bf7f840c3f111430c4e7d6373195afe1 Mon Sep 17 00:00:00 2001 +From 5cae30960b80367cc858c79fdd04a951db88699d Mon Sep 17 00:00:00 2001 From: Xiaoyun Wang Date: Sat, 27 Jun 2020 11:55:45 +0800 Subject: [PATCH] net/hinic/base: remove unused function parameters +[ upstream commit 214164a6bf7f840c3f111430c4e7d6373195afe1 ] + Remove unused parameters for mgmt channel with no ack. Fixes: a4957d87e05a ("net/hinic/base: add mgmt module") -Cc: stable@dpdk.org Signed-off-by: Xiaoyun Wang --- @@ -16,7 +17,7 @@ 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/hinic/base/hinic_pmd_hwdev.c b/drivers/net/hinic/base/hinic_pmd_hwdev.c -index c132de09e..a93f240e3 100644 +index 45b976536..8a0faa697 100644 --- a/drivers/net/hinic/base/hinic_pmd_hwdev.c +++ b/drivers/net/hinic/base/hinic_pmd_hwdev.c @@ -599,7 +599,7 @@ static int hinic_pf_rx_tx_flush(struct hinic_hwdev *hwdev) @@ -29,7 +30,7 @@ PMD_DRV_LOG(WARNING, "Notice flush msg failed, err: %d", err); ret = err; diff --git a/drivers/net/hinic/base/hinic_pmd_mgmt.c b/drivers/net/hinic/base/hinic_pmd_mgmt.c -index 94bc45f83..babb93a20 100644 +index ea79c300a..a57036d53 100644 --- a/drivers/net/hinic/base/hinic_pmd_mgmt.c +++ b/drivers/net/hinic/base/hinic_pmd_mgmt.c @@ -504,8 +504,7 @@ int hinic_msg_to_mgmt_sync(void *hwdev, enum hinic_mod_type mod, u8 cmd,