From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2BCAA0518 for ; Fri, 24 Jul 2020 14:03:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BC5081C025; Fri, 24 Jul 2020 14:03:21 +0200 (CEST) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by dpdk.org (Postfix) with ESMTP id 1AF281C025 for ; Fri, 24 Jul 2020 14:03:20 +0200 (CEST) Received: by mail-wr1-f68.google.com with SMTP id a15so8066503wrh.10 for ; Fri, 24 Jul 2020 05:03:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+HQoNTHlgGsxHo0YfMjUgmjNBrmBjc57Y8vO29XP7+Q=; b=rVO/v+eFPw1A7+HncawomSXK48boHdfqBiLYCzUFrwEfepfyXsg8fs2dVaQpgf7OOb npQP4/SseQZLU0dW/DokO81TT/jFJNXVAMFnK6wTBPDm7FqehQPcRKQzkyoKhySCmt/t VqeN3Uho7/izhWP2qFnlG1OiVXUjpbETNkjvDN4cFoIQwwKBI2rGnwJg6cpk+k4rinFx cNbplnjorT0HpUm6/M56UcJORiZ8BsAnKiEPjaxm6pCQpqRIInH5wjsKQhxkqZkZQzLW bhpUElXJ0QyiJyV+RM2fR8zZ3l1xMvx0MSjHKmwUyh0zg/HgiPvze2iZrMVtNAMFkHs0 HIRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=+HQoNTHlgGsxHo0YfMjUgmjNBrmBjc57Y8vO29XP7+Q=; b=Vn+czLWF6dPWNeeA1Y59DUVVO4AH0b3DHVQcK0sCd392dKjyCKKmPR2lUBAXgchRjZ XMr7ofatW3gm5eiMzkpZ85LxCpfkdH4+90NNOOORLkq7MHSTRf1iMeCnP1Foneu8Rvip MDgTsbySzS2OolDv8K1ukPjfotiGaCXedKfmikD+olkJpxsPsMGx+t4xhwDb1EzDOkIp hXh/paXLtfnj51n7cT11wXwlAQyYjhJCal5Ncmlmhjy0lV/9MrqzJ6LxuzQig0e5z/Ks NZXdRI3Kx3XViLjOOP6Plw+O6dgFGVoAPR7yEaaZb851Vy5LXhUJWRU6kC2Rfy/u2jui 7Srg== X-Gm-Message-State: AOAM530KtQtlJM2quirktNPUQ7DzSRcaouXjpzZLXutKZe9kxuHcc6v/ xNQ+JuJIB3+MY8gL154XeOE= X-Google-Smtp-Source: ABdhPJwDDblQZeSveVFmhdzwPawApnCofeyGesaKvj12CTBfLdRYDp2KrSIL59VhmGuxqXGEB1CZ4Q== X-Received: by 2002:a5d:414e:: with SMTP id c14mr8976070wrq.57.1595592199839; Fri, 24 Jul 2020 05:03:19 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id u17sm1088904wrp.70.2020.07.24.05.03.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 05:03:19 -0700 (PDT) From: luca.boccassi@gmail.com To: Harman Kalra Cc: dpdk stable Date: Fri, 24 Jul 2020 12:58:00 +0100 Message-Id: <20200724120030.1863487-42-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200724120030.1863487-1-luca.boccassi@gmail.com> References: <20200724120030.1863487-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'eal/linux: fix epoll fd list rebuild for interrupts' has been queued to stable release 19.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/26/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 318c4a44965c100702b95d58c18c6c1c22bd25a7 Mon Sep 17 00:00:00 2001 From: Harman Kalra Date: Fri, 19 Jun 2020 19:29:28 +0530 Subject: [PATCH] eal/linux: fix epoll fd list rebuild for interrupts [ upstream commit 02b73b1e93a2e319e5751e0e662e6271f6f3367e ] An issue has been observed where epoll file descriptor list rebuilds every time an interrupt/alarm event is received. eal_intr_process_interrupts() should notify pipe fd only if any source is removed from the source list i.e (rv > 0) Fixes: 0c7ce182a760 ("eal: add pending interrupt callback unregister") Signed-off-by: Harman Kalra --- lib/librte_eal/linux/eal/eal_interrupts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/linux/eal/eal_interrupts.c b/lib/librte_eal/linux/eal/eal_interrupts.c index 14ebb108c..5a58f05fa 100644 --- a/lib/librte_eal/linux/eal/eal_interrupts.c +++ b/lib/librte_eal/linux/eal/eal_interrupts.c @@ -984,7 +984,7 @@ eal_intr_process_interrupts(struct epoll_event *events, int nfds) } /* notify the pipe fd waited by epoll_wait to rebuild the wait list */ - if (rv >= 0 && write(intr_pipe.writefd, "1", 1) < 0) { + if (rv > 0 && write(intr_pipe.writefd, "1", 1) < 0) { rte_spinlock_unlock(&intr_lock); return -EPIPE; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-07-24 12:53:50.234272972 +0100 +++ 0042-eal-linux-fix-epoll-fd-list-rebuild-for-interrupts.patch 2020-07-24 12:53:48.255005863 +0100 @@ -1,8 +1,10 @@ -From 02b73b1e93a2e319e5751e0e662e6271f6f3367e Mon Sep 17 00:00:00 2001 +From 318c4a44965c100702b95d58c18c6c1c22bd25a7 Mon Sep 17 00:00:00 2001 From: Harman Kalra Date: Fri, 19 Jun 2020 19:29:28 +0530 Subject: [PATCH] eal/linux: fix epoll fd list rebuild for interrupts +[ upstream commit 02b73b1e93a2e319e5751e0e662e6271f6f3367e ] + An issue has been observed where epoll file descriptor list rebuilds every time an interrupt/alarm event is received. @@ -11,18 +13,17 @@ if any source is removed from the source list i.e (rv > 0) Fixes: 0c7ce182a760 ("eal: add pending interrupt callback unregister") -Cc: stable@dpdk.org Signed-off-by: Harman Kalra --- - lib/librte_eal/linux/eal_interrupts.c | 2 +- + lib/librte_eal/linux/eal/eal_interrupts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -diff --git a/lib/librte_eal/linux/eal_interrupts.c b/lib/librte_eal/linux/eal_interrupts.c -index 16e7a7d51..84eeaa1bc 100644 ---- a/lib/librte_eal/linux/eal_interrupts.c -+++ b/lib/librte_eal/linux/eal_interrupts.c -@@ -1010,7 +1010,7 @@ eal_intr_process_interrupts(struct epoll_event *events, int nfds) +diff --git a/lib/librte_eal/linux/eal/eal_interrupts.c b/lib/librte_eal/linux/eal/eal_interrupts.c +index 14ebb108c..5a58f05fa 100644 +--- a/lib/librte_eal/linux/eal/eal_interrupts.c ++++ b/lib/librte_eal/linux/eal/eal_interrupts.c +@@ -984,7 +984,7 @@ eal_intr_process_interrupts(struct epoll_event *events, int nfds) } /* notify the pipe fd waited by epoll_wait to rebuild the wait list */