From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A01FA0518 for ; Fri, 24 Jul 2020 14:03:27 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 011A11BFE3; Fri, 24 Jul 2020 14:03:27 +0200 (CEST) Received: from mail-wm1-f46.google.com (mail-wm1-f46.google.com [209.85.128.46]) by dpdk.org (Postfix) with ESMTP id AC5CC1BFE5 for ; Fri, 24 Jul 2020 14:03:25 +0200 (CEST) Received: by mail-wm1-f46.google.com with SMTP id 3so1110882wmi.1 for ; Fri, 24 Jul 2020 05:03:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Pj0/76ytVg2hohv8luNh8KHbVdO6iVgzU34WBtwvwSI=; b=Yv097GzddfLknyIRvwYJnlqbKrFFc1+Z0r+zja23yU29SSDpwsDD9rKKO9+6LqbR1l zeXFzr1YWIDW1jMhfjyQwjn83KUQbA73uxKWoofWPbUhK7knveBy/thQbsfm7wCPweN8 5aSFRDbz1WTu1UIj6ZeLmdxsCykO0/ee6mD+a7eQkPWIztRjBlWcVX3LKL6SPbE6LYRw mqfsQ79XmliMODcoRi+Z8f6CDITazF0mF2/ggabn9WinfnWLHTSoJ3rg2IccGUwRV2V6 3k6eG+OCvD90kYhwsjGCuPRpsjRBNFuMZFSYZT9qSMPsJyCSWErhKsL3IVKbwwSwokUC 8KVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Pj0/76ytVg2hohv8luNh8KHbVdO6iVgzU34WBtwvwSI=; b=UcJhjNL0j3hTrDbCvlSIYwebneZKb77lV+0TQRUPbLfAuWkpkaUI//d/2td1A+u9xH 0VhVnklMGMQrlx1QGTwjutbejDssawK9GMCpMZSinmRziJ/k+T42jucjFnTnR5LsyNXZ gdD9UbYQPF52Q9z4VYvuyo5e4xhztvOn/9iEem3Yk4nJXwUtSTggfS/hcd0BPF0Ip1My BHCNCgImumMZyT5vAwcXNGQfCNVwDyFAeFfTkWKx+IYlZkRDvwD6AUcCuuYd8dvjovU7 e136hZftJuJrqavJnBq4/fPOSEj2Fq+SQKhP8J2FhzT8wtwbi0fDj3DogwX7yVbTiezV Qh/w== X-Gm-Message-State: AOAM533iMbm7HXqZ/7AXDh3IBZYpAlRnhfDKP/4G1zg2MHbM6CljAGm8 4Hclq9ZkokbnRVq1boI3y9A= X-Google-Smtp-Source: ABdhPJz5/BJX6Ba+yEso+knw+klOyoIdNSyf8M6V0J9pWl8RXPmviinqDH4Ucr3rSKgrrIzL/vI5Gw== X-Received: by 2002:a7b:c150:: with SMTP id z16mr8081082wmi.136.1595592205401; Fri, 24 Jul 2020 05:03:25 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id x1sm1156029wrp.10.2020.07.24.05.03.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 05:03:24 -0700 (PDT) From: luca.boccassi@gmail.com To: Hongzhi Guo Cc: =?UTF-8?q?Morten=20Br=C3=B8rup?= , Olivier Matz , dpdk stable Date: Fri, 24 Jul 2020 12:58:03 +0100 Message-Id: <20200724120030.1863487-45-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200724120030.1863487-1-luca.boccassi@gmail.com> References: <20200724120030.1863487-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net: fix IPv4 checksum' has been queued to stable release 19.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/26/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 430b02f1a047df789916fe0bcd980a3048d2c364 Mon Sep 17 00:00:00 2001 From: Hongzhi Guo Date: Tue, 26 May 2020 18:08:05 +0800 Subject: [PATCH] net: fix IPv4 checksum MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 06602c671a5ee23f517456424b216b2427c4334c ] 0xffff is invalid for IPv4 checksum (RFC1624) Fixes: 6006818cfb26 ("net: new checksum functions") Signed-off-by: Hongzhi Guo Reviewed-by: Morten Brørup Acked-by: Olivier Matz --- lib/librte_net/rte_ip.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h index 1ceb7b793..ece2e433c 100644 --- a/lib/librte_net/rte_ip.h +++ b/lib/librte_net/rte_ip.h @@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr) { uint16_t cksum; cksum = rte_raw_cksum(ipv4_hdr, sizeof(struct rte_ipv4_hdr)); - return (cksum == 0xffff) ? cksum : (uint16_t)~cksum; + return (uint16_t)~cksum; } /** -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-07-24 12:53:50.351818251 +0100 +++ 0045-net-fix-IPv4-checksum.patch 2020-07-24 12:53:48.259005938 +0100 @@ -1,4 +1,4 @@ -From 06602c671a5ee23f517456424b216b2427c4334c Mon Sep 17 00:00:00 2001 +From 430b02f1a047df789916fe0bcd980a3048d2c364 Mon Sep 17 00:00:00 2001 From: Hongzhi Guo Date: Tue, 26 May 2020 18:08:05 +0800 Subject: [PATCH] net: fix IPv4 checksum @@ -6,10 +6,11 @@ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit +[ upstream commit 06602c671a5ee23f517456424b216b2427c4334c ] + 0xffff is invalid for IPv4 checksum (RFC1624) Fixes: 6006818cfb26 ("net: new checksum functions") -Cc: stable@dpdk.org Signed-off-by: Hongzhi Guo Reviewed-by: Morten Brørup @@ -19,7 +20,7 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_net/rte_ip.h b/lib/librte_net/rte_ip.h -index 4c4437a54..292f63fd7 100644 +index 1ceb7b793..ece2e433c 100644 --- a/lib/librte_net/rte_ip.h +++ b/lib/librte_net/rte_ip.h @@ -267,7 +267,7 @@ rte_ipv4_cksum(const struct rte_ipv4_hdr *ipv4_hdr)