From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 56686A0518 for ; Fri, 24 Jul 2020 14:04:58 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4EF581C039; Fri, 24 Jul 2020 14:04:58 +0200 (CEST) Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) by dpdk.org (Postfix) with ESMTP id 52CFF1C039 for ; Fri, 24 Jul 2020 14:04:57 +0200 (CEST) Received: by mail-wr1-f67.google.com with SMTP id a14so8089475wra.5 for ; Fri, 24 Jul 2020 05:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=li1rsI/manTroTrP6ltsFljcfZaobvA+A35X/3T8fgE=; b=k4hRIFKbvAcG5cz53RfjZ+DIfwmV7+heWvJprti8VOf6qYmBqHCtkizZwJFnYLe26J aoFADdV+nfa4VR6DmJTx5niVKseAJnyLz7as6lG4vzl7DoPO5yYD0yuagREoh0Ei/lc2 8Ne7OEVoBqc6ykTOdyJ8QCgTDY6LyWEelx/oPPCB8G2bucyarT+4M00koAgk4bU4FoEt AuoxtdchtNAezQ2enPtEJO+F9v4GEYv9EjZ7Qw7NS7xg6pDYdDREpmrlkRA3GC9JVw0O aZDoiVz/7js6+bihANS4UI7Mb8N8kPARSbcVsCszFM98BrGdl6B/uxs1yxGhNdYFJBAA rxYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=li1rsI/manTroTrP6ltsFljcfZaobvA+A35X/3T8fgE=; b=n/YdljQ6Nr2o/rAJtWCBqGzxAix7u5GB5X6SXWZraTGgVzPclCGdzVyj3jJwEvqNg6 8I/+W7jBreUdhhMJgSLFdDY6hMFJZIxgy9JN0VXwk9SFa3oduf0w8pPj71vsNwkv1m+O 57/k8HXHhV+zY9RcDVnPnoAOe5FWBXFeaZnB/rpQlJT9rDshRdpDBaTvoA5s/xXNqL67 2U6dHdTAbOfzPIcAiCFr+xHwrhkhVHxeQF3E0/f7kYEOl3qt0N86JzFzjhhmfhXn5JYM /2nrhqxalXRd36LrfsM700IRx06H5FyswW4jNBq/NS593JoVvL+lTt25tQTtN6RgX0kk isTg== X-Gm-Message-State: AOAM533Gtp0KJA5lNXYGoW4tsSQV4ylt9hCOZPGXz0zhuxA9ijKiAR6m zXwUaPPjT2TGYFd4/N/n+CeIz/d06MAVPg== X-Google-Smtp-Source: ABdhPJxp6PMDa9jrvVUoukuTNlM6PjZRjuMlJPl1HpJu9htiI3T81y0wbkjCgT7maLTMmPDvfvmR6w== X-Received: by 2002:adf:f54d:: with SMTP id j13mr7884751wrp.427.1595592297012; Fri, 24 Jul 2020 05:04:57 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id b139sm7434753wmd.19.2020.07.24.05.04.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 05:04:55 -0700 (PDT) From: luca.boccassi@gmail.com To: Devendra Singh Rawat Cc: Igor Russkikh , Rasesh Mody , dpdk stable Date: Fri, 24 Jul 2020 12:58:19 +0100 Message-Id: <20200724120030.1863487-61-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200724120030.1863487-1-luca.boccassi@gmail.com> References: <20200724120030.1863487-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'net/qede: fix multicast drop in promiscuous mode' has been queued to stable release 19.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/26/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 889b24bdd1573d9839df7ffebae1e04592cdd090 Mon Sep 17 00:00:00 2001 From: Devendra Singh Rawat Date: Thu, 18 Jun 2020 13:45:55 +0530 Subject: [PATCH] net/qede: fix multicast drop in promiscuous mode [ upstream commit b10231aed1edb9cdd74a0a021a38267255952f00 ] After enabling promiscuous mode all packets whose destination MAC address is a multicast address were being dropped. This fix configures H/W to receive all traffic in promiscuous mode. Promiscuous mode also overrides allmulticast mode on/off status. Fixes: 40e9f6fc1558 ("net/qede: enable VF-VF traffic with unmatched dest address") Signed-off-by: Devendra Singh Rawat Signed-off-by: Igor Russkikh Signed-off-by: Rasesh Mody --- drivers/net/qede/qede_ethdev.c | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c index 2a1c82ac9..abb82d336 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c @@ -551,17 +551,16 @@ qed_configure_filter_rx_mode(struct rte_eth_dev *eth_dev, ECORE_ACCEPT_BCAST; if (type == QED_FILTER_RX_MODE_TYPE_PROMISC) { - flags.rx_accept_filter |= ECORE_ACCEPT_UCAST_UNMATCHED; + flags.rx_accept_filter |= (ECORE_ACCEPT_UCAST_UNMATCHED | + ECORE_ACCEPT_MCAST_UNMATCHED); if (IS_VF(edev)) { - flags.tx_accept_filter |= ECORE_ACCEPT_UCAST_UNMATCHED; - DP_INFO(edev, "Enabling Tx unmatched flag for VF\n"); + flags.tx_accept_filter |= + (ECORE_ACCEPT_UCAST_UNMATCHED | + ECORE_ACCEPT_MCAST_UNMATCHED); + DP_INFO(edev, "Enabling Tx unmatched flags for VF\n"); } } else if (type == QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC) { flags.rx_accept_filter |= ECORE_ACCEPT_MCAST_UNMATCHED; - } else if (type == (QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC | - QED_FILTER_RX_MODE_TYPE_PROMISC)) { - flags.rx_accept_filter |= ECORE_ACCEPT_UCAST_UNMATCHED | - ECORE_ACCEPT_MCAST_UNMATCHED; } return ecore_filter_accept_cmd(edev, 0, flags, false, false, @@ -1420,16 +1419,13 @@ qede_link_update(struct rte_eth_dev *eth_dev, __rte_unused int wait_to_complete) static int qede_promiscuous_enable(struct rte_eth_dev *eth_dev) { - struct qede_dev *qdev = eth_dev->data->dev_private; - struct ecore_dev *edev = &qdev->edev; + enum _ecore_status_t ecore_status; + struct qede_dev *qdev = QEDE_INIT_QDEV(eth_dev); + struct ecore_dev *edev = QEDE_INIT_EDEV(qdev); enum qed_filter_rx_mode_type type = QED_FILTER_RX_MODE_TYPE_PROMISC; - enum _ecore_status_t ecore_status; PMD_INIT_FUNC_TRACE(edev); - if (rte_eth_allmulticast_get(eth_dev->data->port_id) == 1) - type |= QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC; - ecore_status = qed_configure_filter_rx_mode(eth_dev, type); return ecore_status >= ECORE_SUCCESS ? 0 : -EAGAIN; @@ -1803,9 +1799,6 @@ static int qede_allmulticast_enable(struct rte_eth_dev *eth_dev) QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC; enum _ecore_status_t ecore_status; - if (rte_eth_promiscuous_get(eth_dev->data->port_id) == 1) - type |= QED_FILTER_RX_MODE_TYPE_PROMISC; - ecore_status = qed_configure_filter_rx_mode(eth_dev, type); return ecore_status >= ECORE_SUCCESS ? 0 : -EAGAIN; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-07-24 12:53:50.954777550 +0100 +++ 0061-net-qede-fix-multicast-drop-in-promiscuous-mode.patch 2020-07-24 12:53:48.283006385 +0100 @@ -1,15 +1,16 @@ -From b10231aed1edb9cdd74a0a021a38267255952f00 Mon Sep 17 00:00:00 2001 +From 889b24bdd1573d9839df7ffebae1e04592cdd090 Mon Sep 17 00:00:00 2001 From: Devendra Singh Rawat Date: Thu, 18 Jun 2020 13:45:55 +0530 Subject: [PATCH] net/qede: fix multicast drop in promiscuous mode +[ upstream commit b10231aed1edb9cdd74a0a021a38267255952f00 ] + After enabling promiscuous mode all packets whose destination MAC address is a multicast address were being dropped. This fix configures H/W to receive all traffic in promiscuous mode. Promiscuous mode also overrides allmulticast mode on/off status. Fixes: 40e9f6fc1558 ("net/qede: enable VF-VF traffic with unmatched dest address") -Cc: stable@dpdk.org Signed-off-by: Devendra Singh Rawat Signed-off-by: Igor Russkikh @@ -19,10 +20,10 @@ 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c -index c4f8f1258..84d2d2c03 100644 +index 2a1c82ac9..abb82d336 100644 --- a/drivers/net/qede/qede_ethdev.c +++ b/drivers/net/qede/qede_ethdev.c -@@ -625,17 +625,16 @@ qed_configure_filter_rx_mode(struct rte_eth_dev *eth_dev, +@@ -551,17 +551,16 @@ qed_configure_filter_rx_mode(struct rte_eth_dev *eth_dev, ECORE_ACCEPT_BCAST; if (type == QED_FILTER_RX_MODE_TYPE_PROMISC) { @@ -46,7 +47,7 @@ } return ecore_filter_accept_cmd(edev, 0, flags, false, false, -@@ -1502,16 +1501,13 @@ qede_link_update(struct rte_eth_dev *eth_dev, __rte_unused int wait_to_complete) +@@ -1420,16 +1419,13 @@ qede_link_update(struct rte_eth_dev *eth_dev, __rte_unused int wait_to_complete) static int qede_promiscuous_enable(struct rte_eth_dev *eth_dev) { @@ -66,7 +67,7 @@ ecore_status = qed_configure_filter_rx_mode(eth_dev, type); return ecore_status >= ECORE_SUCCESS ? 0 : -EAGAIN; -@@ -1885,9 +1881,6 @@ static int qede_allmulticast_enable(struct rte_eth_dev *eth_dev) +@@ -1803,9 +1799,6 @@ static int qede_allmulticast_enable(struct rte_eth_dev *eth_dev) QED_FILTER_RX_MODE_TYPE_MULTI_PROMISC; enum _ecore_status_t ecore_status;