From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 752F8A0518 for ; Fri, 24 Jul 2020 14:05:04 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E1241C029; Fri, 24 Jul 2020 14:05:04 +0200 (CEST) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id 398D01C0AE for ; Fri, 24 Jul 2020 14:05:03 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id f18so8053509wml.3 for ; Fri, 24 Jul 2020 05:05:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hbUgvyKbX3rfZI/PJDpQ8KXakn2GD4d7K5RiSzf4Zd8=; b=jxzdEHbuPudk7I5DovjtWh527wyelHGD/IHJ97su3ykjibl1eC0MxcfWDVJuf13h3r VLuZ4/F/T8AB5+U0/dbFzWKNV2M83qH2SP9c+VaKp8yOkhi4aL/ZdpkgwPKq1ldD2Exi nqd6zcS6cfkzDkCl3RZh794AsQP9i1x8cuFb7DNrL5Y89J5OaSRrIL6ibbUFBBQWXaBX sCLKf/X4rX9uTtE3bdS0VtDSuK9sLzoq340S9YHPvoHpVk+YCYpOaSN4Nk9ntniBBJx0 1tycRN+i+YTZd1QRc6O9uDk22KiQQULKsOSFisWv9B6PbVN0QTKRThVpYrfz9C3mJ6Wh E61Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hbUgvyKbX3rfZI/PJDpQ8KXakn2GD4d7K5RiSzf4Zd8=; b=PyV2ic6xTukPOQ3QzNpTLBWb+ZKlFPapcsZWuH3wo8Wj+r7+HgcgOLfd6iiAf4nqYJ ba9/Dwpaz7zfQawd2Tl3X/I6j+qCyGhA3waqiLm6w4HeMdPYyGWSsasCRHJhmSKb5TTu p+HP9Pit84lap9CQwZQIRsYseFhQDYfy0CCkViq1GmflkCOXuG4R5knWo4vOrbLfh6ds uBerEWlPReU9fuHuh7+x6lzJIjC7ge73iG0ERvT13RT7hzSWIyXOJ0xkohefoR1YXNkV Nk1FbL7kVOSAIXwJ7d9E1i4hcz0H5hazJjhi83zngQOSDDVJyJYpr4L/49zDI+TWJVqq NXpA== X-Gm-Message-State: AOAM5314rj9JC+wUZHxRRplr3jBL5piM3jdYT9h7ijXlshpebT8kb+tL 50ZvSPCShQyqCPCbquYtvnodmnLHlPtIQg== X-Google-Smtp-Source: ABdhPJxh1YCRFcPXZ80Q4BEQmSN5TAD9C7v/RSMJH+22LX82QyERiyhVsqvUO2BpDZJ2GKoq1NW8nw== X-Received: by 2002:a7b:cb46:: with SMTP id v6mr8976975wmj.73.1595592302923; Fri, 24 Jul 2020 05:05:02 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id n18sm1223784wrw.45.2020.07.24.05.05.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 05:05:01 -0700 (PDT) From: luca.boccassi@gmail.com To: Ruifeng Wang Cc: Ferruh Yigit , dpdk stable Date: Fri, 24 Jul 2020 12:58:21 +0100 Message-Id: <20200724120030.1863487-63-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200724120030.1863487-1-luca.boccassi@gmail.com> References: <20200724120030.1863487-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'eal/arm: add vcopyq intrinsic for aarch32' has been queued to stable release 19.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/26/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 586e03ddd6c45d15a3f49258ec8c5b67f39b6710 Mon Sep 17 00:00:00 2001 From: Ruifeng Wang Date: Wed, 24 Jun 2020 15:10:12 +0800 Subject: [PATCH] eal/arm: add vcopyq intrinsic for aarch32 [ upstream commit 4eb25acdb773b30c94adb0080659c9280bca4ee1 ] vcopyq_laneq_u32 should be implemented for aarch32 which doesn't have the intrinsic. This fixes build of examples/l3fwd for armv7. Fixes: 3c4b4024c225 ("arch/arm: add vcopyq_laneq_u32 for old gcc") Signed-off-by: Ruifeng Wang Reviewed-by: Ferruh Yigit --- lib/librte_eal/common/include/arch/arm/rte_vect.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/librte_eal/common/include/arch/arm/rte_vect.h b/lib/librte_eal/common/include/arch/arm/rte_vect.h index 2a18a6854..71e56ec63 100644 --- a/lib/librte_eal/common/include/arch/arm/rte_vect.h +++ b/lib/librte_eal/common/include/arch/arm/rte_vect.h @@ -62,7 +62,11 @@ vaddvq_u16(uint16x8_t a) #endif -#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70000) +#if defined(RTE_ARCH_ARM) || \ +(defined(RTE_ARCH_ARM64) && RTE_TOOLCHAIN_GCC && (GCC_VERSION < 70000)) +/* NEON intrinsic vcopyq_laneq_u32() is not supported in ARMv7-A(AArch32) + * On AArch64, this intrinsic is supported since GCC version 7. + */ static inline uint32x4_t vcopyq_laneq_u32(uint32x4_t a, const int lane_a, uint32x4_t b, const int lane_b) -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-07-24 12:53:51.032535390 +0100 +++ 0063-eal-arm-add-vcopyq-intrinsic-for-aarch32.patch 2020-07-24 12:53:48.287006460 +0100 @@ -1,32 +1,33 @@ -From 4eb25acdb773b30c94adb0080659c9280bca4ee1 Mon Sep 17 00:00:00 2001 +From 586e03ddd6c45d15a3f49258ec8c5b67f39b6710 Mon Sep 17 00:00:00 2001 From: Ruifeng Wang Date: Wed, 24 Jun 2020 15:10:12 +0800 Subject: [PATCH] eal/arm: add vcopyq intrinsic for aarch32 +[ upstream commit 4eb25acdb773b30c94adb0080659c9280bca4ee1 ] + vcopyq_laneq_u32 should be implemented for aarch32 which doesn't have the intrinsic. This fixes build of examples/l3fwd for armv7. Fixes: 3c4b4024c225 ("arch/arm: add vcopyq_laneq_u32 for old gcc") -Cc: stable@dpdk.org Signed-off-by: Ruifeng Wang Reviewed-by: Ferruh Yigit --- - lib/librte_eal/arm/include/rte_vect.h | 6 +++++- + lib/librte_eal/common/include/arch/arm/rte_vect.h | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -diff --git a/lib/librte_eal/arm/include/rte_vect.h b/lib/librte_eal/arm/include/rte_vect.h -index 9287a1117..01c51712a 100644 ---- a/lib/librte_eal/arm/include/rte_vect.h -+++ b/lib/librte_eal/arm/include/rte_vect.h +diff --git a/lib/librte_eal/common/include/arch/arm/rte_vect.h b/lib/librte_eal/common/include/arch/arm/rte_vect.h +index 2a18a6854..71e56ec63 100644 +--- a/lib/librte_eal/common/include/arch/arm/rte_vect.h ++++ b/lib/librte_eal/common/include/arch/arm/rte_vect.h @@ -62,7 +62,11 @@ vaddvq_u16(uint16x8_t a) #endif --#if RTE_CC_IS_GNU && (GCC_VERSION < 70000) +-#if defined(RTE_TOOLCHAIN_GCC) && (GCC_VERSION < 70000) +#if defined(RTE_ARCH_ARM) || \ -+(defined(RTE_ARCH_ARM64) && RTE_CC_IS_GNU && (GCC_VERSION < 70000)) ++(defined(RTE_ARCH_ARM64) && RTE_TOOLCHAIN_GCC && (GCC_VERSION < 70000)) +/* NEON intrinsic vcopyq_laneq_u32() is not supported in ARMv7-A(AArch32) + * On AArch64, this intrinsic is supported since GCC version 7. + */