From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 252F5A0518 for ; Fri, 24 Jul 2020 14:05:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 199841C039; Fri, 24 Jul 2020 14:05:40 +0200 (CEST) Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) by dpdk.org (Postfix) with ESMTP id F26A51C039 for ; Fri, 24 Jul 2020 14:05:38 +0200 (CEST) Received: by mail-wr1-f48.google.com with SMTP id r12so8047072wrj.13 for ; Fri, 24 Jul 2020 05:05:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=knSiuSsGTR5g07IYnN4TfO/niwusc/NYgQwqyPVGi58=; b=pT+KAvUDMsecoMUDN7sTHzGvFptFJsQVi0AcWqIUhvOCepf7xVa5JQ71ulIqoWghYU gq8c9hD4+bL8RZPN3GmG+PiSpRpzk1HdZP43LU3RIZrXbBEVOxc/ZaRpZvHA3zSyxPUS v+LezMiD+iKQ7Xs1mknOFTLPp0L25vXCiYJDSMJZbpZ18UBJ8dji8wSmeJqoGbxIhVWs 4u/CEMzlhALCVFq2s72UR2L+ccpEwOk5dipqriYIAfzvPtHRO0SM0r4ikgaIxZzV+9uD LisdACUi0gDhfxmMNkOr9tJ7832hzPbhRHm4ncqskRNHCI3sFpPxx+1VlAqE76aO5MDC EMow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=knSiuSsGTR5g07IYnN4TfO/niwusc/NYgQwqyPVGi58=; b=FD8HF9g9F2seGFdSocziz8X8krvxRb1JUJn6QCqdO8GrR52NTPuGsq70cyZ7qlePoo qhT/LB1PKp1nF1KNg+itub5YenWy5ZkZVlhhyUr9834wVFVC+Nz4sRN3VnXU93XDRe+e gC+5HzEeRan4DSPg3XlKSi5XiDGceVHX+UAldvs7Mcfx2864ocZG4cv46mhtNMhjvblt q/EV1+v5k1G6KS8N2zvp4dc+xGWeMIBiTnAEtidqzO/dd6ZRsWFAgFeMXOQmYi/H7199 dkGx4EXtAqC6JOpYnbcJu/r05qyztperMC4zD3bXZW1Lvh8w6C8U85bpFwkZqsaz3CYD Z/+w== X-Gm-Message-State: AOAM531Ks9hTdsYqkx9zTkTvu6/Lt6v27HNIbg4kjJyF3F0acuAkGBBn QuJI1WTTQT0s4ehzRIQlKNk= X-Google-Smtp-Source: ABdhPJx7+eGZk6EJ7f3q21pkdFzf/cTbqo3EcrShyWVXal4CqZzTqqFSlrqoyfYG+Nvbmc3VZv3Wjg== X-Received: by 2002:adf:ef92:: with SMTP id d18mr8985221wro.71.1595592338721; Fri, 24 Jul 2020 05:05:38 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id b186sm7335952wme.1.2020.07.24.05.05.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 05:05:37 -0700 (PDT) From: luca.boccassi@gmail.com To: Feifei Wang Cc: Ruifeng Wang , Phil Yang , Konstantin Ananyev , dpdk stable Date: Fri, 24 Jul 2020 12:58:29 +0100 Message-Id: <20200724120030.1863487-71-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200724120030.1863487-1-luca.boccassi@gmail.com> References: <20200724120030.1863487-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'test/ring: fix statistics in bulk enq/dequeue' has been queued to stable release 19.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/26/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 95ad1c1bad8db6b2ae58d5267b5e407bf7193ef7 Mon Sep 17 00:00:00 2001 From: Feifei Wang Date: Mon, 8 Jun 2020 13:58:46 +0800 Subject: [PATCH] test/ring: fix statistics in bulk enq/dequeue [ upstream commit 50959a899374cec9852eea3cd7dd638ee2d560ec ] In size 32 bulk ring enq/dequeue performance test, the "Total count" statistics is incorrect. For example, running the test on lcore 25 and lcore 26, the output is as follows: The test command: $sudo ./arm64-armv8a-linuxapp-gcc/app/test -l 25-26 RTE>>ring_perf_autotest Bulk enq/dequeue count on size 32 Core [25] count = 288268 Core [26] count = 288281 Total count (size: 32): 1066323 Fixed it by reset the counter at the beginning of each loop. The revised output is as follows: Bulk enq/dequeue count on size 32 Core [25] count = 285643 Core [26] count = 285688 Total count (size: 32): 571331 Fixes: 759cf9b5632c ("test/ring: enhance mp/mc coverage") Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang Reviewed-by: Phil Yang Acked-by: Konstantin Ananyev --- app/test/test_ring_perf.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c index 70ee46ffe..3cf27965d 100644 --- a/app/test/test_ring_perf.c +++ b/app/test/test_ring_perf.c @@ -296,12 +296,13 @@ load_loop_fn(void *p) static int run_on_all_cores(struct rte_ring *r) { - uint64_t total = 0; + uint64_t total; struct thread_params param; unsigned int i, c; memset(¶m, 0, sizeof(struct thread_params)); for (i = 0; i < RTE_DIM(bulk_sizes); i++) { + total = 0; printf("\nBulk enq/dequeue count on size %u\n", bulk_sizes[i]); param.size = bulk_sizes[i]; param.r = r; -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-07-24 12:53:51.321140254 +0100 +++ 0071-test-ring-fix-statistics-in-bulk-enq-dequeue.patch 2020-07-24 12:53:48.295006608 +0100 @@ -1,8 +1,10 @@ -From 50959a899374cec9852eea3cd7dd638ee2d560ec Mon Sep 17 00:00:00 2001 +From 95ad1c1bad8db6b2ae58d5267b5e407bf7193ef7 Mon Sep 17 00:00:00 2001 From: Feifei Wang Date: Mon, 8 Jun 2020 13:58:46 +0800 Subject: [PATCH] test/ring: fix statistics in bulk enq/dequeue +[ upstream commit 50959a899374cec9852eea3cd7dd638ee2d560ec ] + In size 32 bulk ring enq/dequeue performance test, the "Total count" statistics is incorrect. For example, running the test on lcore 25 and lcore 26, the output is as follows: @@ -25,7 +27,6 @@ Total count (size: 32): 571331 Fixes: 759cf9b5632c ("test/ring: enhance mp/mc coverage") -Cc: stable@dpdk.org Signed-off-by: Feifei Wang Reviewed-by: Ruifeng Wang @@ -36,19 +37,17 @@ 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c -index ee21faf71..ac9bf5608 100644 +index 70ee46ffe..3cf27965d 100644 --- a/app/test/test_ring_perf.c +++ b/app/test/test_ring_perf.c -@@ -380,7 +380,7 @@ load_loop_fn_16B(void *p) +@@ -296,12 +296,13 @@ load_loop_fn(void *p) static int - run_on_all_cores(struct rte_ring *r, const int esize) + run_on_all_cores(struct rte_ring *r) { - uint64_t total = 0; + uint64_t total; struct thread_params param; - lcore_function_t *lcore_f; unsigned int i, c; -@@ -392,6 +392,7 @@ run_on_all_cores(struct rte_ring *r, const int esize) memset(¶m, 0, sizeof(struct thread_params)); for (i = 0; i < RTE_DIM(bulk_sizes); i++) {