From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9E1EAA0518 for ; Fri, 24 Jul 2020 14:06:49 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 972841C0C6; Fri, 24 Jul 2020 14:06:49 +0200 (CEST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 92D011C0C6 for ; Fri, 24 Jul 2020 14:06:48 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id f18so8058291wml.3 for ; Fri, 24 Jul 2020 05:06:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PULlg04k959RhoV8/aAJXqUosAyIHNV72ET63RrDgh4=; b=mPtMTHIkbiXdw9H5nSFocaBnmC17DkoX5oW1sc7GcSFz6IOjCV5IHzIJ5c5Yoj0c6k Fy52cbn62qwCs57eQ8CqQA/c92JLWl7oQFMreiXTn998ijS8t+CCoZ8JU53uHR4JSPOL SPmMo03X5ypo7zSmMOD3Rhu8Ilbz2fVmpzmWwYb7P8Bxq/cjwXBgcvO10BAVfS2rcEpU ZxQLQR4DrHTGyx/WZ1O4UodKzqk5+GJzpx+jBwEMu3TBZeb+CogQ8FTulMoSNGOEM6QQ H/+b2cuAKbwUfIr/8Bl5cYUHbcor8O69Kq7PxRMh9fv5S/Ol0uTZHwgzwc8gOhGuuNxd dI6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PULlg04k959RhoV8/aAJXqUosAyIHNV72ET63RrDgh4=; b=J35ekZ0igbxNC1GJhm68Wu4kbNF+fQPfSbu6ROqC2ALC87XIonaQBBFLBC5UxadtuQ UbnnjF/cmaoYZrN+A8w+UUz2d6EAc+31zEFjGbz1UF6pcxscfHU1pSfmrFNoZjnyiVCg TtxLy2USBoHFzZdDLghpgLKSz+8KAeJfWvMXtPge4eObZI97lWax0p1VflXsJP/xpcM6 MLIGgRdDNBUeEYoAK7RIii/6OPI05VSP4qLy+UrQmVdst2iUxStzHhFTPTKpmYGZ6LX/ AeiZOoxofgaMeS9eCwPCYTN09EiyTMPme+GgMhWzdMsGVFNfYW8LRjH/LRnki9PsHVeW iU4A== X-Gm-Message-State: AOAM531Uj7K/RJvVuIFhSLt4g4iw9YUCoUxYgHLE/9g/Js2O6fzQdOSA 1u7urNKB2MmvH6cGrsJBYHM= X-Google-Smtp-Source: ABdhPJxM1w7eDLSgV+LNbzYn+kaCSVw6H2WRADOLuj1VfLWtihPkdca8LC/nDKBGVD+MKLjqcolAKA== X-Received: by 2002:a1c:2702:: with SMTP id n2mr8304959wmn.123.1595592408309; Fri, 24 Jul 2020 05:06:48 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id j11sm1198385wrq.69.2020.07.24.05.06.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2020 05:06:47 -0700 (PDT) From: luca.boccassi@gmail.com To: Igor Romanov Cc: Andrew Rybchenko , Harry van Haaren , Honnappa Nagarahalli , dpdk stable Date: Fri, 24 Jul 2020 12:58:49 +0100 Message-Id: <20200724120030.1863487-91-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200724120030.1863487-1-luca.boccassi@gmail.com> References: <20200724120030.1863487-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'service: fix lcore iteration' has been queued to stable release 19.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/26/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From eceee0c93bfb15a0cf3480c9fd96ac01fafb8edc Mon Sep 17 00:00:00 2001 From: Igor Romanov Date: Tue, 7 Jul 2020 11:45:24 +0100 Subject: [PATCH] service: fix lcore iteration [ upstream commit f3c256b621262e581d3edcca383df83875ab7ebe ] The service core list is populated, but not used. Incorrect lcore states are examined for a service. Use the populated list to iterate over service cores. Fixes: e484ccddbe1b ("service: avoid false sharing on core state") Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko Acked-by: Harry van Haaren Reviewed-by: Honnappa Nagarahalli --- lib/librte_eal/common/rte_service.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c index d5dd32d8d..eca6ccc59 100644 --- a/lib/librte_eal/common/rte_service.c +++ b/lib/librte_eal/common/rte_service.c @@ -397,7 +397,7 @@ rte_service_may_be_active(uint32_t id) return -EINVAL; for (i = 0; i < lcore_count; i++) { - if (lcore_states[i].service_active_on_lcore[id]) + if (lcore_states[ids[i]].service_active_on_lcore[id]) return 1; } -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-07-24 12:53:52.054228510 +0100 +++ 0091-service-fix-lcore-iteration.patch 2020-07-24 12:53:48.315006981 +0100 @@ -1,15 +1,16 @@ -From f3c256b621262e581d3edcca383df83875ab7ebe Mon Sep 17 00:00:00 2001 +From eceee0c93bfb15a0cf3480c9fd96ac01fafb8edc Mon Sep 17 00:00:00 2001 From: Igor Romanov Date: Tue, 7 Jul 2020 11:45:24 +0100 Subject: [PATCH] service: fix lcore iteration +[ upstream commit f3c256b621262e581d3edcca383df83875ab7ebe ] + The service core list is populated, but not used. Incorrect lcore states are examined for a service. Use the populated list to iterate over service cores. Fixes: e484ccddbe1b ("service: avoid false sharing on core state") -Cc: stable@dpdk.org Signed-off-by: Igor Romanov Signed-off-by: Andrew Rybchenko @@ -20,10 +21,10 @@ 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c -index 6123a2124..e2795f857 100644 +index d5dd32d8d..eca6ccc59 100644 --- a/lib/librte_eal/common/rte_service.c +++ b/lib/librte_eal/common/rte_service.c -@@ -422,7 +422,7 @@ rte_service_may_be_active(uint32_t id) +@@ -397,7 +397,7 @@ rte_service_may_be_active(uint32_t id) return -EINVAL; for (i = 0; i < lcore_count; i++) {