From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B47FA052A for ; Sat, 25 Jul 2020 14:10:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 37BE81C042; Sat, 25 Jul 2020 14:10:29 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id B09C211A2; Sat, 25 Jul 2020 14:10:25 +0200 (CEST) IronPort-SDR: R3MFi5UEnX+8gTQak8GMdcLqufaCldvwybaW6Uua5TuRaloLkarwhz4vC0F0S7T+jMFQCfkj68 BtUFb+GOIbAw== X-IronPort-AV: E=McAfee;i="6000,8403,9692"; a="130386966" X-IronPort-AV: E=Sophos;i="5.75,394,1589266800"; d="scan'208";a="130386966" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Jul 2020 05:10:24 -0700 IronPort-SDR: bU6vgSO/fd05299SbI1qVcqEcVMwyQaA4RG8k/JuBN77r2dYMY1dFS8o3hIw3GIcaQIJeXHT9V yE6jxDRcujJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.75,394,1589266800"; d="scan'208";a="489474156" Received: from dpdk51.sh.intel.com ([10.67.111.82]) by fmsmga005.fm.intel.com with ESMTP; 25 Jul 2020 05:10:23 -0700 From: Qi Zhang To: qiming.yang@intel.com Cc: simei.su@intel.com, dev@dpdk.org, Qi Zhang , stable@dpdk.org Date: Sat, 25 Jul 2020 20:14:24 +0800 Message-Id: <20200725121424.46332-1-qi.z.zhang@intel.com> X-Mailer: git-send-email 2.13.6 Subject: [dpdk-stable] [PATCH] net/ice/base: fix symmetric asymmetric RSS interference X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" A new symmetric RSS rule may force another asymmetric rule to be symmetric, vise versa. The reason is due to the flow engine will try to reuse the existing profile if the input set matches with the new rule. The fix is to disable this optimization for RSS since we are not at the situation as profile shortage. Fixes: ddae0440353f ("net/ice/base: enable symmetric hash for RSS") Cc: stable@dpdk.org Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_flex_pipe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ice/base/ice_flex_pipe.c b/drivers/net/ice/base/ice_flex_pipe.c index 284569464..999ad6be3 100644 --- a/drivers/net/ice/base/ice_flex_pipe.c +++ b/drivers/net/ice/base/ice_flex_pipe.c @@ -2808,10 +2808,10 @@ ice_find_prof_id_with_mask(struct ice_hw *hw, enum ice_block blk, struct ice_es *es = &hw->blk[blk].es; u8 i; - /* For FD, we don't want to re-use an existed profile with the same - * field vector and mask. This will cause rule interference. + /* For FD and RSS, we don't want to re-use an existed profile with the + * same field vector and mask. This will cause rule interference. */ - if (blk == ICE_BLK_FD) + if (blk == ICE_BLK_FD || blk == ICE_BLK_RSS) return ICE_ERR_DOES_NOT_EXIST; for (i = 0; i < (u8)es->count; i++) { -- 2.13.6