patches for DPDK stable branches
 help / color / Atom feed
* [dpdk-stable] [PATCH] net/ice: fix incorrect firmware version
@ 2020-08-06  8:25 Shougang Wang
  2020-08-06  9:15 ` Yang, Qiming
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Shougang Wang @ 2020-08-06  8:25 UTC (permalink / raw)
  To: dev; +Cc: qiming.yang, qi.z.zhang, Shougang Wang, stable

Kernel driver shows firmware version as hex but ice PMD shows
as decimal. This patch fixes the issue to make consistent with
kernel driver.

Fixes: ac882a0eda69 ("net/ice/base: store NVM version in extracted format")
Cc: stable@dpdk.org

Signed-off-by: Shougang Wang <shougangx.wang@intel.com>
---
 drivers/net/ice/ice_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 8d435e889..88b8428b9 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -4388,7 +4388,7 @@ ice_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size)
 	build = hw->nvm.orom.build;
 
 	ret = snprintf(fw_version, fw_size,
-			"%d.%d 0x%08x %d.%d.%d",
+			"%x.%02x 0x%08x %d.%d.%d",
 			hw->nvm.major_ver,
 			hw->nvm.minor_ver,
 			hw->nvm.eetrack,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-stable] [PATCH] net/ice: fix incorrect firmware version
  2020-08-06  8:25 [dpdk-stable] [PATCH] net/ice: fix incorrect firmware version Shougang Wang
@ 2020-08-06  9:15 ` Yang, Qiming
  2020-08-06 10:37   ` Wang, ShougangX
  2020-08-06 10:28 ` [dpdk-stable] [PATCH v2] " Shougang Wang
  2020-09-11  2:40 ` [dpdk-stable] [PATCH v3] " Shougang Wang
  2 siblings, 1 reply; 7+ messages in thread
From: Yang, Qiming @ 2020-08-06  9:15 UTC (permalink / raw)
  To: Wang, ShougangX, dev; +Cc: Zhang, Qi Z, stable



> -----Original Message-----
> From: Wang, ShougangX <shougangx.wang@intel.com>
> Sent: Thursday, August 6, 2020 16:25
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wang, ShougangX <shougangx.wang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] net/ice: fix incorrect firmware version
> 
> Kernel driver shows firmware version as hex but ice PMD shows as decimal.
> This patch fixes the issue to make consistent with kernel driver.
> 
> Fixes: ac882a0eda69 ("net/ice/base: store NVM version in extracted format")

Fix line not correct, should be the code you fixed

> Cc: stable@dpdk.org
> 
> Signed-off-by: Shougang Wang <shougangx.wang@intel.com>
> ---
>  drivers/net/ice/ice_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index 8d435e889..88b8428b9 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -4388,7 +4388,7 @@ ice_fw_version_get(struct rte_eth_dev *dev, char
> *fw_version, size_t fw_size)
>  	build = hw->nvm.orom.build;
> 
>  	ret = snprintf(fw_version, fw_size,
> -			"%d.%d 0x%08x %d.%d.%d",
> +			"%x.%02x 0x%08x %d.%d.%d",
>  			hw->nvm.major_ver,
>  			hw->nvm.minor_ver,
>  			hw->nvm.eetrack,
> --
> 2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-stable] [PATCH v2] net/ice: fix incorrect firmware version
  2020-08-06  8:25 [dpdk-stable] [PATCH] net/ice: fix incorrect firmware version Shougang Wang
  2020-08-06  9:15 ` Yang, Qiming
@ 2020-08-06 10:28 ` " Shougang Wang
  2020-08-07  1:45   ` Yang, Qiming
  2020-09-11  2:40 ` [dpdk-stable] [PATCH v3] " Shougang Wang
  2 siblings, 1 reply; 7+ messages in thread
From: Shougang Wang @ 2020-08-06 10:28 UTC (permalink / raw)
  To: dev; +Cc: qiming.yang, qi.z.zhang, Shougang Wang, stable

Kernel driver shows firmware version as hex but ice PMD shows
as decimal. This patch fixes the issue to make consistent with
kernel driver.

Fixes: f9204d8a23c3 ("net/ice: fix firmware version result of ethtool")
Cc: stable@dpdk.org

Signed-off-by: Shougang Wang <shougangx.wang@intel.com>
---
v2:
corrected fixes version
---
 drivers/net/ice/ice_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index 8d435e889..88b8428b9 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -4388,7 +4388,7 @@ ice_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size)
 	build = hw->nvm.orom.build;
 
 	ret = snprintf(fw_version, fw_size,
-			"%d.%d 0x%08x %d.%d.%d",
+			"%x.%02x 0x%08x %d.%d.%d",
 			hw->nvm.major_ver,
 			hw->nvm.minor_ver,
 			hw->nvm.eetrack,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-stable] [PATCH] net/ice: fix incorrect firmware version
  2020-08-06  9:15 ` Yang, Qiming
@ 2020-08-06 10:37   ` Wang, ShougangX
  0 siblings, 0 replies; 7+ messages in thread
From: Wang, ShougangX @ 2020-08-06 10:37 UTC (permalink / raw)
  To: Yang, Qiming, dev; +Cc: Zhang, Qi Z, stable


> -----Original Message-----
> From: Yang, Qiming <qiming.yang@intel.com>
> Sent: Thursday, August 6, 2020 5:16 PM
> To: Wang, ShougangX <shougangx.wang@intel.com>; dev@dpdk.org
> Cc: Zhang, Qi Z <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH] net/ice: fix incorrect firmware version
> 
> 
> 
> > -----Original Message-----
> > From: Wang, ShougangX <shougangx.wang@intel.com>
> > Sent: Thursday, August 6, 2020 16:25
> > To: dev@dpdk.org
> > Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; Wang, ShougangX <shougangx.wang@intel.com>;
> > stable@dpdk.org
> > Subject: [PATCH] net/ice: fix incorrect firmware version
> >
> > Kernel driver shows firmware version as hex but ice PMD shows as decimal.
> > This patch fixes the issue to make consistent with kernel driver.
> >
> > Fixes: ac882a0eda69 ("net/ice/base: store NVM version in extracted
> > format")
> 
> Fix line not correct, should be the code you fixed

OK, I will correct it.

Thanks
Shougang

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-stable] [PATCH v2] net/ice: fix incorrect firmware version
  2020-08-06 10:28 ` [dpdk-stable] [PATCH v2] " Shougang Wang
@ 2020-08-07  1:45   ` Yang, Qiming
  0 siblings, 0 replies; 7+ messages in thread
From: Yang, Qiming @ 2020-08-07  1:45 UTC (permalink / raw)
  To: Wang, ShougangX, dev; +Cc: Zhang, Qi Z, stable


> -----Original Message-----
> From: Wang, ShougangX <shougangx.wang@intel.com>
> Sent: Thursday, August 6, 2020 18:28
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wang, ShougangX <shougangx.wang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH v2] net/ice: fix incorrect firmware version
> 
> Kernel driver shows firmware version as hex but ice PMD shows as decimal.
> This patch fixes the issue to make consistent with kernel driver.
> 
> Fixes: f9204d8a23c3 ("net/ice: fix firmware version result of ethtool")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Shougang Wang <shougangx.wang@intel.com>
> ---
> v2:
> corrected fixes version
> ---
>  drivers/net/ice/ice_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
> index 8d435e889..88b8428b9 100644
> --- a/drivers/net/ice/ice_ethdev.c
> +++ b/drivers/net/ice/ice_ethdev.c
> @@ -4388,7 +4388,7 @@ ice_fw_version_get(struct rte_eth_dev *dev, char
> *fw_version, size_t fw_size)
>  	build = hw->nvm.orom.build;
> 
>  	ret = snprintf(fw_version, fw_size,
> -			"%d.%d 0x%08x %d.%d.%d",
> +			"%x.%02x 0x%08x %d.%d.%d",
>  			hw->nvm.major_ver,
>  			hw->nvm.minor_ver,
>  			hw->nvm.eetrack,
> --
> 2.17.1

Acked-by: Qiming Yang <qiming.yang@intel.com>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [dpdk-stable] [PATCH v3] net/ice: fix incorrect firmware version
  2020-08-06  8:25 [dpdk-stable] [PATCH] net/ice: fix incorrect firmware version Shougang Wang
  2020-08-06  9:15 ` Yang, Qiming
  2020-08-06 10:28 ` [dpdk-stable] [PATCH v2] " Shougang Wang
@ 2020-09-11  2:40 ` " Shougang Wang
  2020-09-11  3:37   ` Zhang, Qi Z
  2 siblings, 1 reply; 7+ messages in thread
From: Shougang Wang @ 2020-09-11  2:40 UTC (permalink / raw)
  To: dev; +Cc: qiming.yang, qi.z.zhang, Shougang Wang, stable

Kernel driver shows firmware version as hex but ice PMD shows
as decimal. This patch fixes the issue to make consistent with
kernel driver.

Fixes: f9204d8a23c3 ("net/ice: fix firmware version result of ethtool")
Cc: stable@dpdk.org

Signed-off-by: Shougang Wang <shougangx.wang@intel.com>
Acked-by: Qiming Yang <qiming.yang@intel.com>
---
v3:
code rebase
v2:
corrected fixes version
---
 drivers/net/ice/ice_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
index ca1f7d42e..4170a5446 100644
--- a/drivers/net/ice/ice_ethdev.c
+++ b/drivers/net/ice/ice_ethdev.c
@@ -4415,7 +4415,7 @@ ice_fw_version_get(struct rte_eth_dev *dev, char *fw_version, size_t fw_size)
 	build = hw->flash.orom.build;
 
 	ret = snprintf(fw_version, fw_size,
-			"%d.%d 0x%08x %d.%d.%d",
+			"%x.%02x 0x%08x %d.%d.%d",
 			hw->flash.nvm.major,
 			hw->flash.nvm.minor,
 			hw->flash.nvm.eetrack,
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [dpdk-stable] [PATCH v3] net/ice: fix incorrect firmware version
  2020-09-11  2:40 ` [dpdk-stable] [PATCH v3] " Shougang Wang
@ 2020-09-11  3:37   ` Zhang, Qi Z
  0 siblings, 0 replies; 7+ messages in thread
From: Zhang, Qi Z @ 2020-09-11  3:37 UTC (permalink / raw)
  To: Wang, ShougangX, dev; +Cc: Yang, Qiming, stable



> -----Original Message-----
> From: Wang, ShougangX <shougangx.wang@intel.com>
> Sent: Friday, September 11, 2020 10:41 AM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Wang, ShougangX <shougangx.wang@intel.com>;
> stable@dpdk.org
> Subject: [PATCH v3] net/ice: fix incorrect firmware version
> 
> Kernel driver shows firmware version as hex but ice PMD shows as decimal.
> This patch fixes the issue to make consistent with kernel driver.
> 
> Fixes: f9204d8a23c3 ("net/ice: fix firmware version result of ethtool")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Shougang Wang <shougangx.wang@intel.com>
> Acked-by: Qiming Yang <qiming.yang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-06  8:25 [dpdk-stable] [PATCH] net/ice: fix incorrect firmware version Shougang Wang
2020-08-06  9:15 ` Yang, Qiming
2020-08-06 10:37   ` Wang, ShougangX
2020-08-06 10:28 ` [dpdk-stable] [PATCH v2] " Shougang Wang
2020-08-07  1:45   ` Yang, Qiming
2020-09-11  2:40 ` [dpdk-stable] [PATCH v3] " Shougang Wang
2020-09-11  3:37   ` Zhang, Qi Z

patches for DPDK stable branches

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/stable/0 stable/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 stable stable/ http://inbox.dpdk.org/stable \
		stable@dpdk.org
	public-inbox-index stable


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.stable


AGPL code for this site: git clone https://public-inbox.org/ public-inbox