From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4766FA0351 for ; Thu, 6 Aug 2020 11:59:34 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3FED61C127; Thu, 6 Aug 2020 11:59:34 +0200 (CEST) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by dpdk.org (Postfix) with ESMTP id 96B7E1C127 for ; Thu, 6 Aug 2020 11:59:33 +0200 (CEST) Received: by mail-wr1-f47.google.com with SMTP id 88so43358927wrh.3 for ; Thu, 06 Aug 2020 02:59:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=chGFN5NB5PMSbbMGH82apY/vsgHmdylPqgV+qJZBTKU=; b=CWWYoYoZrmLrsasGzoKZhTFttxAJdWoc+LsVFKEskvMtsrp091j3LrjgnTrh5E7cyb zNaHADLhcxUZsknJwm/w+SxVh3U+b6w+5UqlKb7yvwIzyvsbOcc9LaWChhm6qvd1eRPE ErjfKwTWy4y72zBJKy4psU64XHxdwBy5dLz/Yi6VValC1MWIltxQx9dUDdh20+VEZDVF oAJ8qIYLkfXKhSrb7DZTpql2JgrWoB62NGLO/QShvYkODmpUwItEgwRVJEpVLBpZd2nd cAfAuOG/OMXSW3brK4kaWiWTEmNrRQCOVmFJQdRr25vWyBcqJZgW+DOxgSQCH1MCc02A uWhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=chGFN5NB5PMSbbMGH82apY/vsgHmdylPqgV+qJZBTKU=; b=SEOPiOOtZcSxSxDi9LgRAjn0OUD6ygAQ/oU+MYa6LKtGPupnrQg1Jy4f9EsvLo9npg EhE85UtmVkUDks/dPKKBlzcZEIx6zhArWiVh+EBs+QTL6+0QExR5DNhBwrSGRQr5Lx9r BTnOpB9q+vDjG7YFPy1nRTQsQiZf+CwDiDgGMseVI0YM/FdmOFuSAVV3KjqbbVLArHWw 3mJLFIXvweU27vHHC64Jbgn0mPXbrKYLLDNDjHvvwbbiTZasG23wqldOU+G8Xu2Ak1wj 1CT6ySnOHBhB07CA3FNA9P3Sq3Rw+A4+Fao7lABJWxZUjWcHtAKyyXT60LC6Gbc6kJRf oSew== X-Gm-Message-State: AOAM532omK1AD2YCtYvmi9kk61wF8NfpMlxKRSmX5MNEfPj142Qx3Z/X iRn3s9KmIkKNuHGxdQ1OkQCfv3iZCloYlw== X-Google-Smtp-Source: ABdhPJxs+TMtR1xqF4d3B4LLwLWJvJWmNXsOnUJ3zg1mkZAi35LX6+wNXsKlpaSQIbWvrKDEC3AG9A== X-Received: by 2002:adf:8282:: with SMTP id 2mr6579658wrc.76.1596707973288; Thu, 06 Aug 2020 02:59:33 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id k1sm5871402wrw.91.2020.08.06.02.59.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2020 02:59:32 -0700 (PDT) From: luca.boccassi@gmail.com To: Sarosh Arif Cc: dpdk stable Date: Thu, 6 Aug 2020 10:54:04 +0100 Message-Id: <20200806095411.774624-36-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200806095411.774624-1-luca.boccassi@gmail.com> References: <20200724120030.1863487-1-luca.boccassi@gmail.com> <20200806095411.774624-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'examples/packet_ordering: use proper exit method' has been queued to stable release 19.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/08/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 4ad16494bbb89beeac58ab1a02923e3e7bb87e8e Mon Sep 17 00:00:00 2001 From: Sarosh Arif Date: Fri, 5 Jun 2020 16:48:28 +0500 Subject: [PATCH] examples/packet_ordering: use proper exit method [ upstream commit d74fab8e7cc36acaf2abf83888809fd1e40c932a ] rte_exit should be called when the application exits due to invalid EAL or application arguments. Fixes: 850f3733f840 ("examples/packet_ordering: new sample app") Signed-off-by: Sarosh Arif --- examples/packet_ordering/main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c index b397b318e..edaf810d9 100644 --- a/examples/packet_ordering/main.c +++ b/examples/packet_ordering/main.c @@ -675,7 +675,7 @@ main(int argc, char **argv) /* Initialize EAL */ ret = rte_eal_init(argc, argv); if (ret < 0) - return -1; + rte_exit(EXIT_FAILURE, "Invalid EAL arguments\n"); argc -= ret; argv += ret; @@ -683,7 +683,7 @@ main(int argc, char **argv) /* Parse the application specific arguments */ ret = parse_args(argc, argv); if (ret < 0) - return -1; + rte_exit(EXIT_FAILURE, "Invalid packet_ordering arguments\n"); /* Check if we have enought cores */ if (rte_lcore_count() < 3) -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-08-06 10:53:17.190200716 +0100 +++ 0036-examples-packet_ordering-use-proper-exit-method.patch 2020-08-06 10:53:15.828597956 +0100 @@ -1,8 +1,10 @@ -From d74fab8e7cc36acaf2abf83888809fd1e40c932a Mon Sep 17 00:00:00 2001 +From 4ad16494bbb89beeac58ab1a02923e3e7bb87e8e Mon Sep 17 00:00:00 2001 From: Sarosh Arif Date: Fri, 5 Jun 2020 16:48:28 +0500 Subject: [PATCH] examples/packet_ordering: use proper exit method +[ upstream commit d74fab8e7cc36acaf2abf83888809fd1e40c932a ] + rte_exit should be called when the application exits due to invalid EAL or application arguments. @@ -14,10 +16,10 @@ 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/examples/packet_ordering/main.c b/examples/packet_ordering/main.c -index 5c654c11c..b5fc6c54b 100644 +index b397b318e..edaf810d9 100644 --- a/examples/packet_ordering/main.c +++ b/examples/packet_ordering/main.c -@@ -672,7 +672,7 @@ main(int argc, char **argv) +@@ -675,7 +675,7 @@ main(int argc, char **argv) /* Initialize EAL */ ret = rte_eal_init(argc, argv); if (ret < 0) @@ -26,7 +28,7 @@ argc -= ret; argv += ret; -@@ -680,7 +680,7 @@ main(int argc, char **argv) +@@ -683,7 +683,7 @@ main(int argc, char **argv) /* Parse the application specific arguments */ ret = parse_args(argc, argv); if (ret < 0)