From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A1FDA0351 for ; Thu, 6 Aug 2020 11:57:46 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 716AE1C0AE; Thu, 6 Aug 2020 11:57:46 +0200 (CEST) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id 88F611C0AE for ; Thu, 6 Aug 2020 11:57:45 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id p20so8486191wrf.0 for ; Thu, 06 Aug 2020 02:57:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=C061tffX1vfFA2sqhISuoDTUvd3GSLffkjz5Acu4OB4=; b=Ptky0edOJ6VjCa4PIqdKOaVQAS5/JlFdb5i/pM7FA047Xn37E7kay7+KudZXeQX1xJ VyvhYzZjCsC40lUuun6zSvCTLFZwlWc3BSkvazSLiJdqWjoC9/QHGrvj1J+dFGq2iRD+ xf4vMtj4e4u4g7pb1zrY+OiI1xM0uxzMDHUJjcPEdkHyUrCLHjSEytJEWdI7keuKXJDb eY08nnCj5lU7h9O0JmlUTiqYciQ6O2C00HVZv0f5mEF9WDRLpE1Q7DvX/4cSPvDVXUjP u0Rvxraadhn47QHjqWdfGdwmuOQyWOmD/6TYML4yNz0Ssf6e7wKJ/MGO/FCJ1NYLlBRm +75Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=C061tffX1vfFA2sqhISuoDTUvd3GSLffkjz5Acu4OB4=; b=VStJxibtiLJbBGJhpurL2GsV65aAP/TmXdnbfVreISxFXISEMKhaaf/woTJglzN67v BGNY8KmZ/yhtf1JbwT8oXTxYbGbPAtulYw4cM72vvmt2DhFEEcMyewQSUwGDmHbX2Vny uyOq94OjlOJQoba6jtpydb0Xb+zfZwIPMWHnWyIu/fSamcrfk+7VNeW4eNhBaVT4VwJd V0TEv/V9GHq3KRt+O8wn67/uPDvt8I0Ki9o9tcB/ziWi5cNQY9MoYBj+M1p+EiqgFo3w sovOT0pl7IkAZ/xX5LCVI/FAGoX5oMUKIrsDm0aMPvAed88YKeK5U8eRDIykMl/62A+3 XOJg== X-Gm-Message-State: AOAM531nSbZeVEwNJVAWvnsTaXQHUM/VKtYobtdyxzlF2HRtP6kZNWNU jD5zZXndFIE9tFUASbilTxGtlgY0r1E= X-Google-Smtp-Source: ABdhPJwk+x6+L1X7HnsPPTK62k4PkgWV7LY1k4Q55PV3yrev/if3zgAO5Q9t30xprc0b4o0eqZZBsg== X-Received: by 2002:a5d:63d1:: with SMTP id c17mr6874181wrw.241.1596707865310; Thu, 06 Aug 2020 02:57:45 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id m126sm5958859wmf.3.2020.08.06.02.57.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Aug 2020 02:57:44 -0700 (PDT) From: luca.boccassi@gmail.com To: Yunjian Wang Cc: Hemant Agrawal , dpdk stable Date: Thu, 6 Aug 2020 10:53:32 +0100 Message-Id: <20200806095411.774624-4-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200806095411.774624-1-luca.boccassi@gmail.com> References: <20200724120030.1863487-1-luca.boccassi@gmail.com> <20200806095411.774624-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'event/dpaa: remove dead code' has been queued to stable release 19.11.4 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to stable release 19.11.4 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/08/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Thanks. Luca Boccassi --- >From 31a7eed72c28508aac5f7fbf2ca9b2f3ca2b765d Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Fri, 17 Jul 2020 19:31:52 +0800 Subject: [PATCH] event/dpaa: remove dead code [ upstream commit fea678742606d794240bca2c15811c357bf0c298 ] Fix logical dead code. Coverity issue: 323495 Fixes: 77b5311d0ece ("event/dpaa: support select based event") Signed-off-by: Yunjian Wang Acked-by: Hemant Agrawal --- drivers/event/dpaa/dpaa_eventdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c index a7d57edce..29b18fe62 100644 --- a/drivers/event/dpaa/dpaa_eventdev.c +++ b/drivers/event/dpaa/dpaa_eventdev.c @@ -173,7 +173,7 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[], int ret; u16 ch_id; void *buffers[8]; - u32 num_frames, i, irq = 0; + u32 num_frames, i; uint64_t cur_ticks = 0, wait_time_ticks = 0; struct dpaa_port *portal = (struct dpaa_port *)port; struct rte_mbuf *mbuf; @@ -222,8 +222,6 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[], do { /* Lets dequeue the frames */ num_frames = qman_portal_dequeue(ev, nb_events, buffers); - if (irq) - irq = 0; if (num_frames) break; cur_ticks = rte_get_timer_cycles(); -- 2.20.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-08-06 10:53:15.966028334 +0100 +++ 0004-event-dpaa-remove-dead-code.patch 2020-08-06 10:53:15.700595422 +0100 @@ -1,13 +1,14 @@ -From fea678742606d794240bca2c15811c357bf0c298 Mon Sep 17 00:00:00 2001 +From 31a7eed72c28508aac5f7fbf2ca9b2f3ca2b765d Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Fri, 17 Jul 2020 19:31:52 +0800 Subject: [PATCH] event/dpaa: remove dead code +[ upstream commit fea678742606d794240bca2c15811c357bf0c298 ] + Fix logical dead code. Coverity issue: 323495 Fixes: 77b5311d0ece ("event/dpaa: support select based event") -Cc: stable@dpdk.org Signed-off-by: Yunjian Wang Acked-by: Hemant Agrawal @@ -16,10 +17,10 @@ 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c -index a3c138b7a..b5ae87a4e 100644 +index a7d57edce..29b18fe62 100644 --- a/drivers/event/dpaa/dpaa_eventdev.c +++ b/drivers/event/dpaa/dpaa_eventdev.c -@@ -174,7 +174,7 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[], +@@ -173,7 +173,7 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[], int ret; u16 ch_id; void *buffers[8]; @@ -28,7 +29,7 @@ uint64_t cur_ticks = 0, wait_time_ticks = 0; struct dpaa_port *portal = (struct dpaa_port *)port; struct rte_mbuf *mbuf; -@@ -223,8 +223,6 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[], +@@ -222,8 +222,6 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[], do { /* Lets dequeue the frames */ num_frames = qman_portal_dequeue(ev, nb_events, buffers);