From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 313CDA04AF for ; Thu, 20 Aug 2020 17:34:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 2815A1C0B0; Thu, 20 Aug 2020 17:34:45 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 9DB981E2B for ; Thu, 20 Aug 2020 17:34:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597937683; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=S/CN+67p6vxpNP7VTmFh34iqZwxAisUcpmsC9892WHk=; b=fZsUKzV2RjGRRF69/ZeP6SkdcxjMUYW6DBdooEc8fA5UvYW+UKb/YwqDQA5lPntRbjYept Tko945dWMgAd/iN++f+TlOnO8jdUh6IcROm9ifrivVrpoa1a6m0bytllIJbpijeWRuzUm4 NTj/asV3MURMK1ZvnOY5RoeFnL85Vho= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-21-LSdGOaskNE2LyqO1OcsyfQ-1; Thu, 20 Aug 2020 11:34:38 -0400 X-MC-Unique: LSdGOaskNE2LyqO1OcsyfQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5D1261885D82; Thu, 20 Aug 2020 15:34:37 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5DA78100AE53; Thu, 20 Aug 2020 15:34:33 +0000 (UTC) From: Kevin Traynor To: Maxime Coquelin Cc: Chenbo Xia , dpdk stable Date: Thu, 20 Aug 2020 16:33:27 +0100 Message-Id: <20200820153341.171927-22-ktraynor@redhat.com> In-Reply-To: <20200820153341.171927-1-ktraynor@redhat.com> References: <20200820153341.171927-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'vhost: fix virtio ready flag check' has been queued to LTS release 18.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 08/25/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/3cb4625e7b526db21cf96ae34a16d3dae7f4c7ea Thanks. Kevin. --- >From 3cb4625e7b526db21cf96ae34a16d3dae7f4c7ea Mon Sep 17 00:00:00 2001 From: Maxime Coquelin Date: Mon, 6 Jul 2020 13:24:45 +0200 Subject: [PATCH] vhost: fix virtio ready flag check [ upstream commit 1c3df72bda9893784267d02d2c6a3fd0047c38cd ] Before checking whether the device is ready is done a check on whether the RUNNING flag is set. Then the READY flag is set if virtio_is_ready() returns true. While it seems to not cause any issue, it makes more sense to check whether the READY flag is set and not the RUNNING one. Fixes: c0674b1bc898 ("vhost: move the device ready check at proper place") Signed-off-by: Maxime Coquelin Reviewed-by: Chenbo Xia --- lib/librte_vhost/vhost_user.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/librte_vhost/vhost_user.c b/lib/librte_vhost/vhost_user.c index 4ed75104b9..c88275c24f 100644 --- a/lib/librte_vhost/vhost_user.c +++ b/lib/librte_vhost/vhost_user.c @@ -2289,5 +2289,5 @@ skip_to_reply: } - if (!(dev->flags & VIRTIO_DEV_RUNNING) && virtio_is_ready(dev)) { + if (!(dev->flags & VIRTIO_DEV_READY) && virtio_is_ready(dev)) { dev->flags |= VIRTIO_DEV_READY; -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-08-20 16:26:16.644268315 +0100 +++ 0022-vhost-fix-virtio-ready-flag-check.patch 2020-08-20 16:26:15.808324179 +0100 @@ -1 +1 @@ -From 1c3df72bda9893784267d02d2c6a3fd0047c38cd Mon Sep 17 00:00:00 2001 +From 3cb4625e7b526db21cf96ae34a16d3dae7f4c7ea Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1c3df72bda9893784267d02d2c6a3fd0047c38cd ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org @@ -24 +25 @@ -index aa8605523a..bac3e89713 100644 +index 4ed75104b9..c88275c24f 100644 @@ -27,2 +28,2 @@ -@@ -2843,5 +2843,5 @@ skip_to_post_handle: - +@@ -2289,5 +2289,5 @@ skip_to_reply: + }