From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 22542A04B1 for ; Fri, 28 Aug 2020 12:14:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 17F72A3; Fri, 28 Aug 2020 12:14:13 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id AC2131C117 for ; Fri, 28 Aug 2020 12:14:11 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1598609651; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zb1Vz+ey0fkaXMzlcm2lb0H0xB9xjT6yRD9JyfcPcGE=; b=So8RM/XAVP4dSrjDHqJKXO+Kp0zZox6xoInKgwWbC1Nh3gEO0ab2+0g894g3o3+KpULIfb WxzUveQYEUFWAqG2lqgsP96XEni4Y7MPcSc0cq/qZ64Otp1LV0RHoNyuK2sBoi5peMQ+Jn /I4Jv1vZKMchavdfs+mvL/kOz8ieYpg= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-213-AeOdL-49P-O_COZGfs6boA-1; Fri, 28 Aug 2020 06:14:07 -0400 X-MC-Unique: AeOdL-49P-O_COZGfs6boA-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8F690807337; Fri, 28 Aug 2020 10:14:05 +0000 (UTC) Received: from rh.redhat.com (unknown [10.33.36.20]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7697519D7C; Fri, 28 Aug 2020 10:14:04 +0000 (UTC) From: Kevin Traynor To: Yunjian Wang Cc: Hemant Agrawal , dpdk stable Date: Fri, 28 Aug 2020 11:12:47 +0100 Message-Id: <20200828101308.223767-21-ktraynor@redhat.com> In-Reply-To: <20200828101308.223767-1-ktraynor@redhat.com> References: <20200828101308.223767-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ktraynor@redhat.com X-Mimecast-Spam-Score: 0.001 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 8bit Subject: [dpdk-stable] patch 'event/dpaa: remove dead code' has been queued to LTS release 18.11.10 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Sender: "stable" Hi, FYI, your patch has been queued to LTS release 18.11.10 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 09/02/20. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable-queue This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable-queue/commit/2915e71cb2b658f19aa75cf94d56471efa6bc1ff Thanks. Kevin. --- >From 2915e71cb2b658f19aa75cf94d56471efa6bc1ff Mon Sep 17 00:00:00 2001 From: Yunjian Wang Date: Fri, 17 Jul 2020 19:31:52 +0800 Subject: [PATCH] event/dpaa: remove dead code [ upstream commit fea678742606d794240bca2c15811c357bf0c298 ] Fix logical dead code. Coverity issue: 323495 Fixes: 77b5311d0ece ("event/dpaa: support select based event") Signed-off-by: Yunjian Wang Acked-by: Hemant Agrawal --- drivers/event/dpaa/dpaa_eventdev.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/event/dpaa/dpaa_eventdev.c b/drivers/event/dpaa/dpaa_eventdev.c index 15707e22e6..5e6338e843 100644 --- a/drivers/event/dpaa/dpaa_eventdev.c +++ b/drivers/event/dpaa/dpaa_eventdev.c @@ -171,5 +171,5 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[], u16 ch_id; void *buffers[8]; - u32 num_frames, i, irq = 0; + u32 num_frames, i; uint64_t cur_ticks = 0, wait_time_ticks = 0; struct dpaa_port *portal = (struct dpaa_port *)port; @@ -220,6 +220,4 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[], /* Lets dequeue the frames */ num_frames = qman_portal_dequeue(ev, nb_events, buffers); - if (irq) - irq = 0; if (num_frames) break; -- 2.26.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2020-08-28 11:03:26.444916778 +0100 +++ 0021-event-dpaa-remove-dead-code.patch 2020-08-28 11:03:25.947955640 +0100 @@ -1 +1 @@ -From fea678742606d794240bca2c15811c357bf0c298 Mon Sep 17 00:00:00 2001 +From 2915e71cb2b658f19aa75cf94d56471efa6bc1ff Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fea678742606d794240bca2c15811c357bf0c298 ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -19 +20 @@ -index a3c138b7a0..b5ae87a4ea 100644 +index 15707e22e6..5e6338e843 100644 @@ -22 +23 @@ -@@ -175,5 +175,5 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[], +@@ -171,5 +171,5 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[], @@ -29 +30 @@ -@@ -224,6 +224,4 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[], +@@ -220,6 +220,4 @@ dpaa_event_dequeue_burst(void *port, struct rte_event ev[],